Skip to contentSkip to conversation

tests: move common definitions and functions into pidfd.h

PATCH In review Suren Baghdasaryan 4 participants 9 messages Jul 26, 2019 – Aug 6, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 tests: move common definitions and functions into pidfd.h

Move definitions and functions used across different pidfd tests into pidfd.h header.

---
Changes since v1 (https://lore.kernel.org/linux-kselftest/[email protected])
- Move common test definitions and functions into pidfd.h as per Christian Brauner
- Code cleanup and additional error handling as per Christian Brauner
Changes since v2 (https://lore.kernel.org/linux-kselftest/[email protected])
- Added waitpid to prevent zombies as per Yann Droneaud

Patches are based on v5.3-rc1 in Linus' tree.

---
 tools/testing/selftests/pidfd/pidfd.h          | 18 ++++++++++++++++++
 .../testing/selftests/pidfd/pidfd_open_test.c  |  5 -----
 tools/testing/selftests/pidfd/pidfd_test.c     | 10 ----------
 3 files changed, 18 insertions(+), 15 deletions(-)
tools/testing/selftests/pidfd/pidfd.h +18 -0
index 8452e910463f..db4377af6be7 100644
@@ -16,6 +16,14 @@
 
 #include "../kselftest.h"
 
+#ifndef __NR_pidfd_open
+#define __NR_pidfd_open -1
+#endif
+
+#ifndef __NR_pidfd_send_signal
+#define __NR_pidfd_send_signal -1
+#endif
+
 /*
  * The kernel reserves 300 pids via RESERVED_PIDS in kernel/pid.c
  * That means, when it wraps around any pid < 300 will be skipped.
@@ -53,5 +61,15 @@ int wait_for_pid(pid_t pid)
 	return WEXITSTATUS(status);
 }
 
+static inline int sys_pidfd_open(pid_t pid, unsigned int flags)
+{
+	return syscall(__NR_pidfd_open, pid, flags);
+}
+
+static inline int sys_pidfd_send_signal(int pidfd, int sig, siginfo_t *info,
+					unsigned int flags)
+{
+	return syscall(__NR_pidfd_send_signal, pidfd, sig, info, flags);
+}
 
 #endif /* __PIDFD_H */
tools/testing/selftests/pidfd/pidfd_open_test.c +0 -5
index 0377133dd6dc..b9fe75fc3e51 100644
@@ -22,11 +22,6 @@
 #include "pidfd.h"
 #include "../kselftest.h"
 
-static inline int sys_pidfd_open(pid_t pid, unsigned int flags)
-{
-	return syscall(__NR_pidfd_open, pid, flags);
-}
-
 static int safe_int(const char *numstr, int *converted)
 {
 	char *err = NULL;
tools/testing/selftests/pidfd/pidfd_test.c +0 -10
index 7eaa8a3de262..17b2fd621726 100644
@@ -21,10 +21,6 @@
 #include "pidfd.h"
 #include "../kselftest.h"
 
-#ifndef __NR_pidfd_send_signal
-#define __NR_pidfd_send_signal -1
-#endif
-
 #define str(s) _str(s)
 #define _str(s) #s
 #define CHILD_THREAD_MIN_WAIT 3 /* seconds */
@@ -47,12 +43,6 @@ static pid_t pidfd_clone(int flags, int *pidfd, int (*fn)(void *))
 #endif
 }
 
-static inline int sys_pidfd_send_signal(int pidfd, int sig, siginfo_t *info,
-					unsigned int flags)
-{
-	return syscall(__NR_pidfd_send_signal, pidfd, sig, info, flags);
-}
-
 static int signal_received;
 
 static void set_signal_received_on_sigusr1(int sig)
Signature · 1 line
2.22.0.709.g102302147b-goog
#1 lore raw

PATCH v3 2/2 tests: add pidfd poll tests

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

---
 tools/testing/selftests/pidfd/.gitignore      |   1 +
 tools/testing/selftests/pidfd/Makefile        |   2 +-
 .../testing/selftests/pidfd/pidfd_poll_test.c | 117 ++++++++++++++++++
 3 files changed, 119 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/pidfd/pidfd_poll_test.c
tools/testing/selftests/pidfd/.gitignore +1 -0
index 16d84d117bc0..a67896347d34 100644
@@ -1,2 +1,3 @@
 pidfd_open_test
+pidfd_poll_test
 pidfd_test
tools/testing/selftests/pidfd/Makefile +1 -1
index 720b2d884b3c..ed58b7108d18 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 CFLAGS += -g -I../../../../usr/include/ -lpthread
 
-TEST_GEN_PROGS := pidfd_test pidfd_open_test
+TEST_GEN_PROGS := pidfd_test pidfd_open_test pidfd_poll_test
 
 include ../lib.mk
 
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +117 -0

117 lines not on this page · raw message

Signature · 1 line
2.22.0.709.g102302147b-goog
Reviewed-by on v3 2/2
#2 lore raw

Re: [PATCH v3 2/2] tests: add pidfd poll tests

Quoted 19 lines · Suren Baghdasaryan

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

---

tools/testing/selftests/pidfd/pidfd_poll_test.c line 108

Quoted 2 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +2 -0
+		close(pidfd);
+		// Wait for child to prevent zombies

Comment style should be /* */, but I think Christian would be kind enough to fix that when he applies the patch so shouldn't need a resend.

Thanks Suren and Christian!

#3 lore raw

Re: [PATCH v3 2/2] tests: add pidfd poll tests

Quoted 18 lines · Joel Fernandes
Quoted 16 lines · Suren Baghdasaryan

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

Quoted 8 lines

tools/testing/selftests/pidfd/pidfd_poll_test.c line 108

Quoted 5 lines

---

tools/testing/selftests/pidfd/pidfd_poll_test.c new file +2 -0
+             close(pidfd);
+             // Wait for child to prevent zombies

Comment style should be /* */, but I think Christian would be kind enough to fix that when he applies the patch so shouldn't need a resend.

Agrh! That's what I get for constantly switching between kernel and userspace development :\
Christian please let me know if I should respin this or you can fix it when taking this patch.
Thanks!

Quoted 5 lines

Thanks Suren and Christian!

#4 lore raw

Re: [PATCH v3 2/2] tests: add pidfd poll tests

In reply to Joel Fernandes
Quoted 17 lines · Joel Fernandes
Quoted 16 lines · Suren Baghdasaryan

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

Quoted 8 lines

tools/testing/selftests/pidfd/pidfd_poll_test.c line 108

Quoted 5 lines

---

tools/testing/selftests/pidfd/pidfd_poll_test.c new file +2 -0
+		close(pidfd);
+		// Wait for child to prevent zombies

Comment style should be /* */, but I think Christian would be kind enough to fix that when he applies the patch so shouldn't need a resend.

No, I will force you to resend this whole thing. :)
Jk, I'll replace the // when I apply it to my tree; no problem. :)

Quoted 5 lines

Thanks Suren and Christian!

#5 lore raw

Re: [PATCH v3 2/2] tests: add pidfd poll tests

In reply to Suren Baghdasaryan

Hi,

Quoted 66 lines · Suren Baghdasaryan

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

---
 tools/testing/selftests/pidfd/.gitignore      |   1 +
 tools/testing/selftests/pidfd/Makefile        |   2 +-
 .../testing/selftests/pidfd/pidfd_poll_test.c | 117 ++++++++++++++++++
 3 files changed, 119 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/pidfd/pidfd_poll_test.c
tools/testing/selftests/pidfd/.gitignore +1 -0
index 16d84d117bc0..a67896347d34 100644
@@ -1,2 +1,3 @@
 pidfd_open_test
+pidfd_poll_test
 pidfd_test
tools/testing/selftests/pidfd/Makefile +1 -1
index 720b2d884b3c..ed58b7108d18 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 CFLAGS += -g -I../../../../usr/include/ -lpthread
 
-TEST_GEN_PROGS := pidfd_test pidfd_open_test
+TEST_GEN_PROGS := pidfd_test pidfd_open_test pidfd_poll_test
 
 include ../lib.mk
 
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +15 -0
new file mode 100644
index 000000000000..f1b62b91e53e
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#define _GNU_SOURCE
+#include <errno.h>
+#include <linux/types.h>
+#include <linux/wait.h>
+#include <poll.h>
+#include <signal.h>
+#include <stdbool.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <syscall.h>
+#include <sys/wait.h>
+#include <unistd.h>

tools/testing/selftests/pidfd/pidfd_poll_test.c line 25

Quoted 10 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +10 -0
+
+#include "pidfd.h"
+#include "../kselftest.h"
+
+static bool timeout;
+
+static void handle_alarm(int sig)
+{
+	timeout = true;
+}

Not needed if poll() timeout is used instead.

Quoted 29 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +29 -0
+
+int main(int argc, char **argv)
+{
+	struct pollfd fds;
+	int iter, nevents;
+	int nr_iterations = 10000;
+
+	fds.events = POLLIN;
+
+	if (argc > 2)
+		ksft_exit_fail_msg("Unexpected command line argument\n");
+
+	if (argc == 2) {
+		nr_iterations = atoi(argv[1]);
+		if (nr_iterations <= 0)
+			ksft_exit_fail_msg("invalid input parameter %s\n",
+					argv[1]);
+	}
+
+	ksft_print_msg("running pidfd poll test for %d iterations\n",
+		nr_iterations);
+
+	for (iter = 0; iter < nr_iterations; iter++) {
+		int pidfd;
+		int child_pid = fork();
+
+		if (child_pid < 0) {
+			if (errno == EAGAIN) {
+				iter--;

tools/testing/selftests/pidfd/pidfd_poll_test.c line 64

Quoted 10 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +10 -0
+				continue;
+			}
+			ksft_exit_fail_msg(
+				"%s - failed to fork a child process\n",
+				strerror(errno));
+		}
+
+		if (child_pid == 0) {
+			/* Child process just sleeps for a min and exits */
+			sleep(60);

Instead of relying on a timer for no reason, I would use the following:

	while (1)
		pause();
Quoted 5 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +5 -0
+			exit(EXIT_SUCCESS);
+		}
+
+		/* Parent kills the child and waits for its death */
+		pidfd = sys_pidfd_open(child_pid, 0);

tools/testing/selftests/pidfd/pidfd_poll_test.c line 79

Quoted 10 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +10 -0
+		if (pidfd < 0)
+			ksft_exit_fail_msg("%s - pidfd_open failed\n",
+					strerror(errno));
+
+		/* Setup 3 sec alarm - plenty of time */
+		if (signal(SIGALRM, handle_alarm) == SIG_ERR)
+			ksft_exit_fail_msg("%s - signal failed\n",
+					strerror(errno));
+		alarm(3);
+

Would the poll() timeout be more simpler to use than relying on
SIGALRM: no need to setup signal, no need for handler, no need for timeout variable.

tools/testing/selftests/pidfd/pidfd_poll_test.c line 88

Quoted 9 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +9 -0
+		/* Send SIGKILL to the child */
+		if (sys_pidfd_send_signal(pidfd, SIGKILL, NULL, 0))
+			ksft_exit_fail_msg("%s - pidfd_send_signal failed\n",
+					strerror(errno));
+
+		/* Wait for the death notification */
+		fds.fd = pidfd;
+		nevents = poll(&fds, 1, -1);
+

With

        nevents = poll(&fds, 1, 3000);

tools/testing/selftests/pidfd/pidfd_poll_test.c line 93

Quoted 5 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +5 -0
+		/* Check for error conditions */
+		if (nevents < 0)
+			ksft_exit_fail_msg("%s - poll failed\n",
+					strerror(errno));
+

And

	if (nevents == 0)
		ksft_exit_fail_msg(
			"death notification wait timeout\n");
Quoted 8 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +8 -0
+		if (nevents != 1)
+			ksft_exit_fail_msg("unexpected poll result: %d\n",
+					nevents);
+
+		if (!(fds.revents & POLLIN))
+			ksft_exit_fail_msg(
+				"unexpected event type received: 0x%x\n",
+				fds.revents);

tools/testing/selftests/pidfd/pidfd_poll_test.c line 111

Quoted 10 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +10 -0
+
+		if (timeout)
+			ksft_exit_fail_msg(
+				"death notification wait timeout\n");
+
+		close(pidfd);
+		// Wait for child to prevent zombies
+		if (waitpid(child_pid, NULL, 0) < 0)
+			ksft_exit_fail_msg("%s - waitpid failed\n",
+					strerror(errno));

I feel safer now you defeated the zombies army :) Thanks.

tools/testing/selftests/pidfd/pidfd_poll_test.c line 117

Quoted 6 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +6 -0
+
+	}
+
+	ksft_test_result_pass("pidfd poll test: pass\n");
+	return ksft_exit_pass();
+}

Regards

Signature · 2 lines
Yann Droneaud
OPTEYA
#6 lore raw

Re: [PATCH v3 2/2] tests: add pidfd poll tests

Quoted 2 lines · Yann Droneaud

Hi,

Hi Yann,
So sorry I missed your email. My email filters were messed up and I
fixed them now but missed a bunch of emails :(

Quoted 123 lines · Suren Baghdasaryan
Quoted 66 lines

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

---
 tools/testing/selftests/pidfd/.gitignore      |   1 +
 tools/testing/selftests/pidfd/Makefile        |   2 +-
 .../testing/selftests/pidfd/pidfd_poll_test.c | 117 ++++++++++++++++++
 3 files changed, 119 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/pidfd/pidfd_poll_test.c
tools/testing/selftests/pidfd/.gitignore +1 -0
index 16d84d117bc0..a67896347d34 100644
@@ -1,2 +1,3 @@
 pidfd_open_test
+pidfd_poll_test
 pidfd_test
tools/testing/selftests/pidfd/Makefile +1 -1
index 720b2d884b3c..ed58b7108d18 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 CFLAGS += -g -I../../../../usr/include/ -lpthread
 
-TEST_GEN_PROGS := pidfd_test pidfd_open_test
+TEST_GEN_PROGS := pidfd_test pidfd_open_test pidfd_poll_test
 
 include ../lib.mk
 
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +15 -0
new file mode 100644
index 000000000000..f1b62b91e53e
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#define _GNU_SOURCE
+#include <errno.h>
+#include <linux/types.h>
+#include <linux/wait.h>
+#include <poll.h>
+#include <signal.h>
+#include <stdbool.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <syscall.h>
+#include <sys/wait.h>
+#include <unistd.h>

tools/testing/selftests/pidfd/pidfd_poll_test.c line 25

Quoted 10 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +10 -0
+
+#include "pidfd.h"
+#include "../kselftest.h"
+
+static bool timeout;
+
+static void handle_alarm(int sig)
+{
+     timeout = true;
+}

Not needed if poll() timeout is used instead.

Quoted 29 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +29 -0
+
+int main(int argc, char **argv)
+{
+     struct pollfd fds;
+     int iter, nevents;
+     int nr_iterations = 10000;
+
+     fds.events = POLLIN;
+
+     if (argc > 2)
+             ksft_exit_fail_msg("Unexpected command line argument\n");
+
+     if (argc == 2) {
+             nr_iterations = atoi(argv[1]);
+             if (nr_iterations <= 0)
+                     ksft_exit_fail_msg("invalid input parameter %s\n",
+                                     argv[1]);
+     }
+
+     ksft_print_msg("running pidfd poll test for %d iterations\n",
+             nr_iterations);
+
+     for (iter = 0; iter < nr_iterations; iter++) {
+             int pidfd;
+             int child_pid = fork();
+
+             if (child_pid < 0) {
+                     if (errno == EAGAIN) {
+                             iter--;

tools/testing/selftests/pidfd/pidfd_poll_test.c line 64

Quoted 10 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +10 -0
+                             continue;
+                     }
+                     ksft_exit_fail_msg(
+                             "%s - failed to fork a child process\n",
+                             strerror(errno));
+             }
+
+             if (child_pid == 0) {
+                     /* Child process just sleeps for a min and exits */
+                     sleep(60);

Instead of relying on a timer for no reason, I would use the following:

Quoted 3 lines
        while (1)
                pause();

Yeah, not much difference I think. If you don't strongly object I'll keep it this way.

Quoted 11 lines
Quoted 11 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +11 -0
+                     exit(EXIT_SUCCESS);
+             }
+
+             /* Parent kills the child and waits for its death */
+             pidfd = sys_pidfd_open(child_pid, 0);
+             if (pidfd < 0)
+                     ksft_exit_fail_msg("%s - pidfd_open failed\n",
+                                     strerror(errno));
+
+             /* Setup 3 sec alarm - plenty of time */
+             if (signal(SIGALRM, handle_alarm) == SIG_ERR)
Quoted 8 lines

tools/testing/selftests/pidfd/pidfd_poll_test.c line 79

Quoted 4 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +4 -0
+                     ksft_exit_fail_msg("%s - signal failed\n",
+                                     strerror(errno));
+             alarm(3);
+

Would the poll() timeout be more simpler to use than relying on
SIGALRM: no need to setup signal, no need for handler, no need for timeout variable.

Unfortunately that would not work because after timeout is passed poll() checks for the condition one last time, it sees that the process is dead (the condition is satisfied) and it returns nevents==1 (event did happen) instead of nevents==0 (poll timed out). I did implement it this way originally and was surprised that it never timed out even when I saw a 3 sec delay but then figured it out after going through the kernel code.

Quoted 37 lines

tools/testing/selftests/pidfd/pidfd_poll_test.c line 88

Quoted 9 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +9 -0
+             /* Send SIGKILL to the child */
+             if (sys_pidfd_send_signal(pidfd, SIGKILL, NULL, 0))
+                     ksft_exit_fail_msg("%s - pidfd_send_signal failed\n",
+                                     strerror(errno));
+
+             /* Wait for the death notification */
+             fds.fd = pidfd;
+             nevents = poll(&fds, 1, -1);
+

With

        nevents = poll(&fds, 1, 3000);

tools/testing/selftests/pidfd/pidfd_poll_test.c line 93

Quoted 5 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +5 -0
+             /* Check for error conditions */
+             if (nevents < 0)
+                     ksft_exit_fail_msg("%s - poll failed\n",
+                                     strerror(errno));
+

And

        if (nevents == 0)
                ksft_exit_fail_msg(
                        "death notification wait timeout\n");
Quoted 12 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +12 -0
+             if (nevents != 1)
+                     ksft_exit_fail_msg("unexpected poll result: %d\n",
+                                     nevents);
+
+             if (!(fds.revents & POLLIN))
+                     ksft_exit_fail_msg(
+                             "unexpected event type received: 0x%x\n",
+                             fds.revents);
+
+             if (timeout)
+                     ksft_exit_fail_msg(
+                             "death notification wait timeout\n");
Quoted 8 lines

tools/testing/selftests/pidfd/pidfd_poll_test.c line 111

Quoted 6 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +6 -0
+
+             close(pidfd);
+             // Wait for child to prevent zombies
+             if (waitpid(child_pid, NULL, 0) < 0)
+                     ksft_exit_fail_msg("%s - waitpid failed\n",
+                                     strerror(errno));

I feel safer now you defeated the zombies army :) Thanks.

Thanks for pointing it out!

Quoted 10 lines

tools/testing/selftests/pidfd/pidfd_poll_test.c line 117

Quoted 7 lines
tools/testing/selftests/pidfd/pidfd_poll_test.c new file +6 -0
+
+     }
+
+     ksft_test_result_pass("pidfd poll test: pass\n");
+     return ksft_exit_pass();
+}

Regards

Quoted 4 lines

--
Yann Droneaud
OPTEYA

Thanks,
Suren.

Quoted 4 lines

--
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].

#7 lore raw

Re: [PATCH v3 2/2] tests: add pidfd poll tests

In reply to Suren Baghdasaryan
Quoted 11 lines · Suren Baghdasaryan

This adds testing for polling on pidfd of a process being killed. Test runs 10000 iterations by default to stress test pidfd polling functionality. It accepts an optional command-line parameter to override the number or iterations to run.
Specifically, it tests for:
- pidfd_open on a child process succeeds
- pidfd_send_signal on a child process succeeds
- polling on pidfd succeeds and returns exactly one event
- returned event is POLLIN
- event is received within 3 secs of the process being killed

Quoted 6 lines

10000 iterations was chosen because of the race condition being tested
which is not consistently reproducible but usually is revealed after less than 2000 iterations.
Reveals race fixed by commit b191d6491be6 ("pidfd: fix a poll race when setting exit_state")

Applied-to:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=pidfd

Tracked-in:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=for-next

#8 lore raw
In reply to Suren Baghdasaryan
Quoted 5 lines · Suren Baghdasaryan

Move definitions and functions used across different pidfd tests into pidfd.h header.

Applied-to:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=pidfd

Tracked-in:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=for-next