net: phylink: Fix flow control for fixed-link
Subsystems (4)
PATCH 1/1 net: phylink: Fix flow control for fixed-link
In phylink_parse_fixedlink() the pl->link_config.advertising bits are AND with pl->supported, pl->supported is zeroed and only the speed/duplex modes and MII bits are set.
So pl->link_config.advertising always loses the flow control/pause bits.
By setting Pause and Asym_Pause bits in pl->supported, the flow control work again when devicetree "pause" is set in fixes-link node and the MAC advertise that is supports pause.
Results with this patch.
Legend:
- DT = 'Pause' is set in the fixed-link in devicetree.
- validate() = ‘Yes’ means phylink_set(mask, Pause) is set in the validate().
- flow = results reported my link is Up line.
+-----+------------+-------+ | DT | validate() | flow | +-----+------------+-------+ | Yes | Yes | rx/tx | | No | Yes | off | | Yes | No | off | +-----+------------+-------+
--- drivers/net/phy/phylink.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/phy/phylink.c +2 -0
@@ -216,6 +216,8 @@ static int phylink_parse_fixedlink(struct phylink *pl, pl->supported, true);linkmode_zero (pl->supported);phylink_set (pl->supported,MII ); +phylink_set (pl->supported, Pause); +phylink_set (pl->supported, Asym_Pause);if (s) {__set_bit (s->bit, pl->supported); }else {
Signature · 1 line
2.20.1
Quoted 25 lines · René van Dorst
In
phylink_parse_fixedlink()thepl->link_config.advertisingbits are AND withpl->supported,pl->supportedis zeroed and only the speed/duplex modes and MII bits are set.
Sopl->link_config.advertisingalways loses the flow control/pause bits.By setting Pause and
Asym_Pausebits inpl->supported, the flow control work again when devicetree "pause" is set in fixes-link node and the MAC advertise that is supports pause.Results with this patch.
Legend:
- DT = 'Pause' is set in the fixed-link in devicetree.
-validate()= ‘Yes’ meansphylink_set(mask, Pause)is set in thevalidate().
- flow = results reported my link is Up line.+-----+------------+-------+ | DT | validate() | flow | +-----+------------+-------+ | Yes | Yes | rx/tx | | No | Yes | off | | Yes | No | off | +-----+------------+-------+
Quoted 2 lines
Fixes 9525ae83959b ("phylink: add phylink infrastructure")Signed-off-by René van Dorst <[email protected]>
Thanks.
Quoted 21 lines
--- drivers/net/phy/phylink.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/phy/phylink.c +2
-0@@ -216,6 +216,8 @@ static int phylink_parse_fixedlink(struct phylink *pl, pl->supported, true);linkmode_zero (pl->supported);phylink_set (pl->supported,MII ); +phylink_set (pl->supported, Pause); +phylink_set (pl->supported, Asym_Pause);if (s) {__set_bit (s->bit, pl->supported); }else {Signature · 1 line
2.20.1
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
David Miller
maintainerFrom: René van Dorst <[email protected]>
Date: Sat, 27 Jul 2019 11:40:11 +0200
Quoted 25 lines
In
phylink_parse_fixedlink()thepl->link_config.advertisingbits are AND withpl->supported,pl->supportedis zeroed and only the speed/duplex modes and MII bits are set.
Sopl->link_config.advertisingalways loses the flow control/pause bits.By setting Pause and
Asym_Pausebits inpl->supported, the flow control work again when devicetree "pause" is set in fixes-link node and the MAC advertise that is supports pause.Results with this patch.
Legend:
- DT = 'Pause' is set in the fixed-link in devicetree.
-validate()= ‘Yes’ meansphylink_set(mask, Pause)is set in thevalidate().
- flow = results reported my link is Up line.+-----+------------+-------+ | DT | validate() | flow | +-----+------------+-------+ | Yes | Yes | rx/tx | | No | Yes | off | | Yes | No | off | +-----+------------+-------+
Quoted 2 lines
Fixes 9525ae83959b ("phylink: add phylink infrastructure")Signed-off-by René van Dorst <[email protected]>
Applied and queued up for -stable, thanks.