Skip to contentSkip to conversation

gnome-system-monitor: Add DEPENDS on polkit

PATCH Superseded Adrian Bunk 3 participants 5 messages Jul 28, 2019 – Jul 30, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gnome-system-monitor: Add DEPENDS on polkit

The build fails without polkit in DISTRO_FEATURES:
FAILED: org.gnome.gnome-system-monitor.policy
msgfmt: cannot locate ITS rules for org.gnome.gnome-system-monitor.policy.in

---
 .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb          | 1 +
 1 file changed, 1 insertion(+)
meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb +1 -0
index 701b0891c..8d39101e9 100644
@@ -10,6 +10,7 @@ DEPENDS = " \
     gtkmm3 \
     libgtop \
     librsvg \
+    polkit \
 "
 
 GNOMEBASEBUILDCLASS = "meson"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 14 lines · Adrian Bunk

The build fails without polkit in DISTRO_FEATURES:
FAILED: org.gnome.gnome-system-monitor.policy
msgfmt: cannot locate ITS rules for org.gnome.gnome-system-monitor.policy.in

---
  .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb          | 1 +
  1 file changed, 1 insertion(+)
meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb +0 -0
index 701b0891c..8d39101e9 100644

meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb DEPENDS = " \ · line 14

Quoted 5 lines
meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb +1 -0
@@ -10,6 +10,7 @@ DEPENDS = " \
      gtkmm3 \
      libgtop \
      librsvg \
+    polkit \
  "

this should be probably guarded with polkit as DISTRO_FEATURE knob as well.

Quoted 2 lines
meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb +0 -0
  GNOMEBASEBUILDCLASS = "meson"
#2 lore raw
Quoted 11 lines · Khem Raj
Quoted 9 lines · Adrian Bunk

The build fails without polkit in DISTRO_FEATURES:
FAILED: org.gnome.gnome-system-monitor.policy
msgfmt: cannot locate ITS rules for org.gnome.gnome-system-monitor.policy.in

---
  .../gnome-system-monitor/gnome-system-monitor_3.32.0.bb          | 1 +
  1 file changed, 1 insertion(+)
Quoted 11 lines

meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb DEPENDS = " \ · line 14

Quoted 10 lines
meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb +1 -0
index 701b0891c..8d39101e9 100644
@@ -10,6 +10,7 @@ DEPENDS = " \
      gtkmm3 \
      libgtop \
      librsvg \
+    polkit \
  "

this should be probably guarded with polkit as DISTRO_FEATURE knob as well.

The error message already tells that automatically:

ERROR: Nothing PROVIDES 'polkit' (but /home/bunk/sources/meta-openembedded/meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb DEPENDS on or otherwise requires it) polkit was skipped: missing required distro feature 'polkit' (not in DISTRO_FEATURES)
ERROR: Required build target 'gnome-system-monitor' has no buildable providers.
Missing or unbuildable dependency chain was: ['gnome-system-monitor', 'polkit']

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw

It does tell that there are errors, but we don't want errors in "bitbake world" :).

inherit distro_features_check
REQUIRED_DISTRO_FEATURES = "polkit"

tells the same for gnome-system-monitor directly without showing any errors (because it's automatically skipped when polkit isn't in DISTRO_FEATURES).

Quoted 61 lines · Adrian Bunk
Quoted 5 lines · Khem Raj
Quoted 3 lines · Adrian Bunk

The build fails without polkit in DISTRO_FEATURES:
FAILED: org.gnome.gnome-system-monitor.policy
msgfmt: cannot locate ITS rules for

org.gnome.gnome-system-monitor.policy.in

Quoted 4 lines
Quoted 4 lines

---
.../gnome-system-monitor/gnome-system-monitor_3.32.0.bb |

1 +

Quoted 3 lines

Review

Quoted 3 lines
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

gnome-system-monitor_3.32.0.bb
b/meta-gnome/recipes-gnome/gnome-system-monitor/
gnome-system-monitor_3.32.0.bb

Quoted 2 lines
Quoted 2 lines

index 701b0891c..8d39101e9 100644
--- a/meta-gnome/recipes-gnome/gnome-system-monitor/

gnome-system-monitor_3.32.0.bb

Quoted 1 line
Quoted 1 line

+++ b/meta-gnome/recipes-gnome/gnome-system-monitor/

gnome-system-monitor_3.32.0.bb

Quoted 7 lines

meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb DEPENDS = " \ · line 14

Quoted 6 lines
meta-gnome/recipes-gnome/gnome-system-monitor/gnome-system-monitor_3.32.0.bb +1 -0
@@ -10,6 +10,7 @@ DEPENDS = " \
      gtkmm3 \
      libgtop \
      librsvg \
+    polkit \
  "

this should be probably guarded with polkit as DISTRO_FEATURE knob as

well.

The error message already tells that automatically:

ERROR: Nothing PROVIDES 'polkit' (but /home/bunk/sources/meta-openembedded/meta-gnome/recipes-gnome/gnome-system-monitor/ gnome-system-monitor_3.32.0.bb DEPENDS on or otherwise requires it) polkit was skipped: missing required distro feature 'polkit' (not in DISTRO_FEATURES)
ERROR: Required build target 'gnome-system-monitor' has no buildable providers.
Missing or unbuildable dependency chain was: ['gnome-system-monitor', 'polkit']

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
Quoted 3 lines · Martin Jansa

It does tell that there are errors, but we don't want errors in "bitbake world" :).
...

Thanks, now I get it.

v2 sent.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed