Skip to contentSkip to conversation

Amazon Annapurna Labs Alpine v3 device-tree

PATCH In review Ronen Krupnik 3 participants 6 messages Jul 28, 2019 – Aug 16, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover Amazon Annapurna Labs Alpine v3 device-tree

This series introduces the device tree for Amazon Annapurna Labs Alpine v3 SoC and Evaluation Board.

Ronen Krupnik (2):
dt-bindings: amazon: add Amazon Annapurna Labs Alpine support
arm64: dts: amazon: add Amazon Annapurna Labs Alpine v3 support

 .../devicetree/bindings/arm/amazon,alpine.txt |  23 ++
 arch/arm64/boot/dts/Makefile                  |   1 +
 arch/arm64/boot/dts/amazon/Makefile           |   1 +
 arch/arm64/boot/dts/amazon/alpine-v3-evp.dts  |  23 ++
 arch/arm64/boot/dts/amazon/alpine-v3.dtsi     | 371 ++++++++++++++++++
 5 files changed, 419 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/amazon,alpine.txt
 create mode 100644 arch/arm64/boot/dts/amazon/Makefile
 create mode 100644 arch/arm64/boot/dts/amazon/alpine-v3-evp.dts
 create mode 100644 arch/arm64/boot/dts/amazon/alpine-v3.dtsi
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/2 dt-bindings: amazon: add Amazon Annapurna Labs Alpine support

This patch adds DT bindings info for Amazon Annapurna Labs Alpine SOC and related reference boards.

---
 .../devicetree/bindings/arm/amazon,alpine.txt | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/amazon,alpine.txt
Documentation/devicetree/bindings/arm/amazon,alpine.txt new file +23 -0
new file mode 100644
index 000000000000..58817208421b
@@ -0,0 +1,23 @@
+Amazon Annapurna Labs Alpine v3 Platform Device Tree Bindings
+---------------------------------------------------------------
+
+Platforms based on Amazon Annapurna Labs Alpine SoC architecture
+shall follow the following scheme:
+
+SoCs
+----
+
+Each device tree root node must specify which exact SoC in alpine
+architecture it uses, using one of the following compatible values:
+
+- alpine v3
+  compatible = "amazon,alpine-v3";
+
+Boards
+------
+
+Each device tree must specify which one or more of the following
+board-specific compatible values:
+
+- alpine-v3 Evaluation Platform (EVP)
+  compatible = "amazon,alpine-v3-evp";
Signature · 1 line
2.21.0
maintainer
#2 lore raw

Re: [PATCH 1/2] dt-bindings: amazon: add Amazon Annapurna Labs Alpine support

Quoted 8 lines · Ronen Krupnik

This patch adds DT bindings info for Amazon Annapurna Labs Alpine SOC and related reference boards.

---
 .../devicetree/bindings/arm/amazon,alpine.txt | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/amazon,alpine.txt

Board bindings are in DT schema format now.

Also, we already have al,alpine.yaml. Please combine with that one or remove it perhaps. Seems kind of abandoned given the lack of response on it.

Quoted 33 lines
Documentation/devicetree/bindings/arm/amazon,alpine.txt new file +23 -0
new file mode 100644
index 000000000000..58817208421b
@@ -0,0 +1,23 @@
+Amazon Annapurna Labs Alpine v3 Platform Device Tree Bindings
+---------------------------------------------------------------
+
+Platforms based on Amazon Annapurna Labs Alpine SoC architecture
+shall follow the following scheme:
+
+SoCs
+----
+
+Each device tree root node must specify which exact SoC in alpine
+architecture it uses, using one of the following compatible values:
+
+- alpine v3
+  compatible = "amazon,alpine-v3";
+
+Boards
+------
+
+Each device tree must specify which one or more of the following
+board-specific compatible values:
+
+- alpine-v3 Evaluation Platform (EVP)
+  compatible = "amazon,alpine-v3-evp";
Signature · 1 line
2.21.0
#3 lore raw

PATCH 2/2 arm64: dts: amazon: add Amazon Annapurna Labs Alpine v3 support

In reply to Ronen Krupnik

This patch adds the initial support for the Amazon Annapurna Labs Alpine v3 Soc and Evaluation Platform (EVP).

---
 arch/arm64/boot/dts/Makefile                 |   1 +
 arch/arm64/boot/dts/amazon/Makefile          |   1 +
 arch/arm64/boot/dts/amazon/alpine-v3-evp.dts |  23 ++
 arch/arm64/boot/dts/amazon/alpine-v3.dtsi    | 371 +++++++++++++++++++
 4 files changed, 396 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amazon/Makefile
 create mode 100644 arch/arm64/boot/dts/amazon/alpine-v3-evp.dts
 create mode 100644 arch/arm64/boot/dts/amazon/alpine-v3.dtsi
arch/arm64/boot/dts/Makefile +1 -0
index 4690364d584b..25b750f147d2 100644
@@ -3,6 +3,7 @@ subdir-y += actions
 subdir-y += al
 subdir-y += allwinner
 subdir-y += altera
+subdir-y += amazon
 subdir-y += amd
 subdir-y += amlogic
 subdir-y += apm
arch/arm64/boot/dts/amazon/Makefile new file +1 -0
new file mode 100644
index 000000000000..d71ac87172eb
@@ -0,0 +1 @@
+dtb-$(CONFIG_ARCH_ALPINE)	+= alpine-v3-evp.dtb
arch/arm64/boot/dts/amazon/alpine-v3-evp.dts new file +23 -0
new file mode 100644
index 000000000000..542e3d419904
@@ -0,0 +1,23 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ */
+
+#include "alpine-v3.dtsi"
+
+/ {
+	model = "Amazon Alpine v3 Evaluation Platform (EVP)";
+	compatible = "amazon,alpine-v3-evp", "amazon,alpine-v3";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&uart0 {
+	status = "okay";
+};
arch/arm64/boot/dts/amazon/alpine-v3.dtsi new file +371 -0

371 lines not on this page · raw message

Signature · 1 line
2.21.0
#4 lore raw

Re: [PATCH 2/2] arm64: dts: amazon: add Amazon Annapurna Labs Alpine v3 support

Quoted 2 lines · Ronen Krupnik

This patch adds the initial support for the Amazon Annapurna Labs Alpine v3 Soc and Evaluation Platform (EVP).

[...]

arch/arm64/boot/dts/amazon/alpine-v3.dtsi line 336

Quoted 3 lines
arch/arm64/boot/dts/amazon/alpine-v3.dtsi new file +3 -0
+
+		pmu {
+			compatible = "arm,armv8-pmuv3";

Please use "arm,cortex-a72-pmu" as we know it's Cortex-A72 cores

--
Regards,
Sudeep

author
#5 lore raw

Re: [PATCH 2/2] arm64: dts: amazon: add Amazon Annapurna Labs Alpine v3 support

Quoted 9 lines · Sudeep Holla
Quoted 2 lines · Ronen Krupnik

This patch adds the initial support for the Amazon Annapurna Labs Alpine v3 Soc and Evaluation Platform (EVP).

[...]

arch/arm64/boot/dts/amazon/alpine-v3.dtsi line 336

Quoted 3 lines
arch/arm64/boot/dts/amazon/alpine-v3.dtsi new file +3 -0
+
+		pmu {
+			compatible = "arm,armv8-pmuv3";

Please use "arm,cortex-a72-pmu" as we know it's Cortex-A72 cores

ack. will be part of v2

Quoted 4 lines

--
Regards,
Sudeep