Correct the return value of cryptoapi RSA signature callbacks
PATCH 1/1 Correct the return value of cryptoapi RSA signature callbacks
From: Selva Nair <[email protected]...>
Fixes the wrong check on siglen instead of *siglen for signing failures.
Bug reported by: lilulo <[email protected]...>
Signed-off-by Selva Nair <[email protected]...>
--- src/openvpn/cryptoapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/cryptoapi.c +1 -1
@@ -393,7 +393,7 @@ rsa_sign_CNG(int type, const unsigned char *m, unsigned int m_len, } *siglen =priv_enc_CNG (cd, alg, m, (int )m_len, sig,RSA_size (rsa), padding); -return (siglen ==0 ) ?0 :1 ; +return (*siglen ==0 ) ?0 :1 ; }/* decrypt */
Signature · 1 line
2.20.1
Quoted 18 lines · On 27-07-19 05:12, [email protected]... wrote:
From: Selva Nair <[email protected]...>
Fixes the wrong check on siglen instead of *siglen for signing failures.
Bug reported by: lilulo <[email protected]...>
Signed-off-by Selva Nair <[email protected]...>--- src/openvpn/cryptoapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)src/openvpn/cryptoapi.c +0
-0
src/openvpn/cryptoapi.c rsa_sign_CNG(int type, const unsigned char *m, unsigned int m_len, · line 399
Quoted 8 lines
src/openvpn/cryptoapi.c +1
-1@@ -393,7 +393,7 @@ rsa_sign_CNG(int type, const unsigned char *m, unsigned int m_len, } *siglen =priv_enc_CNG (cd, alg, m, (int )m_len, sig,RSA_size (rsa), padding); -return (siglen ==0 ) ?0 :1 ; +return (*siglen ==0 ) ?0 :1 ; }/* decrypt */
And thanks again :-) - even less tested, just checking that this is indeed the only occurance of siglen/*siglen in 2.4
Your patch has been applied to the release/2.4 branch.
commit eed67cf0e7f6cbe596495c2f83aeea7c15db0d6e
Author: Selva Nair Date: Fri Jul 26 23:12:21 2019 -0400
Correct the return value of cryptoapi RSA signature callbacks
Signed-off-by: Selva Nair <[email protected]...>
Acked-by: Steffan Karger <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg18708.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering