Skip to contentSkip to conversation

arm64: mark expected switch fall-through

PATCH In review Matteo Croce 2 participants 2 messages Jul 28, 2019 – Jul 29, 2019 arm64

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: mark expected switch fall-through

Move the "fallthrough" comment just because the case keyword, fixes the following warning:

In file included from ./include/linux/kernel.h:15,

                 from ./include/linux/list.h:9,
                 from ./include/linux/kobject.h:19,
                 from ./include/linux/of.h:17,
                 from ./include/linux/irqdomain.h:35,
                 from ./include/linux/acpi.h:13,
                 from arch/arm64/kernel/smp.c:9:

arch/arm64/kernel/smp.c: In function ‘__cpu_up’:
./include/linux/printk.h:302:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’

    pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
    ^~~~~~~

arch/arm64/kernel/smp.c:157:3: note: here
case CPU_STUCK_IN_KERNEL:
^~~~

---
 arch/arm64/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/smp.c +1 -1
index ea90d3bd9253..018a33e01b0e 100644
@@ -152,8 +152,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
 				pr_crit("CPU%u: died during early boot\n", cpu);
 				break;
 			}
-			/* Fall through */
 			pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
+			/* Fall through */
 		case CPU_STUCK_IN_KERNEL:
 			pr_crit("CPU%u: is stuck in kernel\n", cpu);
 			if (status & CPU_STUCK_REASON_52_BIT_VA)
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 21 lines · Matteo Croce

Move the "fallthrough" comment just because the case keyword, fixes the following warning:

In file included from ./include/linux/kernel.h:15,

                 from ./include/linux/list.h:9,
                 from ./include/linux/kobject.h:19,
                 from ./include/linux/of.h:17,
                 from ./include/linux/irqdomain.h:35,
                 from ./include/linux/acpi.h:13,
                 from arch/arm64/kernel/smp.c:9:

arch/arm64/kernel/smp.c: In function ‘__cpu_up’:
./include/linux/printk.h:302:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’

    pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
    ^~~~~~~
arch/arm64/kernel/smp.c:157:3: note: here
   case CPU_STUCK_IN_KERNEL:
   ^~~~
Quoted 4 lines
---
 arch/arm64/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Already fixed via [1]. Please can you people work together?

Will

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-July/668934.html