Skip to contentSkip to conversation

KVM: arm64: mark expected switch fall-through in HYP

PATCH In review Matteo Croce 2 participants 2 messages Jul 28, 2019 – Jul 29, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: arm64: mark expected switch fall-through in HYP

Mark switch cases where we are expecting to fall through, fixes a 130+ lines warning.

---
 arch/arm64/kvm/hyp/debug-sr.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm64/kvm/hyp/debug-sr.c +30 -0
index 26781da3ad3e..c648c243f98b 100644
@@ -18,40 +18,70 @@
 #define save_debug(ptr,reg,nr)						\
 	switch (nr) {							\
 	case 15:	ptr[15] = read_debug(reg, 15);			\
+			/* fallthrough */				\
 	case 14:	ptr[14] = read_debug(reg, 14);			\
+			/* fallthrough */				\
 	case 13:	ptr[13] = read_debug(reg, 13);			\
+			/* fallthrough */				\
 	case 12:	ptr[12] = read_debug(reg, 12);			\
+			/* fallthrough */				\
 	case 11:	ptr[11] = read_debug(reg, 11);			\
+			/* fallthrough */				\
 	case 10:	ptr[10] = read_debug(reg, 10);			\
+			/* fallthrough */				\
 	case 9:		ptr[9] = read_debug(reg, 9);			\
+			/* fallthrough */				\
 	case 8:		ptr[8] = read_debug(reg, 8);			\
+			/* fallthrough */				\
 	case 7:		ptr[7] = read_debug(reg, 7);			\
+			/* fallthrough */				\
 	case 6:		ptr[6] = read_debug(reg, 6);			\
+			/* fallthrough */				\
 	case 5:		ptr[5] = read_debug(reg, 5);			\
+			/* fallthrough */				\
 	case 4:		ptr[4] = read_debug(reg, 4);			\
+			/* fallthrough */				\
 	case 3:		ptr[3] = read_debug(reg, 3);			\
+			/* fallthrough */				\
 	case 2:		ptr[2] = read_debug(reg, 2);			\
+			/* fallthrough */				\
 	case 1:		ptr[1] = read_debug(reg, 1);			\
+			/* fallthrough */				\
 	default:	ptr[0] = read_debug(reg, 0);			\
 	}
 
 #define restore_debug(ptr,reg,nr)					\
 	switch (nr) {							\
 	case 15:	write_debug(ptr[15], reg, 15);			\
+			/* fallthrough */				\
 	case 14:	write_debug(ptr[14], reg, 14);			\
+			/* fallthrough */				\
 	case 13:	write_debug(ptr[13], reg, 13);			\
+			/* fallthrough */				\
 	case 12:	write_debug(ptr[12], reg, 12);			\
+			/* fallthrough */				\
 	case 11:	write_debug(ptr[11], reg, 11);			\
+			/* fallthrough */				\
 	case 10:	write_debug(ptr[10], reg, 10);			\
+			/* fallthrough */				\
 	case 9:		write_debug(ptr[9], reg, 9);			\
+			/* fallthrough */				\
 	case 8:		write_debug(ptr[8], reg, 8);			\
+			/* fallthrough */				\
 	case 7:		write_debug(ptr[7], reg, 7);			\
+			/* fallthrough */				\
 	case 6:		write_debug(ptr[6], reg, 6);			\
+			/* fallthrough */				\
 	case 5:		write_debug(ptr[5], reg, 5);			\
+			/* fallthrough */				\
 	case 4:		write_debug(ptr[4], reg, 4);			\
+			/* fallthrough */				\
 	case 3:		write_debug(ptr[3], reg, 3);			\
+			/* fallthrough */				\
 	case 2:		write_debug(ptr[2], reg, 2);			\
+			/* fallthrough */				\
 	case 1:		write_debug(ptr[1], reg, 1);			\
+			/* fallthrough */				\
 	default:	write_debug(ptr[0], reg, 0);			\
 	}
 
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 74 lines · Matteo Croce

Mark switch cases where we are expecting to fall through, fixes a 130+ lines warning.

---
 arch/arm64/kvm/hyp/debug-sr.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm64/kvm/hyp/debug-sr.c +26 -0
index 26781da3ad3e..c648c243f98b 100644
@@ -18,40 +18,70 @@
 #define save_debug(ptr,reg,nr)						\
 	switch (nr) {							\
 	case 15:	ptr[15] = read_debug(reg, 15);			\
+			/* fallthrough */				\
 	case 14:	ptr[14] = read_debug(reg, 14);			\
+			/* fallthrough */				\
 	case 13:	ptr[13] = read_debug(reg, 13);			\
+			/* fallthrough */				\
 	case 12:	ptr[12] = read_debug(reg, 12);			\
+			/* fallthrough */				\
 	case 11:	ptr[11] = read_debug(reg, 11);			\
+			/* fallthrough */				\
 	case 10:	ptr[10] = read_debug(reg, 10);			\
+			/* fallthrough */				\
 	case 9:		ptr[9] = read_debug(reg, 9);			\
+			/* fallthrough */				\
 	case 8:		ptr[8] = read_debug(reg, 8);			\
+			/* fallthrough */				\
 	case 7:		ptr[7] = read_debug(reg, 7);			\
+			/* fallthrough */				\
 	case 6:		ptr[6] = read_debug(reg, 6);			\
+			/* fallthrough */				\
 	case 5:		ptr[5] = read_debug(reg, 5);			\
+			/* fallthrough */				\
 	case 4:		ptr[4] = read_debug(reg, 4);			\
+			/* fallthrough */				\
 	case 3:		ptr[3] = read_debug(reg, 3);			\
+			/* fallthrough */				\
 	case 2:		ptr[2] = read_debug(reg, 2);			\
+			/* fallthrough */				\
 	case 1:		ptr[1] = read_debug(reg, 1);			\
+			/* fallthrough */				\
 	default:	ptr[0] = read_debug(reg, 0);			\
 	}
 
 #define restore_debug(ptr,reg,nr)					\
 	switch (nr) {							\
 	case 15:	write_debug(ptr[15], reg, 15);			\
+			/* fallthrough */				\
 	case 14:	write_debug(ptr[14], reg, 14);			\
+			/* fallthrough */				\
 	case 13:	write_debug(ptr[13], reg, 13);			\
+			/* fallthrough */				\
 	case 12:	write_debug(ptr[12], reg, 12);			\
+			/* fallthrough */				\
 	case 11:	write_debug(ptr[11], reg, 11);			\
+			/* fallthrough */				\
 	case 10:	write_debug(ptr[10], reg, 10);			\
+			/* fallthrough */				\
 	case 9:		write_debug(ptr[9], reg, 9);			\
+			/* fallthrough */				\
 	case 8:		write_debug(ptr[8], reg, 8);			\
+			/* fallthrough */				\
 	case 7:		write_debug(ptr[7], reg, 7);			\
+			/* fallthrough */				\
 	case 6:		write_debug(ptr[6], reg, 6);			\
+			/* fallthrough */				\
 	case 5:		write_debug(ptr[5], reg, 5);			\
+			/* fallthrough */				\
 	case 4:		write_debug(ptr[4], reg, 4);			\

arch/arm64/kvm/hyp/debug-sr.c line 87

Quoted 10 lines
arch/arm64/kvm/hyp/debug-sr.c +4 -0
+			/* fallthrough */				\
 	case 3:		write_debug(ptr[3], reg, 3);			\
+			/* fallthrough */				\
 	case 2:		write_debug(ptr[2], reg, 2);			\
+			/* fallthrough */				\
 	case 1:		write_debug(ptr[1], reg, 1);			\
+			/* fallthrough */				\
 	default:	write_debug(ptr[0], reg, 0);			\
 	}
 

Already reported here[1].

Thanks,

	M.

[1] https://www.spinics.net/lists/arm-kernel/msg743592.html

Signature · 1 line
Jazz is not dead, it just smells funny...