Skip to contentSkip to conversation

linux-next: build warning after merge of the akpm-current tree

PATCH New Stephen Rothwell 2 participants 2 messages Jul 29, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the akpm-current tree, today's linux-next build (x86_64 allmodconfig) produced this warning:

drivers/infiniband/sw/siw/siw_mem.c: In function 'siw_free_plist':
drivers/infiniband/sw/siw/siw_mem.c:66:16: warning: unused variable 'p' [-Wunused-variable]

  struct page **p = chunk->plist;
                ^

Introduced by commit

63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

PATCH 1/1 mm/gup: remove unused variable in siw_free_plist()

From: John Hubbard <[email protected]>

Commit 63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()") removed the only user of the local variable p. Finish the job by removing p as well.

Fixes 63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()")

---

Hi,

This fixes the warning. Ideally this should be merged with the commit that it fixes, if that's still possible.

Andrew, would you also like a fixed version of this patch posted as a new version of the 3-patch set that it came with?

thanks,
John Hubbard
NVIDIA

 drivers/infiniband/sw/siw/siw_mem.c | 2 --
 1 file changed, 2 deletions(-)
drivers/infiniband/sw/siw/siw_mem.c +0 -2
index 358d440efa11..ab83a9cec562 100644
@@ -63,8 +63,6 @@ struct siw_mem *siw_mem_id2obj(struct siw_device *sdev, int stag_index)
 static void siw_free_plist(struct siw_page_chunk *chunk, int num_pages,
 			   bool dirty)
 {
-	struct page **p = chunk->plist;
-
 	put_user_pages_dirty_lock(chunk->plist, num_pages, dirty);
 }
 
Signature · 1 line
2.22.0