Skip to contentSkip to conversation

init: Allow mounting virtio_fs instance as rootfs

RFC PATCH In review Vivek Goyal 2 participants 3 messages Jul 25, 2019 – Jul 29, 2019 VFS

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 init: Allow mounting virtio_fs instance as rootfs

Hi Stefan,

I think following patch might allow you to mount virtio_fs as rootfs with new syntax.

I have only compiled it and not tested it. Plase have a look.

Thanks
Vivek

virtio_fs passes root=<fs-instance-name> as identifier of virtio_fs instance to be mounted. None of the existing primitives seems to fit virito_fs needs.

So check rootfstype and if it is "virtio_fs", do not parse root= further and call mount_block_root().

This is similar to carving out special paths for ubifs. Now virtio_fs users should be able to pass "root=myfs rootfstype=virtio_fs" and be able to mount that particular instance of virtio_fs as rootfs.

Yet-To-Be-Signed-off-by Vivek Goyal <[email protected]>
---
 init/do_mounts.c |    4 ++++
 1 file changed, 4 insertions(+)
init/do_mounts.c +4 -0
Index: rhvgoyal-linux-fuse/init/do_mounts.c
===================================================================
@@ -595,6 +595,10 @@ void __init prepare_namespace(void)
 			mount_block_root(root_device_name, root_mountflags);
 			goto out;
 		}
+		if (root_fs_names && !strncmp(root_fs_names, "virtio_fs", 3)) {
+			mount_block_root(root_device_name, root_mountflags);
+			goto out;
+		}
 		ROOT_DEV = name_to_dev_t(root_device_name);
 		if (strncmp(root_device_name, "/dev/", 5) == 0)
 			root_device_name += 5;
#1 lore raw
Quoted 4 lines · Vivek Goyal

Hi Stefan,

I think following patch might allow you to mount virtio_fs as rootfs with new syntax.

Thanks, I've sent a similar patch too. My patch changes mount_root() (where the nfs root code also lives) and uses do_mount_root() instead of mount_block_root() to avoid block/partition error messages. But I think they are very similar in terms of functionality.

Quoted 25 lines

I have only compiled it and not tested it. Plase have a look.

Thanks
Vivek

virtio_fs passes root=<fs-instance-name> as identifier of virtio_fs instance to be mounted. None of the existing primitives seems to fit virito_fs needs.

So check rootfstype and if it is "virtio_fs", do not parse root= further and call mount_block_root().

This is similar to carving out special paths for ubifs. Now virtio_fs users should be able to pass "root=myfs rootfstype=virtio_fs" and be able to mount that particular instance of virtio_fs as rootfs.

Yet-To-Be-Signed-off-by Vivek Goyal <[email protected]>
---
 init/do_mounts.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: rhvgoyal-linux-fuse/init/do_mounts.c
===================================================================

init/do_mounts.c void __init prepare_namespace(void) · line 598

Quoted 4 lines
init/do_mounts.c +1 -0
@@ -595,6 +595,10 @@ void __init prepare_namespace(void)
 			mount_block_root(root_device_name, root_mountflags);
 			goto out;
 		}
+		if (root_fs_names && !strncmp(root_fs_names, "virtio_fs", 3)) {

The entire string, not just the first 3 characters:

!strcmp(root_fs_names, "virtio_fs")

#2 lore raw
Quoted 10 lines · Stefan Hajnoczi
Quoted 4 lines · Vivek Goyal

Hi Stefan,

I think following patch might allow you to mount virtio_fs as rootfs with new syntax.

Thanks, I've sent a similar patch too. My patch changes mount_root() (where the nfs root code also lives) and uses do_mount_root() instead of mount_block_root() to avoid block/partition error messages. But I think they are very similar in terms of functionality.

Ok, sounds good. I will squash that patch with one of the existing patches.

Thanks
Vivek

Quoted 34 lines
Quoted 26 lines

I have only compiled it and not tested it. Plase have a look.

Thanks
Vivek

virtio_fs passes root=<fs-instance-name> as identifier of virtio_fs instance to be mounted. None of the existing primitives seems to fit virito_fs needs.

So check rootfstype and if it is "virtio_fs", do not parse root= further and call mount_block_root().

This is similar to carving out special paths for ubifs. Now virtio_fs users should be able to pass "root=myfs rootfstype=virtio_fs" and be able to mount that particular instance of virtio_fs as rootfs.

Yet-To-Be-Signed-off-by Vivek Goyal <[email protected]>
---
 init/do_mounts.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: rhvgoyal-linux-fuse/init/do_mounts.c
===================================================================

init/do_mounts.c void __init prepare_namespace(void) · line 598

Quoted 4 lines
init/do_mounts.c +1 -0
@@ -595,6 +595,10 @@ void __init prepare_namespace(void)
 			mount_block_root(root_device_name, root_mountflags);
 			goto out;
 		}
+		if (root_fs_names && !strncmp(root_fs_names, "virtio_fs", 3)) {

The entire string, not just the first 3 characters:

!strcmp(root_fs_names, "virtio_fs")