Skip to contentSkip to conversation

syscalls/ioctl08: Require btrfs

PATCH New Petr Vorel 2 participants 4 messages Jul 3, 2019 – Jul 31, 2019

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 syscalls/ioctl08: Require btrfs

Test requires btrfs otherwise it fails:
WARNING: failed to open /dev/btrfs-control, skipping device
registration: No such file or directory
safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point, btrfs, 0, (nil)) failed: ENODEV

---
Hi Amir,

thanks a lot for a report and sorry for longer time to reply (vacation). Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).

Kind regards,
Petr

 testcases/kernel/syscalls/ioctl/ioctl08.c | 6 ++++++
 1 file changed, 6 insertions(+)
testcases/kernel/syscalls/ioctl/ioctl08.c +6 -0
index 8de80048c..dca898a65 100644
@@ -112,6 +112,11 @@ static void setup(void)
 			sizeof(struct file_dedupe_range_info));
 }
 
+static const char *const needed_drivers[] = {
+	"btrfs",
+	NULL,
+};
+
 static struct tst_test test = {
 	.test = verify_ioctl,
 	.tcnt = ARRAY_SIZE(tcases),
@@ -122,6 +127,7 @@ static struct tst_test test = {
 	.mount_device = 1,
 	.mntpoint = MNTPOINT,
 	.dev_fs_type = "btrfs",
+	.needs_drivers = needed_drivers,
 };
 #else
 	TST_TEST_TCONF(
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 syscalls/ioctl08: Require btrfs

Hi!

Quoted 5 lines

WARNING: failed to open /dev/btrfs-control, skipping device
registration: No such file or directory
safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point, btrfs, 0, (nil)) failed: ENODEV

Quoted 8 lines

---
Hi Amir,

thanks a lot for a report and sorry for longer time to reply (vacation). Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).

Looks good to me.

Amir have you had a chance to test this patch?

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH 1/1 syscalls/ioctl08: Require btrfs

In reply to Petr Vorel

Hi Amir,

Quoted 5 lines

Test requires btrfs otherwise it fails:
WARNING: failed to open /dev/btrfs-control, skipping device
registration: No such file or directory
safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point, btrfs, 0, (nil)) failed: ENODEV

could you please test it?

Kind regards,
Petr
https://patchwork.ozlabs.org/patch/1126923/

Quoted 39 lines

---
Hi Amir,

thanks a lot for a report and sorry for longer time to reply (vacation). Could you please test it? (I don't have any VM with kernel >= 4.5 && !btrfs).

Kind regards,
Petr

 testcases/kernel/syscalls/ioctl/ioctl08.c | 6 ++++++
 1 file changed, 6 insertions(+)
testcases/kernel/syscalls/ioctl/ioctl08.c +6 -0
index 8de80048c..dca898a65 100644
@@ -112,6 +112,11 @@ static void setup(void)
 			sizeof(struct file_dedupe_range_info));
 }
 
+static const char *const needed_drivers[] = {
+	"btrfs",
+	NULL,
+};
+
 static struct tst_test test = {
 	.test = verify_ioctl,
 	.tcnt = ARRAY_SIZE(tcases),
@@ -122,6 +127,7 @@ static struct tst_test test = {
 	.mount_device = 1,
 	.mntpoint = MNTPOINT,
 	.dev_fs_type = "btrfs",
+	.needs_drivers = needed_drivers,
 };
 #else
 	TST_TEST_TCONF(
author
#3 lore raw

PATCH 1/1 syscalls/ioctl08: Require btrfs

Hi Amir,

Quoted 6 lines
Quoted 5 lines

Test requires btrfs otherwise it fails:
WARNING: failed to open /dev/btrfs-control, skipping device
registration: No such file or directory
safe_macros.c:757: BROK: tst_test.c:752: mount(/dev/loop0, mnt_point, btrfs, 0, (nil)) failed: ENODEV

could you please test it?

I tested it on kernel without btrfs and it works as expected, thus pushed. Thanks again for your report.

Kind regards,
Petr