platform/chrome: cros_ec_trace: update generating script
Subsystems (2)
PATCH v3 1/1 platform/chrome: cros_ec_trace: update generating script
To remove ", \" from the last line.
Signed-off-by Tzung-Bi Shih <[email protected]>
---
Changes from v1:
- simpler awk code
Changes from v2:
- use c style comments instead of c++ style
- use '@' delimiter in sed instead of '/' to avoid unintentional end of comment "*/"
drivers/platform/chrome/cros_ec_trace.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)
drivers/platform/chrome/cros_ec_trace.c +15 -2
@@ -5,8 +5,21 @@#define TRACE_SYMBOL (a) {a, #a} -// Generate the list using the following script: -// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' include/linux/mfd/cros_ec_commands.h +/* +* Generate the list using the following script: +* sed -n 's@^#define \(EC_CMD_[[:alnum:]_]*\)\s.*@\tTRACE_SYMBOL(\1), \\@p' \ +* include/linux/mfd/cros_ec_commands.h | awk ' +* { +* if (NR != 1) +* print buf; +* buf = $0; +* } +* END { +* gsub(/, \\/, "", buf); +* print buf; +* } +* ' +*/ #define EC_CMDS \ TRACE_SYMBOL(EC_CMD_PROTO_VERSION), \ TRACE_SYMBOL(EC_CMD_HELLO), \
Signature · 1 line
2.22.0.709.g102302147b-goog
Hi Tzung-Bi,
cc'ing Raul for if he has comments
Quoted 2 lines · Tzung-Bi Shih
To remove ", \" from the last line.
I'm overall fine with the patch itself but I'd prefer a better description here.
Thanks,
~ Enric
Quoted 41 lines
Signed-off-by Tzung-Bi Shih <[email protected]>---
Changes from v1:
- simpler awk code
Changes from v2:
- use c style comments instead of c++ style
- use '@' delimiter in sed instead of '/' to avoid unintentional end of comment "*/"drivers/platform/chrome/cros_ec_trace.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-)drivers/platform/chrome/cros_ec_trace.c +15
-2@@ -5,8 +5,21 @@#define TRACE_SYMBOL (a) {a, #a} -// Generate the list using the following script: -// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' include/linux/mfd/cros_ec_commands.h +/* +* Generate the list using the following script: +* sed -n 's@^#define \(EC_CMD_[[:alnum:]_]*\)\s.*@\tTRACE_SYMBOL(\1), \\@p' \ +* include/linux/mfd/cros_ec_commands.h | awk ' +* { +* if (NR != 1) +* print buf; +* buf = $0; +* } +* END { +* gsub(/, \\/, "", buf); +* print buf; +* } +* ' +*/ #define EC_CMDS \ TRACE_SYMBOL(EC_CMD_PROTO_VERSION), \ TRACE_SYMBOL(EC_CMD_HELLO), \