kdb: Replace strncmp with str_has_prefix
PATCH 2/12 kdb: Replace strncmp with str_has_prefix
strncmp(str, const, len) is error-prone.
We had better use newly introducedstr_has_prefix() instead of it.
Signed-off-by Chuhong Yuan <[email protected]>
--- kernel/debug/kdb/kdb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/debug/kdb/kdb_main.c +1 -1
@@ -830,7 +830,7 @@ static void parse_grep(const char *str) cp++;while (isspace (*cp)) cp++; -if (strncmp (cp,"grep " ,5 )) { +if (!str_has_prefix (cp,"grep " )) {kdb_printf ("invalid 'pipe', see grephelp\n" );return ; }
Signature · 1 line
2.20.1
Quoted 5 lines · Chuhong Yuan
strncmp(str, const, len)is error-prone.
We had better use newly introducedstr_has_prefix()instead of it.Signed-off-by Chuhong Yuan <[email protected]>
Acked-by Daniel Thompson <[email protected]>
Quoted 20 lines
--- kernel/debug/kdb/kdb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/debug/kdb/kdb_main.c +1
-1@@ -830,7 +830,7 @@ static void parse_grep(const char *str) cp++;while (isspace (*cp)) cp++; -if (strncmp (cp,"grep " ,5 )) { +if (!str_has_prefix (cp,"grep " )) {kdb_printf ("invalid 'pipe', see grephelp\n" );return ; }Signature · 1 line
2.20.1