Skip to contentSkip to conversation

sched: Replace strncmp with str_has_prefix

PATCH In review Chuhong Yuan 1 participant 1 message Jul 29, 2019 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 10/12 sched: Replace strncmp with str_has_prefix

strncmp(str, const, len) is error-prone.
We had better use newly introduced
str_has_prefix() instead of it.

---
 kernel/sched/debug.c     | 2 +-
 kernel/sched/isolation.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
kernel/sched/debug.c +1 -1
index f7e4579e746c..6a77bf51e4d3 100644
@@ -103,7 +103,7 @@ static int sched_feat_set(char *cmp)
 	int i;
 	int neg = 0;
 
-	if (strncmp(cmp, "NO_", 3) == 0) {
+	if (str_has_prefix(cmp, "NO_")) {
 		neg = 1;
 		cmp += 3;
 	}
kernel/sched/isolation.c +2 -2
index ccb28085b114..cd5dfa93095d 100644
@@ -143,13 +143,13 @@ static int __init housekeeping_isolcpus_setup(char *str)
 	unsigned int flags = 0;
 
 	while (isalpha(*str)) {
-		if (!strncmp(str, "nohz,", 5)) {
+		if (str_has_prefix(str, "nohz,")) {
 			str += 5;
 			flags |= HK_FLAG_TICK;
 			continue;
 		}
 
-		if (!strncmp(str, "domain,", 7)) {
+		if (str_has_prefix(str, "domain,")) {
 			str += 7;
 			flags |= HK_FLAG_DOMAIN;
 			continue;
Signature · 1 line
2.20.1