Skip to contentSkip to conversation

userns: Replace strncmp with str_has_prefix

PATCH In review Chuhong Yuan 1 participant 1 message Jul 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 11/12 userns: Replace strncmp with str_has_prefix

strncmp(str, const, len) is error-prone.
We had better use newly introduced
str_has_prefix() instead of it.

---
 kernel/user_namespace.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
kernel/user_namespace.c +2 -3
index 8eadadc478f9..4a06ba563531 100644
@@ -1153,11 +1153,10 @@ ssize_t proc_setgroups_write(struct file *file, const char __user *buf,
 
 	/* What is being requested? */
 	ret = -EINVAL;
-	if (strncmp(pos, "allow", 5) == 0) {
+	if (str_has_prefix(pos, "allow")) {
 		pos += 5;
 		setgroups_allowed = true;
-	}
-	else if (strncmp(pos, "deny", 4) == 0) {
+	} else if (str_has_prefix(pos, "deny")) {
 		pos += 4;
 		setgroups_allowed = false;
 	}
Signature · 1 line
2.20.1