Skip to contentSkip to conversation

edid: fix edid_get_timing_validate() mode_valid lookup

PATCH New Neil Armstrong 2 participants 2 messages Jul 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 edid: fix edid_get_timing_validate() mode_valid lookup

Add a condition to the break in the modes lookup, without this when the first mode is not valid, then edid_get_timing_validate() return an error instead of checking the next modes.

Fixes 1c1ed441b0d1 ("edid: add edid_get_timing_validate() variant to filter out edid modes")
---
 common/edid.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
common/edid.c +3 -1
index f244d26e04..f99f42dc40 100644
@@ -202,7 +202,9 @@ int edid_get_timing_validate(u8 *buf, int buf_size,
 							 timing);
 			else
 				timing_done = true;
-			break;
+
+			if (timing_done)
+				break;
 		}
 	}
 	if (!timing_done)
Signature · 1 line
2.22.0
#1 lore raw

PATCH 1/1 edid: fix edid_get_timing_validate() mode_valid lookup

On Mon, 29 Jul 2019 15:35:18 +0200
Neil Armstrong narmstrong at baylibre.com wrote:
...

Quoted 2 lines
 common/edid.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to u-boot-video/master, thanks!

--
Anatolij