net/bnxt: set Rx checksum flags in vector mode receive
PATCH 2/2 net/bnxt: set Rx checksum flags in vector mode receive
From: Kalesh AP <[email protected]>
Fixed to return the checksum status of rx packets by setting "ol_flags" correctly in vector mode receive.
These changes have been there for non vector mode receive. In vector mode receive also indicate inner and outer checksum errors individually in "ol_flag" to indicate L3 and L4 error.
--- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 47 ++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)
drivers/net/bnxt/bnxt_rxtx_vec_sse.c +47 -0
@@ -157,6 +157,52 @@ bnxt_parse_pkt_type(struct rx_pkt_cmpl *rxcmp, struct rx_pkt_cmpl_hi *rxcmp1)return pkt_type; } +static void +bnxt_parse_csum (struct rte_mbuf *mbuf,struct rx_pkt_cmpl_hi *rxcmp1) +{ +uint32_t flags; + + flags =flags2_0xf (rxcmp1); +/* IP Checksum */ +if (likely (IS_IP_NONTUNNEL_PKT (flags))) { +if (unlikely (RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; + }else if (IS_IP_TUNNEL_PKT (flags)) { +if (unlikely (RX_CMP_IP_OUTER_CS_ERROR (rxcmp1) || +RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; + }else if (unlikely (RX_CMP_IP_CS_UNKNOWN (rxcmp1))) { + mbuf->ol_flags |=PKT_RX_IP_CKSUM_UNKNOWN ; + } + +/* L4 Checksum */ +if (likely (IS_L4_NONTUNNEL_PKT (flags))) { +if (unlikely (RX_CMP_L4_INNER_CS_ERR2 (rxcmp1))) + mbuf->ol_flags |=PKT_RX_L4_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_L4_CKSUM_GOOD ; + }else if (IS_L4_TUNNEL_PKT (flags)) { +if (unlikely (RX_CMP_L4_INNER_CS_ERR2 (rxcmp1))) + mbuf->ol_flags |=PKT_RX_L4_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_L4_CKSUM_GOOD ; +if (unlikely (RX_CMP_L4_OUTER_CS_ERR2 (rxcmp1))) { + mbuf->ol_flags |=PKT_RX_OUTER_L4_CKSUM_BAD ; + }else if (unlikely (IS_L4_TUNNEL_PKT_ONLY_INNER_L4_CS + (flags))) { + mbuf->ol_flags |=PKT_RX_OUTER_L4_CKSUM_UNKNOWN ; + }else { + mbuf->ol_flags |=PKT_RX_OUTER_L4_CKSUM_GOOD ; + } + }else if (unlikely (RX_CMP_L4_CS_UNKNOWN (rxcmp1))) { + mbuf->ol_flags |=PKT_RX_L4_CKSUM_UNKNOWN ; + } +} +uint16_t bnxt_recv_pkts_vec (void *rx_queue,struct rte_mbuf **rx_pkts,uint16_t nb_pkts)
@@ -254,6 +300,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, mbuf->ol_flags |=PKT_RX_VLAN ; } +bnxt_parse_csum (mbuf, rxcmp1); mbuf->packet_type =bnxt_parse_pkt_type (rxcmp, rxcmp1); rx_pkts[nb_rx_pkts++] = mbuf;
Signature · 1 line
2.17.1
Quoted 9 lines · Lance Richardson
From: Kalesh AP <[email protected]>
Fixed to return the checksum status of rx packets by setting "
ol_flags" correctly in vector mode receive.These changes have been there for non vector mode receive. In vector mode receive also indicate inner and outer checksum errors individually in "
ol_flag" to indicate L3 and L4 error.
Quoted 5 lines
Fixes bc4a000f2f53 ("net/bnxt: implement SSE vector mode")Signed-off-by Kalesh AP <[email protected]>Reviewed-by Lance Richardson <[email protected]>Signed-off-by Lance Richardson <[email protected]>
Waiting ack from driver maintainers.
Quoted 11 lines · Ferruh Yigit
Quoted 9 lines · Lance Richardson
From: Kalesh AP <[email protected]>
Fixed to return the checksum status of rx packets by setting "
ol_flags" correctly in vector mode receive.These changes have been there for non vector mode receive. In vector mode receive also indicate inner and outer checksum errors individually in "
ol_flag" to indicate L3 and L4 error.
Quoted 7 lines
Quoted 5 lines
Fixes bc4a000f2f53 ("net/bnxt: implement SSE vector mode")Signed-off-by Kalesh AP <[email protected]>Reviewed-by Lance Richardson <[email protected]>Signed-off-by Lance Richardson <[email protected]>Waiting ack from driver maintainers.
Ferruh,
Just ack-ed the patch, sorry for the delay
Thanks
Som
Quoted 85 lines · Lance Richardson
From: Kalesh AP <[email protected]>
Fixed to return the checksum status of rx packets by setting "
ol_flags" correctly in vector mode receive.These changes have been there for non vector mode receive. In vector mode receive also indicate inner and outer checksum errors individually in "
ol_flag" to indicate L3 and L4 error.Fixes bc4a000f2f53 ("net/bnxt: implement SSE vector mode")Signed-off-by Kalesh AP <[email protected]>Reviewed-by Lance Richardson <[email protected]>Signed-off-by Lance Richardson <[email protected]>--- drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 47 ++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)drivers/net/bnxt/bnxt_rxtx_vec_sse.c +47
-1@@ -157,6 +157,52 @@ bnxt_parse_pkt_type(struct rx_pkt_cmpl *rxcmp, struct rx_pkt_cmpl_hi *rxcmp1)return pkt_type; } +static void +bnxt_parse_csum (struct rte_mbuf *mbuf,struct rx_pkt_cmpl_hi *rxcmp1) +{ +uint32_t flags; + + flags =flags2_0xf (rxcmp1); +/* IP Checksum */ +if (likely (IS_IP_NONTUNNEL_PKT (flags))) { +if (unlikely (RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; + }else if (IS_IP_TUNNEL_PKT (flags)) { +if (unlikely (RX_CMP_IP_OUTER_CS_ERROR (rxcmp1) || +RX_CMP_IP_CS_ERROR (rxcmp1))) + mbuf->ol_flags |=PKT_RX_IP_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_IP_CKSUM_GOOD ; + }else if (unlikely (RX_CMP_IP_CS_UNKNOWN (rxcmp1))) { + mbuf->ol_flags |=PKT_RX_IP_CKSUM_UNKNOWN ; + } + +/* L4 Checksum */ +if (likely (IS_L4_NONTUNNEL_PKT (flags))) { +if (unlikely (RX_CMP_L4_INNER_CS_ERR2 (rxcmp1))) + mbuf->ol_flags |=PKT_RX_L4_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_L4_CKSUM_GOOD ; + }else if (IS_L4_TUNNEL_PKT (flags)) { +if (unlikely (RX_CMP_L4_INNER_CS_ERR2 (rxcmp1))) + mbuf->ol_flags |=PKT_RX_L4_CKSUM_BAD ; +else + mbuf->ol_flags |=PKT_RX_L4_CKSUM_GOOD ; +if (unlikely (RX_CMP_L4_OUTER_CS_ERR2 (rxcmp1))) { + mbuf->ol_flags |=PKT_RX_OUTER_L4_CKSUM_BAD ; + }else if (unlikely (IS_L4_TUNNEL_PKT_ONLY_INNER_L4_CS + (flags))) { + mbuf->ol_flags |=PKT_RX_OUTER_L4_CKSUM_UNKNOWN ; + }else { + mbuf->ol_flags |=PKT_RX_OUTER_L4_CKSUM_GOOD ; + } + }else if (unlikely (RX_CMP_L4_CS_UNKNOWN (rxcmp1))) { + mbuf->ol_flags |=PKT_RX_L4_CKSUM_UNKNOWN ; + } +} +uint16_t bnxt_recv_pkts_vec (void *rx_queue,struct rte_mbuf **rx_pkts,uint16_t nb_pkts)@@ -254,6 +300,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, mbuf->ol_flags |=PKT_RX_VLAN ; } +bnxt_parse_csum (mbuf, rxcmp1); mbuf->packet_type =bnxt_parse_pkt_type (rxcmp, rxcmp1); rx_pkts[nb_rx_pkts++] = mbuf; --
Quoted 2 lines
2.17.1
Ferruh Yigit
AppliedQuoted 12 lines · Somnath Kotur
Quoted 10 lines · Lance Richardson
From: Kalesh AP <[email protected]>
Fixed to return the checksum status of rx packets by setting "
ol_flags" correctly in vector mode receive.These changes have been there for non vector mode receive. In vector mode receive also indicate inner and outer checksum errors individually in "
ol_flag" to indicate L3 and L4 error.
Quoted 8 lines
Quoted 5 lines
Fixes bc4a000f2f53 ("net/bnxt: implement SSE vector mode")Signed-off-by Kalesh AP <[email protected]>Reviewed-by Lance Richardson <[email protected]>Signed-off-by Lance Richardson <[email protected]>Acked-by Somnath Kotur <[email protected]>
Applied to dpdk-next-net/master, thanks.