watchdog: wdt977: Mark expected switch fall-through
PATCH 1/1 watchdog: wdt977: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: arm):
drivers/watchdog/wdt977.c: In function ‘wdt977_ioctl’:
LD [M] drivers/media/platform/vicodec/vicodec.odrivers/watchdog/wdt977.c:400:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
wdt977_keepalive();
^~~~~~~~~~~~~~~~~~drivers/watchdog/wdt977.c:403:2: note: here
case WDIOC_GETTIMEOUT:
^~~~
--- drivers/watchdog/wdt977.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/wdt977.c +1 -1
@@ -398,7 +398,7 @@ static long wdt977_ioctl(struct file *file, unsigned int cmd,return -EINVAL ;wdt977_keepalive (); -/* Fall */ +/* Fall through */ case WDIOC_GETTIMEOUT :return put_user (timeout, uarg.i);
Signature · 1 line
2.22.0
Quoted 7 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: arm):
drivers/watchdog/wdt977.c: In function ‘wdt977_ioctl’:
LD [M]drivers/media/platform/vicodec/vicodec.odrivers/watchdog/wdt977.c:400:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 7 lines
wdt977_keepalive(); ^~~~~~~~~~~~~~~~~~
drivers/watchdog/wdt977.c:403:2: note: here
caseWDIOC_GETTIMEOUT:
^~~~Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 20 lines
--- drivers/watchdog/wdt977.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/wdt977.c +1
-1@@ -398,7 +398,7 @@ static long wdt977_ioctl(struct file *file, unsigned int cmd,return -EINVAL ;wdt977_keepalive (); -/* Fall */ +/* Fall through */ case WDIOC_GETTIMEOUT :return put_user (timeout, uarg.i);Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook
Quoted 7 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: arm):
drivers/watchdog/wdt977.c: In function ‘wdt977_ioctl’:
LD [M]drivers/media/platform/vicodec/vicodec.odrivers/watchdog/wdt977.c:400:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 8 lines
wdt977_keepalive(); ^~~~~~~~~~~~~~~~~~
drivers/watchdog/wdt977.c:403:2: note: here
caseWDIOC_GETTIMEOUT:
^~~~Signed-off-by Gustavo A. R. Silva <[email protected]>Reviewed-by Kees Cook <[email protected]>
Quoted 17 lines
--- drivers/watchdog/wdt977.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/wdt977.c +1
-1@@ -398,7 +398,7 @@ static long wdt977_ioctl(struct file *file, unsigned int cmd,return -EINVAL ;wdt977_keepalive (); -/* Fall */ +/* Fall through */ case WDIOC_GETTIMEOUT :return put_user (timeout, uarg.i);