Skip to contentSkip to conversation

crypto: tool: getstat: Fix unterminated strncpy

PATCH In review Chuhong Yuan 2 participants 2 messages Jul 30, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: tool: getstat: Fix unterminated strncpy

strncpy(dest, src, strlen(src)) leads to unterminated dest, which is dangerous.
Fix it by using strscpy.

---
 tools/crypto/getstat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/crypto/getstat.c +1 -1
index 9e8ff76420fa..554ba08d9652 100644
@@ -41,7 +41,7 @@ static int get_stat(const char *drivername)
 	req.n.nlmsg_type = CRYPTO_MSG_GETSTAT;
 	req.n.nlmsg_seq = time(NULL);
 
-	strncpy(req.cru.cru_driver_name, drivername, strlen(drivername));
+	strscpy(req.cru.cru_driver_name, drivername, strlen(drivername) + 1);
 
 	sd =  socket(AF_NETLINK, SOCK_RAW, NETLINK_CRYPTO);
 	if (sd < 0) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 8 lines · Chuhong Yuan

strncpy(dest, src, strlen(src)) leads to unterminated dest, which is dangerous.
Fix it by using strscpy.

---
 tools/crypto/getstat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This file no longer exists in cryptodev.

Cheers,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt