Skip to contentSkip to conversation

arm64: compat: Provide definition for COMPAT_SIGMINSTKSZ

PATCH In review Will Deacon 3 participants 6 messages Jul 30, 2019 – Jul 31, 2019

Subsystems (2)
lore
Share & tools
lore

Will Deacon

author maintainer
#0 lore raw

PATCH 1/1 arm64: compat: Provide definition for COMPAT_SIGMINSTKSZ

From: Will Deacon <[email protected]>

[ Upstream commit 24951465cbd279f60b1fdc2421b3694405bcff42 ]

arch/arm/ defines a SIGMINSTKSZ of 2k, so we should use the same value for compat tasks.

Cc <[email protected]> # 4.9+
Cc Aurelien Jarno <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dominik Brodowski <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Al Viro <[email protected]>
Cc Oleg Nesterov <[email protected]>

---

Aurelien points out that this didn't get selected for -stable despite its counterpart (22839869f21a ("signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack")) being backported to 4.9. Oops.

 arch/arm64/include/asm/compat.h | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/include/asm/compat.h +1 -0
index 1a037b94eba1..cee28a05ee98 100644
@@ -159,6 +159,7 @@ static inline compat_uptr_t ptr_to_compat(void __user *uptr)
 }
 
 #define compat_user_stack_pointer() (user_stack_pointer(task_pt_regs(current)))
+#define COMPAT_MINSIGSTKSZ	2048
 
 static inline void __user *arch_compat_alloc_user_space(long len)
 {
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 20 lines · Will Deacon

From: Will Deacon <[email protected]>

[ Upstream commit 24951465cbd279f60b1fdc2421b3694405bcff42 ]

arch/arm/ defines a SIGMINSTKSZ of 2k, so we should use the same value for compat tasks.

Cc <[email protected]> # 4.9+
Cc Aurelien Jarno <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dominik Brodowski <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Al Viro <[email protected]>
Cc Oleg Nesterov <[email protected]>
Quoted 5 lines

---

Aurelien points out that this didn't get selected for -stable despite its counterpart (22839869f21a ("signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack")) being backported to 4.9. Oops.

So this needs to go into 4.9.y, 4.14.y, and 4.19.y?

thanks,

greg k-h

author maintainer
#2 lore raw
Quoted 23 lines · Greg KH
Quoted 22 lines · Will Deacon

From: Will Deacon <[email protected]>

[ Upstream commit 24951465cbd279f60b1fdc2421b3694405bcff42 ]

arch/arm/ defines a SIGMINSTKSZ of 2k, so we should use the same value for compat tasks.

Cc <[email protected]> # 4.9+
Cc Aurelien Jarno <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dominik Brodowski <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Al Viro <[email protected]>
Cc Oleg Nesterov <[email protected]>

---

Quoted 5 lines
Quoted 3 lines

Aurelien points out that this didn't get selected for -stable despite its counterpart (22839869f21a ("signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack")) being backported to 4.9. Oops.

So this needs to go into 4.9.y, 4.14.y, and 4.19.y?

Yes, please.

Will

maintainer
#3 lore raw
Quoted 24 lines · Will Deacon
Quoted 23 lines · Greg KH
Quoted 22 lines · Will Deacon

From: Will Deacon <[email protected]>

[ Upstream commit 24951465cbd279f60b1fdc2421b3694405bcff42 ]

arch/arm/ defines a SIGMINSTKSZ of 2k, so we should use the same value for compat tasks.

Cc <[email protected]> # 4.9+
Cc Aurelien Jarno <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dominik Brodowski <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Al Viro <[email protected]>
Cc Oleg Nesterov <[email protected]>

---

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Aurelien points out that this didn't get selected for -stable despite its counterpart (22839869f21a ("signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack")) being backported to 4.9. Oops.

So this needs to go into 4.9.y, 4.14.y, and 4.19.y?

Yes, please.

Thanks, will do after this next round of kernels goes out.

greg k-h

maintainer
#4 lore raw
Quoted 29 lines · Greg KH
Quoted 28 lines · Will Deacon
Quoted 27 lines · Greg KH
Quoted 25 lines · Will Deacon

From: Will Deacon <[email protected]>

[ Upstream commit 24951465cbd279f60b1fdc2421b3694405bcff42 ]

arch/arm/ defines a SIGMINSTKSZ of 2k, so we should use the same value for compat tasks.

Cc <[email protected]> # 4.9+
Cc Aurelien Jarno <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dominik Brodowski <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Al Viro <[email protected]>
Cc Oleg Nesterov <[email protected]>

---

Aurelien points out that this didn't get selected for -stable despite its counterpart (22839869f21a ("signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack")) being backported to 4.9. Oops.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

So this needs to go into 4.9.y, 4.14.y, and 4.19.y?

Yes, please.

Thanks, will do after this next round of kernels goes out.

Now queued up, thanks.

greg k-h

#5 lore raw
Quoted 30 lines · Greg KH
Quoted 29 lines · Greg KH
Quoted 28 lines · Will Deacon
Quoted 27 lines · Greg KH
Quoted 25 lines · Will Deacon

From: Will Deacon <[email protected]>

[ Upstream commit 24951465cbd279f60b1fdc2421b3694405bcff42 ]

arch/arm/ defines a SIGMINSTKSZ of 2k, so we should use the same value for compat tasks.

Cc <[email protected]> # 4.9+
Cc Aurelien Jarno <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Dominik Brodowski <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Al Viro <[email protected]>
Cc Oleg Nesterov <[email protected]>

---

Aurelien points out that this didn't get selected for -stable despite its counterpart (22839869f21a ("signal: Introduce COMPAT_SIGMINSTKSZ for use in compat_sys_sigaltstack")) being backported to 4.9. Oops.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

So this needs to go into 4.9.y, 4.14.y, and 4.19.y?

Yes, please.

Thanks, will do after this next round of kernels goes out.

Now queued up, thanks.

Thanks!

Signature · 2 lines
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
[email protected]                 http://www.aurel32.net