net: phy: fixed_phy: print gpio error only if gpio node is present
Subsystems (3)
PATCH 1/1 net: phy: fixed_phy: print gpio error only if gpio node is present
It is perfectly ok to not have an gpio attached to the fixed-link node. So the driver should not throw an error message when the gpio is missing.
Signed-off-by Hubert Feurstein <[email protected]>
--- drivers/net/phy/fixed_phy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/net/phy/fixed_phy.c +4 -2
@@ -216,8 +216,10 @@ static struct gpio_desc *fixed_phy_get_gpiod(struct device_node *np)if (IS_ERR (gpiod)) {if (PTR_ERR (gpiod) == -EPROBE_DEFER )return gpiod; -pr_err ("error getting GPIO for fixed link %pOF, proceed without\n" , - fixed_link_node); + +if (PTR_ERR (gpiod) != -ENOENT ) +pr_err ("error getting GPIO for fixed link %pOF, proceed without\n" , + fixed_link_node); gpiod =NULL ; }
Signature · 1 line
2.22.0
Quoted 4 lines · Hubert Feurstein
It is perfectly ok to not have an gpio attached to the fixed-link node. So the driver should not throw an error message when the gpio is missing.
Signed-off-by Hubert Feurstein <[email protected]>
Fixes 5468e82f7034 ("net: phy: fixed-phy: Drop GPIO from fixed_phy_add()")
Reviewed-by Andrew Lunn <[email protected]>
Andrew
David Miller
maintainerFrom: Hubert Feurstein <[email protected]>
Date: Tue, 30 Jul 2019 11:46:23 +0200
Quoted 4 lines
It is perfectly ok to not have an gpio attached to the fixed-link node. So the driver should not throw an error message when the gpio is missing.
Signed-off-by Hubert Feurstein <[email protected]>
Applied and queued up for -stable, thanks.