Skip to contentSkip to conversation

content: explicitly document the VLAN filtering as best-effort

PATCH In review Tiwei Bie 1 participant 2 messages Jul 31, 2019

lore
Share & tools
lore

Tiwei Bie

author
#0 lore raw

PATCH v2 1/1 content: explicitly document the VLAN filtering as best-effort

Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave.

---
v2:
- Drop "Fixes:" tag (will include it in the mail requesting the vote according to the github use documented in
https://lists.oasis-open.org/archives/virtio-dev/201907/msg00044.html)

v1 link:
https://lists.oasis-open.org/archives/virtio-dev/201907/msg00037.html

 content.tex | 5 +++++
 1 file changed, 5 insertions(+)
content.tex +5 -0
index 8f0498e..783322b 100644
@@ -3530,6 +3530,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 If the driver negotiates the VIRTION_NET_F_CTRL_VLAN feature, it
 can control a VLAN filter table in the device.
 
+\begin{note}
+Similar to the MAC address based filtering, the VLAN filtering
+is also best-effort: unwanted packets could still arrive.
+\end{note}
+
 \begin{lstlisting}
 #define VIRTIO_NET_CTRL_VLAN       2
  #define VIRTIO_NET_CTRL_VLAN_ADD             0
Signature · 6 lines
2.17.1


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
author
#1 lore raw
Quoted 9 lines · Tiwei Bie

Similar to the MAC address based filtering, the VLAN filtering is also best-effort in implementations, but it's not quite clear in the spec. So document this behaviour explicitly to reflect the way implementations behave.

---

Please start the vote on resolving this issue.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/47

Thanks,
Tiwei

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]