Skip to contentSkip to conversation

drm/i915/icl: Remove DDI IO power domain from PG3 power domains

PATCH Superseded Anshuman Gupta 3 participants 5 messages Jul 31, 2019 – Aug 5, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/icl: Remove DDI IO power domain from PG3 power domains

DDI IO power domain are in IO/PHY/AFE power domains. Which does not require PG3 power well to be enable. MIPI DSI dual link gets "DDI B" IO power domain reference count which enables PG3 since "DDI B" IO power domain is part of PG3 power domain, that makes power leakage in MIPI DSI dual link use case.

Cc Deak Imre <[email protected]>
Cc Syrjala Ville <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -3
index dd2a50b8ba0a..ca33e8d41218 100644
@@ -2482,11 +2482,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 	BIT_ULL(POWER_DOMAIN_TRANSCODER_C) |		\
 	BIT_ULL(POWER_DOMAIN_PIPE_B_PANEL_FITTER) |	\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_B_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_B_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_C_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_C_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_D_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_D_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_E_LANES) |	\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_E_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_F_LANES) |	\
Signature · 6 lines
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915/icl: Remove DDI IO power domain from PG3 power domains

== Series Details ==

== Series Details ==

Series: drm/i915/icl: Remove DDI IO power domain from PG3 power domains
URL : https://patchwork.freedesktop.org/series/64465/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6586 -> Patchwork_13816
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/

Known issues
------------

Here are the changes found in Patchwork_13816 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_basic@create-fd-close:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-icl-u3/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-blb-e6850/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [PASS][5] -> [FAIL][6] ([fdo#110387])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-cml-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-cml-u2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][7] -> [DMESG-WARN][8] ([fdo#102614])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-hsw-peppy/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-hsw-peppy/igt@[email protected]
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-icl-u2/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_create@basic-files:
- fi-icl-dsi: [INCOMPLETE][11] ([fdo#107713] / [fdo#109100]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-dsi/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-icl-dsi/igt@[email protected]

* igt@gem_exec_reloc@basic-write-gtt-noreloc:
- fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-icl-u3/igt@[email protected]

* igt@i915_module_load@reload-no-display:
- fi-bwr-2160: [INCOMPLETE][15] ([fdo#111174]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-bwr-2160/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-bwr-2160/igt@[email protected]

* igt@kms_chamelium@hdmi-edid-read:
- {fi-icl-u4}: [FAIL][17] ([fdo#111045] / [fdo#111046 ]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-icl-u4/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- {fi-icl-u4}: [FAIL][19] ([fdo#111045]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/fi-icl-u4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/fi-icl-u4/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#110387]: https://bugs.freedesktop.org/show_bug.cgi?id=110387
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111046 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111046
[fdo#111049]: https://bugs.freedesktop.org/show_bug.cgi?id=111049
[fdo#111174]: https://bugs.freedesktop.org/show_bug.cgi?id=111174

Participating hosts (54 -> 46)
------------------------------

Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6586 -> Patchwork_13816

CI-20190529: 20190529
CI_DRM_6586: 066993443a56467f54fdcf560e89378f8e93a15b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5116: d2e6dd2f789596da5bd06efc2e9448e3160583b6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13816: 1356afd1e0f8ff03050200e17ee59cb9fd3921b0 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

1356afd1e0f8 drm/i915/icl: Remove DDI IO power domain from PG3 power domains

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.IGT: success for drm/i915/icl: Remove DDI IO power domain from PG3 power domains

In reply to Anshuman Gupta
== Series Details ==

== Series Details ==

Series: drm/i915/icl: Remove DDI IO power domain from PG3 power domains
URL : https://patchwork.freedesktop.org/series/64465/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6586_full -> Patchwork_13816_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_13816_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_cs_tlb@vcs2:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb4/igt@[email protected]

* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [PASS][3] -> ([PASS][4], [DMESG-WARN][5]) ([fdo#108566]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-kbl1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-kbl1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-kbl3/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#110854])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb1/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-apl: [PASS][8] -> ([INCOMPLETE][9], [PASS][10]) ([fdo#103927])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl2/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl8/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#103232])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl8/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-a-64x64-bottom-edge:
- shard-snb: [PASS][13] -> [SKIP][14] ([fdo#109271] / [fdo#109278])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-snb4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-snb7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103184] / [fdo#103232])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb7/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][17] -> ([PASS][18], [FAIL][19]) ([fdo#105363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-glk3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-glk8/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-glk5/igt@[email protected]

* igt@kms_flip_tiling@flip-x-tiled:
- shard-skl: [PASS][20] -> [FAIL][21] ([fdo#108145] / [fdo#108303])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl9/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl8/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-skl: [PASS][22] -> [INCOMPLETE][23] ([fdo#104108]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl2/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-skl: [PASS][24] -> [FAIL][25] ([fdo#103167])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl2/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][26] -> [FAIL][27] ([fdo#103167]) +5 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-render:
- shard-iclb: [PASS][28] -> ([FAIL][29], [PASS][30]) ([fdo#103167])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb7/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb6/igt@[email protected]

* igt@kms_lease@lease_get:
- shard-snb: [PASS][31] -> [SKIP][32] ([fdo#109271])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-snb4/igt@kms_lease@lease_get.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-snb7/igt@kms_lease@lease_get.html

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][33] -> ([DMESG-WARN][34], [PASS][35]) ([fdo#108566]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl1/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl6/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][36] -> [FAIL][37] ([fdo#108145])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl4/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][38] -> [FAIL][39] ([fdo#108145] / [fdo#110403])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl9/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl8/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][40] -> [FAIL][41] ([fdo#108341])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb4/igt@kms_psr@no_drrs.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb1/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][42] -> ([SKIP][43], [SKIP][44]) ([fdo#109441])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_gtt.html

* igt@kms_rotation_crc@primary-rotation-270:
- shard-kbl: [PASS][45] -> ([PASS][46], [INCOMPLETE][47]) ([fdo#103665])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-kbl7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-kbl3/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-kbl4/igt@[email protected]

* igt@kms_rotation_crc@primary-y-tiled-reflect-x-0:
- shard-iclb: [PASS][48] -> ([INCOMPLETE][49], [PASS][50]) ([fdo#107713] / [fdo#110026])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb3/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb2/igt@[email protected]

* igt@perf@blocking:
- shard-skl: [PASS][51] -> [FAIL][52] ([fdo#110728])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl2/igt@[email protected]

#### Possible fixes ####

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][53] ([fdo#108566]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl7/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-torture-bo:
- shard-iclb: [INCOMPLETE][55] ([fdo#107713]) -> ([PASS][56], [PASS][57])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb2/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb8/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][58] ([fdo#105363]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-glk7/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-glk9/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][60] ([fdo#103167]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][62] ([fdo#108566]) -> ([PASS][63], [PASS][64]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-kbl4/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-kbl3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-kbl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [FAIL][65] ([fdo#103167]) -> ([PASS][66], [PASS][67])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][68] ([fdo#108145]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl5/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][70] ([fdo#108145] / [fdo#110403]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-skl2/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-skl6/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][72] ([fdo#109441]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb8/igt@kms_psr@psr2_primary_mmap_cpu.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

#### Warnings ####

* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][74] ([fdo#108566]) -> ([PASS][75], [DMESG-WARN][76]) ([fdo#108566]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-apl7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl1/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-apl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][77] ([fdo#103167]) -> ([FAIL][78], [INCOMPLETE][79]) ([fdo#103167] / [fdo#106978] / [fdo#107713])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6586/shard-iclb4/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb1/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/shard-iclb4/igt@[email protected]

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110026]: https://bugs.freedesktop.org/show_bug.cgi?id=110026
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6586 -> Patchwork_13816

CI-20190529: 20190529
CI_DRM_6586: 066993443a56467f54fdcf560e89378f8e93a15b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5116: d2e6dd2f789596da5bd06efc2e9448e3160583b6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13816: 1356afd1e0f8ff03050200e17ee59cb9fd3921b0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13816/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Anshuman Gupta
Quoted 2 lines · Anshuman Gupta

DDI IO power domain are in IO/PHY/AFE power domains. Which does not require PG3 power well to be enable.

Thanks for tracking this down.

Imo the commit message would be clearer by saying:

The DDI-IO power wells are backing the IO/PHY functionality which doesn't need the PG3 power power well. Accordingly fix up the list of PG3 power domains.

Quoted 17 lines

MIPI DSI dual link gets "DDI B" IO power domain reference count which enables PG3 since "DDI B" IO power domain is part of PG3 power domain, that makes power leakage in MIPI DSI dual link use case.

Cc Deak Imre <[email protected]>
Cc Syrjala Ville <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
index dd2a50b8ba0a..ca33e8d41218 100644

drivers/gpu/drm/i915/display/intel_display_power.c void intel_display_power_put(struct drm_i915_private *dev_priv, · line 2488

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_power.c +0 -3
@@ -2482,11 +2482,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 	BIT_ULL(POWER_DOMAIN_TRANSCODER_C) |		\
 	BIT_ULL(POWER_DOMAIN_PIPE_B_PANEL_FITTER) |	\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_B_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_B_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_C_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_C_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_D_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_D_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_E_LANES) |	\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_E_IO) |		\

What about the E/F ports' IO power wells?

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_F_LANES) |	\
Signature · 1 line
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 34 lines · Imre Deak
Quoted 2 lines · Anshuman Gupta

DDI IO power domain are in IO/PHY/AFE power domains. Which does not require PG3 power well to be enable.

Thanks for tracking this down.

Imo the commit message would be clearer by saying:

The DDI-IO power wells are backing the IO/PHY functionality which doesn't need the PG3 power power well. Accordingly fix up the list of PG3 power domains.

Quoted 21 lines

MIPI DSI dual link gets "DDI B" IO power domain reference count which enables PG3 since "DDI B" IO power domain is part of PG3 power domain, that makes power leakage in MIPI DSI dual link use case.

Cc Deak Imre <[email protected]>
Cc Syrjala Ville <[email protected]>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -1
index dd2a50b8ba0a..ca33e8d41218 100644
@@ -2482,11 +2482,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 	BIT_ULL(POWER_DOMAIN_TRANSCODER_C) |		\
 	BIT_ULL(POWER_DOMAIN_PIPE_B_PANEL_FITTER) |	\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_B_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_B_IO) |		\
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_display_power.c void intel_display_power_put(struct drm_i915_private *dev_priv, · line 2488

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display_power.c +0 -2
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_C_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_C_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_D_LANES) |	\
-	BIT_ULL(POWER_DOMAIN_PORT_DDI_D_IO) |		\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_E_LANES) |	\
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_E_IO) |		\

What about the E/F ports' IO power wells?

Also TGL_PW_3_POWER_DOMAINS needs to be fixed the same way.

Quoted 9 lines
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_display_power.c +0 -0
 	BIT_ULL(POWER_DOMAIN_PORT_DDI_F_LANES) |	\
Signature · 1 line
2.21.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx