package/host-mtd: fixes build
PATCH 1/1 package/host-mtd: fixes build
From: Julien BOIBESSOT <[email protected]>
Fixes following build error when Host doesn't have zstd devt files:
configure: WARNING: cannot find ZSTD library required for mkfs program
configure: mtd-utils can optionally be built without mkfs.ubifs
configure: mtd-utils can optionally be built without ZSTD support
configure: WARNING: cannot find headers for OpenSSL library
configure: WARNING: disabling OpenSSL support
configure: error: missing one or more dependencies
package/pkg-generic.mk:228: recipe for target '/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured' failed
make: *** [/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured] Error 1
--- package/mtd/mtd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/mtd/mtd.mk +1 -1
@@ -46,7 +46,7 @@ else MTD_CONF_OPTS += --without-xattr endif -HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux +HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd HOST_MTD_CONF_OPTS = \ --with-jffs \ --with-ubifs \
Signature · 1 line
2.1.4
PATCH 1/1 package/host-mtd: fixes build
Quoted 12 lines · On Mon, 29 Jul 2019 at 05:11, <[email protected]> wrote:
From: Julien BOIBESSOT <[email protected]>
Fixes following build error when Host doesn't have zstd devt files:
configure: WARNING: cannot find ZSTD library required for mkfs program
configure: mtd-utils can optionally be built without mkfs.ubifs
configure: mtd-utils can optionally be built without ZSTD support
configure: WARNING: cannot find headers for OpenSSL library
configure: WARNING: disabling OpenSSL support
configure: error: missing one or more dependencies
package/pkg-generic.mk:228: recipe for target '/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured' failed
make: *** [/workspace/buildroot_git_devt/output/build/host-mtd-2.1.1/.stamp_configured] Error 1
I ran into the same issue following the bump of mtd-utils to 2.1.1, and this patch took care of it for me. Therefore
Regards,
-Markus
Quoted 20 lines
Signed-off-by Julien BOIBESSOT <[email protected]>--- package/mtd/mtd.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/mtd/mtd.mk +1
-2@@ -46,7 +46,7 @@ else MTD_CONF_OPTS += --without-xattr endif -HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux +HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux host-zstd HOST_MTD_CONF_OPTS = \ --with-jffs \ --with-ubifs \ --2.1.4
PATCH 1/1 package/host-mtd: fixes build
In reply to julien.boibessot at free.frHello Julien,
The commit title should rather be:
package/mtd: add host-zstd dependency to host variant to fix build
Quoted 3 lines · On Mon, 29 Jul 2019 14:11:40 +0200 julien.boibessot at free.fr wrote:
From: Julien BOIBESSOT <[email protected]>
Fixes following build error when Host doesn't have zstd devt files:
This should also mention that the issue was introduced in the commit bumping to 2.1.1, and add references to the autobuilder failures.
However, why does this problem only occurs for the host variant, and not the target variant.
Why is this warning causing a build failure ? Normally warnings are just warnings, not errors.
Is this zstd dependency optional somehow ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/host-mtd: fixes build
Hello Thomas,
Quoted 5 lines · Thomas Petazzoni
Hello Julien,
The commit title should rather be:
package/mtd: add host-zstd dependency to host variant to fix build
OK
Quoted 9 lines
Quoted 3 lines · On Mon, 29 Jul 2019 14:11:40 +0200 julien.boibessot at free.fr wrote:
From: Julien BOIBESSOT <[email protected]>
Fixes following build error when Host doesn't have zstd devt files:
This should also mention that the issue was introduced in the commit bumping to 2.1.1, and add references to the autobuilder failures.
OK. autobuilder failures came *after* my patch ;-)
Quoted 8 lines
However, why does this problem only occurs for the host variant, and not the target variant.
Why is this warning causing a build failure ? Normally warnings are just warnings, not errors.
Is this zstd dependency optional somehow ?
It seems like zstd is now needed if ubifs is selected, like stated in mtd configure.ac:
AM_COND_IF([BUILD_UBIFS], [
need_uuid="yes"
need_xattr="yes"
need_zlib="yes"
need_lzo="yes"
need_zstd="yes" <<<<<<<<
need_openssl="yes"
])So you were right, target mtd build is also impacted....
I will resend a patch to correct both target and host build.
Regards,
Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190731/584bf9f9/attachment.html>