Skip to contentSkip to conversation

drivers/acpi/scan.c: Document why we don't need the device_hotplug_lock

PATCH In review David Hildenbrand 3 participants 3 messages Jul 31, 2019 – Aug 1, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/acpi/scan.c: Document why we don't need the device_hotplug_lock

Let's document why the lock is not needed in acpi_scan_init(), right now this is not really obvious.

Cc Rafael J. Wysocki <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Andrew Morton <[email protected]>

---

@Andrew, can you drop "drivers/acpi/scan.c: acquire device_hotplug_lock in acpi_scan_init()" and add this patch instead? Thanks

---
 drivers/acpi/scan.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/acpi/scan.c +6 -0
index 0e28270b0fd8..8444af6cd514 100644
@@ -2204,6 +2204,12 @@ int __init acpi_scan_init(void)
 	acpi_gpe_apply_masked_gpes();
 	acpi_update_all_gpes();
 
+	/*
+	 * Although we call__add_memory() that is documented to require the
+	 * device_hotplug_lock, it is not necessary here because this is an
+	 * early code when userspace or any other code path cannot trigger
+	 * hotplug/hotunplug operations.
+	 */
 	mutex_lock(&acpi_scan_lock);
 	/*
 	 * Enumerate devices in the ACPI namespace.
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · David Hildenbrand

Let's document why the lock is not needed in acpi_scan_init(), right now this is not really obvious.

Cc Rafael J. Wysocki <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Andrew Morton <[email protected]>

Thanks!

Quoted 28 lines

---

@Andrew, can you drop "drivers/acpi/scan.c: acquire device_hotplug_lock in acpi_scan_init()" and add this patch instead? Thanks

---
 drivers/acpi/scan.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/acpi/scan.c +6 -0
index 0e28270b0fd8..8444af6cd514 100644
@@ -2204,6 +2204,12 @@ int __init acpi_scan_init(void)
 	acpi_gpe_apply_masked_gpes();
 	acpi_update_all_gpes();
 
+	/*
+	 * Although we call__add_memory() that is documented to require the
+	 * device_hotplug_lock, it is not necessary here because this is an
+	 * early code when userspace or any other code path cannot trigger
+	 * hotplug/hotunplug operations.
+	 */
 	mutex_lock(&acpi_scan_lock);
 	/*
 	 * Enumerate devices in the ACPI namespace.
Signature · 1 line
2.21.0
Signature · 2 lines
Michal Hocko
SUSE Labs
Acked-by on v1 1/1
#2 lore raw
In reply to David Hildenbrand
Quoted 8 lines · David Hildenbrand

Let's document why the lock is not needed in acpi_scan_init(), right now this is not really obvious.

Cc Rafael J. Wysocki <[email protected]>
Cc Michal Hocko <[email protected]>
Cc Oscar Salvador <[email protected]>
Cc Andrew Morton <[email protected]>
Quoted 26 lines

---

@Andrew, can you drop "drivers/acpi/scan.c: acquire device_hotplug_lock in acpi_scan_init()" and add this patch instead? Thanks

---
  drivers/acpi/scan.c | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/acpi/scan.c +6 -0
index 0e28270b0fd8..8444af6cd514 100644
@@ -2204,6 +2204,12 @@ int __init acpi_scan_init(void)
  	acpi_gpe_apply_masked_gpes();
  	acpi_update_all_gpes();
 
+	/*
+	 * Although we call__add_memory() that is documented to require the
+	 * device_hotplug_lock, it is not necessary here because this is an
+	 * early code when userspace or any other code path cannot trigger
+	 * hotplug/hotunplug operations.
+	 */
  	mutex_lock(&acpi_scan_lock);
  	/*
  	 * Enumerate devices in the ACPI namespace.