drivers/acpi/scan.c: Document why we don't need the device_hotplug_lock
Subsystems (2)
PATCH 1/1 drivers/acpi/scan.c: Document why we don't need the device_hotplug_lock
Let's document why the lock is not needed in acpi_scan_init(), right now this is not really obvious.
---
@Andrew, can you drop "drivers/acpi/scan.c: acquire device_hotplug_lock in acpi_scan_init()" and add this patch instead? Thanks
--- drivers/acpi/scan.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/acpi/scan.c +6 -0
@@ -2204,6 +2204,12 @@ int __init acpi_scan_init(void)acpi_gpe_apply_masked_gpes ();acpi_update_all_gpes (); +/* +* Although we call__add_memory() that is documented to require the +* device_hotplug_lock, it is not necessary here because this is an +* early code when userspace or any other code path cannot trigger +* hotplug/hotunplug operations. +*/ mutex_lock (&acpi_scan_lock);/* * Enumerate devices in the ACPI namespace.
Signature · 1 line
2.21.0
Quoted 8 lines · David Hildenbrand
Let's document why the lock is not needed in
acpi_scan_init(), right now this is not really obvious.Cc Rafael J. Wysocki <[email protected]>Cc Michal Hocko <[email protected]>Cc Oscar Salvador <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Thanks!
Quoted 28 lines
---
@Andrew, can you drop "
drivers/acpi/scan.c: acquiredevice_hotplug_lockinacpi_scan_init()" and add this patch instead? Thanks--- drivers/acpi/scan.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/acpi/scan.c +6
-0@@ -2204,6 +2204,12 @@ int __init acpi_scan_init(void)acpi_gpe_apply_masked_gpes ();acpi_update_all_gpes (); +/* +* Although we call__add_memory() that is documented to require the +* device_hotplug_lock, it is not necessary here because this is an +* early code when userspace or any other code path cannot trigger +* hotplug/hotunplug operations. +*/ mutex_lock (&acpi_scan_lock);/* * Enumerate devices in the ACPI namespace. Signature · 1 line
2.21.0
Signature · 2 lines
Michal Hocko SUSE Labs
Quoted 8 lines · David Hildenbrand
Let's document why the lock is not needed in
acpi_scan_init(), right now this is not really obvious.Cc Rafael J. Wysocki <[email protected]>Cc Michal Hocko <[email protected]>Cc Oscar Salvador <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by David Hildenbrand <[email protected]>
Quoted 26 lines
---
@Andrew, can you drop "
drivers/acpi/scan.c: acquiredevice_hotplug_lockinacpi_scan_init()" and add this patch instead? Thanks--- drivers/acpi/scan.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/acpi/scan.c +6
-0@@ -2204,6 +2204,12 @@ int __init acpi_scan_init(void)acpi_gpe_apply_masked_gpes ();acpi_update_all_gpes (); +/* +* Although we call__add_memory() that is documented to require the +* device_hotplug_lock, it is not necessary here because this is an +* early code when userspace or any other code path cannot trigger +* hotplug/hotunplug operations. +*/ mutex_lock (&acpi_scan_lock);/* * Enumerate devices in the ACPI namespace.