Skip to contentSkip to conversation

ref-manual: Remove documentation for the removed gnome class

PATCH In review Adrian Bunk 2 participants 4 messages Jul 31, 2019 – Sep 6, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ref-manual: Remove documentation for the removed gnome class

When removed all it did was
inherit gnomebase gtk-icon-cache gconf mime
which would also be the most trivial replacement.

Most of the time not all of these classes were needed, and it is recommended to use only the ones actually required.

---
 documentation/ref-manual/ref-classes.xml | 15 ---------------
 1 file changed, 15 deletions(-)
documentation/ref-manual/ref-classes.xml +0 -15
index 37619e382d..5403f20b6f 100644
@@ -920,21 +920,6 @@
     </para>
 </section>
 
-<section id='ref-classes-gnome'>
-    <title><filename>gnome.bbclass</filename></title>
-
-    <para>
-        The <filename>gnome</filename> class supports recipes that
-        build software from the GNOME stack.
-        This class inherits the
-        <link linkend='ref-classes-gnomebase'><filename>gnomebase</filename></link>,
-        <link linkend='ref-classes-gtk-icon-cache'><filename>gtk-icon-cache</filename></link>,
-        <link linkend='ref-classes-gconf'><filename>gconf</filename></link> and
-        <link linkend='ref-classes-mime'><filename>mime</filename></link> classes.
-        The class also disables GObject introspection where applicable.
-    </para>
-</section>
-
 <section id='ref-classes-gnomebase'>
     <title><filename>gnomebase.bbclass</filename></title>
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 8 lines · Adrian Bunk

When removed all it did was
inherit gnomebase gtk-icon-cache gconf mime
which would also be the most trivial replacement.

Most of the time not all of these classes were needed, and it is recommended to use only the ones actually required.

This should go to oe-core ml as well.

Quoted 18 lines
---
 documentation/ref-manual/ref-classes.xml | 15 ---------------
 1 file changed, 15 deletions(-)
documentation/ref-manual/ref-classes.xml +0 -5
index 37619e382d..5403f20b6f 100644
@@ -920,21 +920,6 @@
     </para>
 </section>
 
-<section id='ref-classes-gnome'>
-    <title><filename>gnome.bbclass</filename></title>
-
-    <para>
-        The <filename>gnome</filename> class supports recipes that

documentation/ref-manual/ref-classes.xml line 937

Quoted 10 lines
documentation/ref-manual/ref-classes.xml +0 -10
-        build software from the GNOME stack.
-        This class inherits the
-        <link linkend='ref-classes-gnomebase'><filename>gnomebase</filename></link>,
-        <link linkend='ref-classes-gtk-icon-cache'><filename>gtk-icon-cache</filename></link>,
-        <link linkend='ref-classes-gconf'><filename>gconf</filename></link> and
-        <link linkend='ref-classes-mime'><filename>mime</filename></link> classes.
-        The class also disables GObject introspection where applicable.
-    </para>
-</section>
-

do we need to enhance the documentation for gnomebase bbclass to mention about disabling gobject introspection
or is it handled differently now.

Quoted 11 lines
documentation/ref-manual/ref-classes.xml +0 -1
 <section id='ref-classes-gnomebase'>
     <title><filename>gnomebase.bbclass</filename></title>
 
--

2.17.1

--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto

#2 lore raw
Quoted 11 lines · Khem Raj
Quoted 8 lines · Adrian Bunk

When removed all it did was
inherit gnomebase gtk-icon-cache gconf mime
which would also be the most trivial replacement.

Most of the time not all of these classes were needed, and it is recommended to use only the ones actually required.

This should go to oe-core ml as well.

Added to Cc.

Quoted 25 lines
Quoted 25 lines
---
 documentation/ref-manual/ref-classes.xml | 15 ---------------
 1 file changed, 15 deletions(-)
documentation/ref-manual/ref-classes.xml +0 -12
index 37619e382d..5403f20b6f 100644
@@ -920,21 +920,6 @@
     </para>
 </section>
 
-<section id='ref-classes-gnome'>
-    <title><filename>gnome.bbclass</filename></title>
-
-    <para>
-        The <filename>gnome</filename> class supports recipes that
-        build software from the GNOME stack.
-        This class inherits the
-        <link linkend='ref-classes-gnomebase'><filename>gnomebase</filename></link>,
-        <link linkend='ref-classes-gtk-icon-cache'><filename>gtk-icon-cache</filename></link>,
-        <link linkend='ref-classes-gconf'><filename>gconf</filename></link> and
-        <link linkend='ref-classes-mime'><filename>mime</filename></link> classes.
-        The class also disables GObject introspection where applicable.
Quoted 8 lines

documentation/ref-manual/ref-classes.xml line 937

Quoted 3 lines
documentation/ref-manual/ref-classes.xml +0 -3
-    </para>
-</section>
-

do we need to enhance the documentation for gnomebase bbclass to mention about disabling gobject introspection
or is it handled differently now.
...

This part of the documentation had been wrong for 3-4 years.

The gobject introspection disabling was moved to the gnomebase class back in 2015.

In 2016 the gnomebase class stopped disabling gobject introspection.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
In reply to Adrian Bunk

ping

Quoted 46 lines · Adrian Bunk

When removed all it did was
inherit gnomebase gtk-icon-cache gconf mime
which would also be the most trivial replacement.

Most of the time not all of these classes were needed, and it is recommended to use only the ones actually required.

---
 documentation/ref-manual/ref-classes.xml | 15 ---------------
 1 file changed, 15 deletions(-)
documentation/ref-manual/ref-classes.xml +0 -15
index 37619e382d..5403f20b6f 100644
@@ -920,21 +920,6 @@
     </para>
 </section>
 
-<section id='ref-classes-gnome'>
-    <title><filename>gnome.bbclass</filename></title>
-
-    <para>
-        The <filename>gnome</filename> class supports recipes that
-        build software from the GNOME stack.
-        This class inherits the
-        <link linkend='ref-classes-gnomebase'><filename>gnomebase</filename></link>,
-        <link linkend='ref-classes-gtk-icon-cache'><filename>gtk-icon-cache</filename></link>,
-        <link linkend='ref-classes-gconf'><filename>gconf</filename></link> and
-        <link linkend='ref-classes-mime'><filename>mime</filename></link> classes.
-        The class also disables GObject introspection where applicable.
-    </para>
-</section>
-
 <section id='ref-classes-gnomebase'>
     <title><filename>gnomebase.bbclass</filename></title>
 
Signature · 7 lines
2.17.1

-- 
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto