system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
PATCH 1/2 system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
Enable BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES if none of non-supported rootfs is selected.
---
Hi,
not sure about cloop, cpio, tar, ubi.
Kind regards,
Petr
system/Config.in | 1 + 1 file changed, 1 insertion(+)
system/Config.in +1 -0
@@ -196,6 +196,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES bool "support extended attributes in device tables" + default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2 help Support extended attributes handling in device tables
Signature · 1 line
2.20.1
PATCH 2/2 system: Add XATTR abbreviation
to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
+ capitalize
---
Hi,
you can squash this commit into previous one.
Kind regards,
Petr
system/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
system/Config.in +1 -1
@@ -195,7 +195,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE syntax of these files. config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES - bool "support extended attributes in device tables" + bool "Support extended attributes (XATTR) in device tables" default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2 help Support extended attributes handling in device tables
Signature · 1 line
2.20.1
PATCH 1/2 system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
In reply to Petr VorelPetr, All,
On 2019-07-22 07:16 +0200, Petr Vorel spake thusly:
Quoted 2 lines
Enable
BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTESif none of non-supported rootfs is selected.
No, sorry.
As I explained in another thread, there are valid cases where one does not need capabilities (and thus xattrs) on their systems.
In that case, your change would mean that the defconfig files of those people now default to using xattrs, when they previously would not.
Quoted 17 lines
Signed-off-by Petr Vorel <[email protected]>---
Hi,not sure about cloop, cpio, tar, ubi.
Kind regards,
Petrsystem/Config.in | 1 + 1 file changed, 1 insertion(+)system/Config.in +0
-0
system/Config.in config BR2_ROOTFS_STATIC_DEVICE_TABLE · line 199
Quoted 4 lines
system/Config.in +1
-0@@ -196,6 +196,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES bool "support extended attributes in device tables" + default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2
In any case, iff we were to add this, this should be done differently, because we do not want to hard-code the list of filesystems here. For one, becaise the list is long; and for two, because of filesystems from the br2-external trees.
Instead, we would have to do:
config BR2_ROOTFS_SUPPORTS_XATTRS
bool
config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
bool "support extended attributes in device tables" default y if BR2_ROOTFS_SUPPORTS_XATTRS
and then filesystems would be responsible for setting:
config BR2_TARGET_ROOTFS_EXT2
bool "ext2/3/4 root filesystem"
select BR2_ROOTFS_SUPPORTS_XATTRS
But again, I think it does not gain much. People who want xattrs will know enough to enable it.
Regards,
Yann E. MORIN.
Quoted 10 lines
system/Config.in +0
-0help Support extended attributes handling in device tablesSignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/2 system: add default to BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
Hi Yann,
Quoted 6 lines
Petr, All,
On 2019-07-22 07:16 +0200, Petr Vorel spake thusly:
Quoted 2 lines
Enable
BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTESif none of non-supported rootfs is selected.
Quoted 7 lines
No, sorry.
As I explained in another thread, there are valid cases where one does not need capabilities (and thus xattrs) on their systems.
In that case, your change would mean that the defconfig files of those people now default to using xattrs, when they previously would not.
OK, agree, thanks for an explanation.
I've set it in patchwork as rejected (+ delegate to you).
I'd still add the second patch (adding "(XATTR)" I find it just by chance, as I didn't search for "extended attributes", but for XATTR.
Quoted 36 lines
Quoted 17 lines
Signed-off-by Petr Vorel <[email protected]>---
Hi,not sure about cloop, cpio, tar, ubi.
Kind regards,
Petrsystem/Config.in | 1 + 1 file changed, 1 insertion(+)system/Config.in +0
-0system/Config.in config BR2_ROOTFS_STATIC_DEVICE_TABLE · line 199
Quoted 4 lines
system/Config.in +1
-0@@ -196,6 +196,7 @@ config BR2_ROOTFS_STATIC_DEVICE_TABLE config BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES bool "support extended attributes in device tables" + default y if !BR2_TARGET_ROOTFS_AXFS && !BR2_TARGET_ROOTFS_CRAMFS && !BR2_TARGET_ROOTFS_ISO9660 && !BR2_TARGET_ROOTFS_ROMFS && !BR2_TARGET_ROOTFS_YAFFS2In any case, iff we were to add this, this should be done differently, because we do not want to hard-code the list of filesystems here. For one, becaise the list is long; and for two, because of filesystems from the br2-external trees.
Instead, we would have to do:
config
BR2_ROOTFS_SUPPORTS_XATTRS
boolconfig
BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES
bool "support extended attributes in device tables" default y ifBR2_ROOTFS_SUPPORTS_XATTRS
Quoted 5 lines
and then filesystems would be responsible for setting:
config
BR2_TARGET_ROOTFS_EXT2
bool "ext2/3/4 root filesystem"
selectBR2_ROOTFS_SUPPORTS_XATTRS
On first (unposted) version I implemented it this way :).
Quoted 5 lines
But again, I think it does not gain much. People who want xattrs will know enough to enable it.
Regards,
Yann E. MORIN.
Kind regards,
Petr