Skip to contentSkip to conversation

drm/amd/powerplay: Allow changing of fan_control in smu_v11_0

PATCH Applied Matt Coffin 3 participants 3 messages Jul 31, 2019 – Aug 1, 2019 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/powerplay: Allow changing of fan_control in smu_v11_0

[Why]
Before this change, the fan control state on smu_v11 was not able to be changed because the capability check for checking if the fan control capability existed was inverted.

[How]
The capability check for fan control in smu_v11_0_auto_fan_control was inverted, to correctly check for the absence, instead of presence of fan control capabilities.

---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smu_v11_0.c +1 -1
index 0588dd8cd1ba..43fcbdbba630 100644
@@ -1361,7 +1361,7 @@ smu_v11_0_auto_fan_control(struct smu_context *smu, bool auto_fan_control)
 {
 	int ret = 0;
 
-	if (smu_feature_is_supported(smu, SMU_FEATURE_FAN_CONTROL_BIT))
+	if (!smu_feature_is_supported(smu, SMU_FEATURE_FAN_CONTROL_BIT))
 		return 0;
 
 	ret = smu_feature_set_enabled(smu, SMU_FEATURE_FAN_CONTROL_BIT, auto_fan_control);
Signature · 6 lines
2.22.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190731201435.10776-1-mcoffin13-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

Thanks Matt. The patch is reviewed-by: Evan Quan <[email protected]>

Regards,
Evan

Quoted 44 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Matt Coffin
Sent: Thursday, August 01, 2019 4:15 AM
To: [email protected]
Cc: Matt Coffin <[email protected]>
Subject: [PATCH] drm/amd/powerplay: Allow changing of fan_control in smu_v11_0

[Why]
Before this change, the fan control state on smu_v11 was not able to be changed because the capability check for checking if the fan control capability existed was inverted.

[How]
The capability check for fan control in smu_v11_0_auto_fan_control was inverted, to correctly check for the absence, instead of presence of fan control capabilities.

---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smu_v11_0.c +1 -1
index 0588dd8cd1ba..43fcbdbba630 100644
@@ -1361,7 +1361,7 @@ smu_v11_0_auto_fan_control(struct smu_context
 *smu, bool auto_fan_control)  {
 	int ret = 0;
 
-	if (smu_feature_is_supported(smu,
 SMU_FEATURE_FAN_CONTROL_BIT))
+	if (!smu_feature_is_supported(smu,
 SMU_FEATURE_FAN_CONTROL_BIT))
 		return 0;

ret = smu_feature_set_enabled(smu,
SMU_FEATURE_FAN_CONTROL_BIT, auto_fan_control);
--
2.22.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): MN2PR12MB334472B24E84DC3C2D94EF37E4DE0-rweVpJHSKToDMgCC8P//[email protected]

Applied
#4 lore raw

Applied. Thanks!

Alex

Quoted 49 lines · Evan

Thanks Matt. The patch is reviewed-by: Evan Quan <[email protected]>

Regards,
Evan

Quoted 44 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Matt Coffin
Sent: Thursday, August 01, 2019 4:15 AM
To: [email protected]
Cc: Matt Coffin <[email protected]>
Subject: [PATCH] drm/amd/powerplay: Allow changing of fan_control in smu_v11_0

[Why]
Before this change, the fan control state on smu_v11 was not able to be changed because the capability check for checking if the fan control capability existed was inverted.

[How]
The capability check for fan control in smu_v11_0_auto_fan_control was inverted, to correctly check for the absence, instead of presence of fan control capabilities.

---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smu_v11_0.c +1 -1
index 0588dd8cd1ba..43fcbdbba630 100644
@@ -1361,7 +1361,7 @@ smu_v11_0_auto_fan_control(struct smu_context
 *smu, bool auto_fan_control)  {
      int ret = 0;
 
-     if (smu_feature_is_supported(smu,
 SMU_FEATURE_FAN_CONTROL_BIT))
+     if (!smu_feature_is_supported(smu,
 SMU_FEATURE_FAN_CONTROL_BIT))
              return 0;

ret = smu_feature_set_enabled(smu,
SMU_FEATURE_FAN_CONTROL_BIT, auto_fan_control);
--
2.22.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx