Skip to contentSkip to conversation

webkitgtk: Stop disabling gold on aarch64 and mips

PATCH In review Adrian Bunk 2 participants 4 messages Aug 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webkitgtk: Stop disabling gold on aarch64 and mips

The binutils bug appears to have gone away.

Using gold on powerpc still fails for seemingly unrelated reasons.

---
 meta/recipes-sato/webkit/webkitgtk_2.24.3.bb | 4 ----
 1 file changed, 4 deletions(-)
meta/recipes-sato/webkit/webkitgtk_2.24.3.bb +0 -4
index f65d79b0fb..81cbf34198 100644
@@ -87,10 +87,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
 
-# binutils 2.25.1 has a bug on aarch64:
-# https://sourceware.org/bugzilla/show_bug.cgi?id=18430
-EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
-EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
 
 # JIT not supported on MIPS either
Signature · 1 line
2.17.1
#1 lore raw

I don’t remember if mips disable reason was same as aarch64 I hope it was not a runtime failure can you dig a bit

Quoted 34 lines · Adrian Bunk

The binutils bug appears to have gone away.

Using gold on powerpc still fails for seemingly unrelated reasons.

---
 meta/recipes-sato/webkit/webkitgtk_2.24.3.bb | 4 ----
 1 file changed, 4 deletions(-
meta/recipes-sato/webkit/webkitgtk_2.24.3.bb +0 -5
index f65d79b0fb..81cbf34198 100644
@@ -87,10 +87,6 @@ EXTRA_OECMAKE_append_armv5 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv6 = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_armv4 = " -DENABLE_JIT=OFF "
 
-# binutils 2.25.1 has a bug on aarch64:
-# https://sourceware.org/bugzilla/show_bug.cgi?id=18430
-EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
-EXTRA_OECMAKE_append_mipsarch = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_powerpc = " -DUSE_LD_GOLD=OFF "
 
 # JIT not supported on MIPS either
--

2.17.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw
Quoted 2 lines · Khem Raj

I don’t remember if mips disable reason was same as aarch64 I hope it was not a runtime failure can you dig a bit

Author: Khem Raj <[email protected]>
Date:   Mon Aug 8 15:51:00 2016 -0700

webkitgtk: Disable gold for mips/mips64

with binutils 2.27, mips has got the gold support but it doesnt work for webkitgtk _yet_ therefore disable it for now.

To me this looked like a buildtime failure, but it's hard to be sure when the problem is not described.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 6 lines · Adrian Bunk
Quoted 2 lines · Khem Raj

I don’t remember if mips disable reason was same as aarch64 I hope it was not a runtime failure can you dig a bit

Author: Khem Raj <[email protected]>
Date:   Mon Aug 8 15:51:00 2016 -0700
Quoted 8 lines

webkitgtk: Disable gold for mips/mips64

with binutils 2.27, mips has got the gold support but it doesnt work for webkitgtk _yet_ therefore disable it for now.

To me this looked like a buildtime failure, but it's hard to be sure when the problem is not described.

yes i remember it now it was build time failure

Quoted 3 lines

cu
Adrian