Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
This reverts commit d5ded320a14b0a2f97cbed072286748895ad18ac.
The mxs_spi.c driver for i.MX2{38} devices has been converted:
'commit d99b018a6e3d ("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPI conversion)")'
to use Device Tree and Device Model, so the DEPRECATED Kconfig symbol can be now removed.
---
drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/spi/Kconfig +0 -1
@@ -419,7 +419,6 @@ config MXC_SPI config MXS_SPI bool "MXS SPI Driver" - depends on DEPRECATED help Enable the MXS SPI controller driver. This driver can be used on the i.MX23 and i.MX28 SoCs.
Signature · 1 line
2.11.0
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Hi Jagan,
Quoted 8 lines
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.The
mxs_spi.cdriver for i.MX2{38} devices has been converted:
'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'to use Device Tree and Device Model, so the DEPRECATED
Kconfigsymbol can be now removed.
Gentle ping on this patch.
Quoted 19 lines
Signed-off-by Lukasz Majewski <[email protected]>---
drivers/spi/Kconfig | 1 - 1 file changed, 1 deletion(-)drivers/spi/Kconfig +0
-1@@ -419,7 +419,6 @@ config MXC_SPI config MXS_SPI bool "MXS SPI Driver" - depends on DEPRECATED help Enable the MXS SPI controller driver. This driver can be
Quoted 1 line
used on the i.MX23 and i.MX28 SoCs.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190903/fb735a18/attachment.sig>
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
In reply to Lukasz MajewskiQuoted 2 lines · Lukasz Majewski
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.
This wouldn't be a revert.
The deprecated patch been merged in May, 29 and
Quoted 3 lines
The
mxs_spi.cdriver for i.MX2{38} devices has been converted:
'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'
This was merged in June, 19 so please send a separate patch. I was expected this changes would be part of dm spi conversion on that driver.
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Hi Jagan,
Quoted 6 lines · Lukasz Majewski
Quoted 2 lines
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.This wouldn't be a revert.
Quoted 8 lines
The deprecated patch been merged in May, 29 and
Quoted 4 lines
The
mxs_spi.cdriver for i.MX2{38} devices has been converted:
'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'This was merged in June, 19 so please send a separate patch.
Cannot we just revert the patch? Is there any issue or technical problem with doing that ?
Quoted 3 lines
I was
expected this changes would be part of dm spi conversion on that driver.
Ok.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/8c7bc669/attachment.sig>
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Quoted 11 lines · Lukasz Majewski
Hi Jagan,
Quoted 9 lines · Lukasz Majewski
Quoted 2 lines
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.This wouldn't be a revert.
The deprecated patch been merged in May, 29 and
Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
The
mxs_spi.cdriver for i.MX2{38} devices has been converted:
'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'This was merged in June, 19 so please send a separate patch.
Cannot we just revert the patch? Is there any issue or technical problem with doing that ?
To me it's a fairly odd to say revert. It's "re-enable" of support. That said, Jagan, can you just reword the commit or something? It needs to go in either way and the contents don't change. Thanks all!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190906/6de5722d/attachment.sig>
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Quoted 17 lines · Tom Rini
Quoted 15 lines · Lukasz Majewski
Hi Jagan,
Quoted 13 lines · Lukasz Majewski
Quoted 2 lines
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.This wouldn't be a revert.
The deprecated patch been merged in May, 29 and
Quoted 4 lines
The
mxs_spi.cdriver for i.MX2{38} devices has been converted:
'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
This was merged in June, 19 so please send a separate patch.
Cannot we just revert the patch? Is there any issue or technical problem with doing that ?
To me it's a fairly odd to say revert. It's "re-enable" of support. That said, Jagan, can you just reword the commit or something? It needs to go in either way and the contents don't change. Thanks all!
Updated the commit message, and
Applied to u-boot-spi/master
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Quoted 20 lines · Jagan Teki
Quoted 19 lines · Tom Rini
Quoted 17 lines · Lukasz Majewski
Hi Jagan,
Quoted 14 lines · Lukasz Majewski
Quoted 2 lines
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.This wouldn't be a revert.
The deprecated patch been merged in May, 29 and
Quoted 4 lines
The
mxs_spi.cdriver for i.MX2{38} devices has been converted:
'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'This was merged in June, 19 so please send a separate patch.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Cannot we just revert the patch? Is there any issue or technical problem with doing that ?
To me it's a fairly odd to say revert. It's "re-enable" of support. That said, Jagan, can you just reword the commit or something? It needs to go in either way and the contents don't change. Thanks all!
Updated the commit message, and
Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190907/b8a26ea9/attachment.sig>
PATCH 1/1 Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"
Hi Tom, Jagan,
Quoted 27 lines · Jagan Teki
Quoted 26 lines · Tom Rini
Quoted 25 lines · Lukasz Majewski
Quoted 21 lines
Hi Jagan,
Quoted 8 lines
Quoted 3 lines · Lukasz Majewski
This reverts commit
d5ded320a14b0a2f97cbed072286748895ad18ac.This wouldn't be a revert.
Quoted 8 lines
The deprecated patch been merged in May, 29 and
Quoted 4 lines
The
mxs_spi.cdriver for i.MX2{38} devices has been
converted: 'commitd99b018a6e3d("spi: mxs: Add support DM/DTS for i.MX28 mxs SPI driver (DM_SPIconversion)")'This was merged in June, 19 so please send a separate patch.
Cannot we just revert the patch? Is there any issue or technical problem with doing that ?
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
To me it's a fairly odd to say revert. It's "re-enable" of support. That said, Jagan, can you just reword the commit or something? It needs to go in either way and the contents don't change. Thanks all!
Updated the commit message, and
Thanks!
Jagan, thanks for the reword :-)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190907/6bb6b097/attachment.sig>