Skip to contentSkip to conversation

fs/splice.c: Fix old documentation about moving pages

PATCH In review Leonardo Bras 1 participant 3 messages Aug 1, 2019 – Aug 16, 2019 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/splice.c: Fix old documentation about moving pages

Since commit 485ddb4b9741 ("1/2 splice: dont steal")' (2007), the SPLICE_F_MOVE support was removed (became a no-op according to man pages), and thus disabling steal operation that would make moving pages possible.

This fixes the comment, making clear pages are not moved.

---
 fs/splice.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/splice.c +1 -2
index 14cb602d9a2f..0ba151c40cef 100644
@@ -671,8 +671,7 @@ ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out,
  * @flags:	splice modifier flags
  *
  * Description:
- *    Will either move or copy pages (determined by @flags options) from
- *    the given pipe inode to the given file.
+ *    Will copy pages from the given pipe inode to the given file.
  *    This one is ->write_iter-based.
  *
  */
Signature · 1 line
2.20.1
#1 lore raw
Quoted 17 lines · Leonardo Bras

Since commit 485ddb4b9741 ("1/2 splice: dont steal")' (2007), the SPLICE_F_MOVE support was removed (became a no-op according to man pages), and thus disabling steal operation that would make moving pages possible.

This fixes the comment, making clear pages are not moved.

---
 fs/splice.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/splice.c +0 -0
index 14cb602d9a2f..0ba151c40cef 100644

fs/splice.c ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out, · line 677

Quoted 9 lines
fs/splice.c +1 -2
@@ -671,8 +671,7 @@ ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out,
  * @flags:	splice modifier flags
  *
  * Description:
- *    Will either move or copy pages (determined by @flags options) from
- *    the given pipe inode to the given file.
+ *    Will copy pages from the given pipe inode to the given file.
  *    This one is ->write_iter-based.
  *
  */

Could you give any feedback on this patch?

#2 lore raw
Quoted 13 lines · Leonardo Bras
Quoted 12 lines · Leonardo Bras

Since commit 485ddb4b9741 ("1/2 splice: dont steal")' (2007), the SPLICE_F_MOVE support was removed (became a no-op according to man pages), and thus disabling steal operation that would make moving pages possible.

This fixes the comment, making clear pages are not moved.

---
 fs/splice.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 16 lines
Quoted 5 lines
fs/splice.c +0 -0
index 14cb602d9a2f..0ba151c40cef 100644

fs/splice.c ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out, · line 677

Quoted 9 lines
fs/splice.c +1 -2
@@ -671,8 +671,7 @@ ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out,
  * @flags:	splice modifier flags
  *
  * Description:
- *    Will either move or copy pages (determined by @flags options) from
- *    the given pipe inode to the given file.
+ *    Will copy pages from the given pipe inode to the given file.
  *    This one is ->write_iter-based.
  *
  */

Could you give any feedback on this patch?

Please provide feedback on this patch