Skip to contentSkip to conversation

Replace strncmp with str_has_prefix

PATCH Applied Chuhong Yuan 1 participant 1 message Aug 2, 2019

v2 of 4 Applied Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover Replace strncmp with str_has_prefix

The commit 72921427d46b
("string.h: Add str_has_prefix() helper function") introduced str_has_prefix() to substitute error-prone strncmp(str, const, len).

strncmp(str, const, len) is easy to have error in len because of counting error or sizeof(const) without - 1.

These patches replace such pattern with str_has_prefix() to avoid hard coded constant length and sizeof.

Besides, str_has_prefix() returns the length of prefix when the comparison returns true.
We can use this return value to substitute some hard-coding.

Changelog:

v1 -> v2:
- Revise the description.
- Use the return value of str_has_prefix() to eliminate hard coding.
- Remove possible false positives and add newly detected one in upstream.

Chuhong Yuan (10):
dma: debug: Replace strncmp with str_has_prefix
gcov: Replace strncmp with str_has_prefix locking/locktorture: Replace strncmp with str_has_prefix
module: Replace strncmp with str_has_prefix
PM / sleep: Replace strncmp with str_has_prefix
printk: Replace strncmp with str_has_prefix
reboot: Replace strncmp with str_has_prefix
sched: Replace strncmp with str_has_prefix
userns: Replace strncmp with str_has_prefix
watchdog: Replace strncmp with str_has_prefix

 kernel/dma/debug.c           |  2 +-
 kernel/gcov/fs.c             |  2 +-
 kernel/locking/locktorture.c |  8 ++++----
 kernel/module.c              |  2 +-
 kernel/power/main.c          |  2 +-
 kernel/printk/braille.c      | 10 ++++++----
 kernel/printk/printk.c       | 14 ++++++++------
 kernel/reboot.c              |  6 ++++--
 kernel/sched/debug.c         |  5 +++--
 kernel/sched/isolation.c     |  9 +++++----
 kernel/user_namespace.c      | 10 +++++-----
 kernel/watchdog.c            |  8 ++++----
 12 files changed, 43 insertions(+), 35 deletions(-)
Signature · 1 line
2.20.1