bnxt_en: Use refcount_t for refcount
PATCH v2 1/2 bnxt_en: Use refcount_t for refcount
refcount_t is better for reference counters since its implementation can prevent overflows.
So convert atomic_t ref counters to refcount_t.
Signed-off-by Chuhong Yuan <[email protected]>
---
Changes in v2:
- Convert refcount from 0-base to 1-base.
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 8 ++++---- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +4 -4
@@ -49,7 +49,7 @@ static int bnxt_register_dev(struct bnxt_en_dev *edev, int ulp_id,return -ENOMEM ; } -atomic_set (&ulp->ref_count,0 ); +refcount_set (&ulp->ref_count,1 ); ulp->handle = handle;rcu_assign_pointer (ulp->ulp_ops, ulp_ops);
@@ -87,7 +87,7 @@ static int bnxt_unregister_dev(struct bnxt_en_dev *edev, int ulp_id)synchronize_rcu (); ulp->max_async_event_id =0 ; ulp->async_events_bmap =NULL ; -while (atomic_read (&ulp->ref_count) !=0 && i <10 ) { +while (refcount_read (&ulp->ref_count) !=1 && i <10 ) {msleep (100 ); i++; }
@@ -246,12 +246,12 @@ static int bnxt_send_msg(struct bnxt_en_dev *edev, int ulp_id,static void bnxt_ulp_get (struct bnxt_ulp *ulp) { -atomic_inc (&ulp->ref_count); +refcount_inc (&ulp->ref_count); }static void bnxt_ulp_put (struct bnxt_ulp *ulp) { -atomic_dec (&ulp->ref_count); +refcount_dec (&ulp->ref_count); }void bnxt_ulp_stop (struct bnxt *bp)
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h +1 -1
@@ -52,7 +52,7 @@ struct bnxt_ulp {u16 max_async_event_id;u16 msix_requested;u16 msix_base; -atomic_t ref_count; +refcount_t ref_count; };struct bnxt_en_dev {
Signature · 1 line
2.20.1