mkiss: Use refcount_t for refcount
Subsystems (2)
PATCH 1/1 mkiss: Use refcount_t for refcount
refcount_t is better for reference counters since its implementation can prevent overflows.
So convert atomic_t ref counters to refcount_t.
Signed-off-by Chuhong Yuan <[email protected]>
--- drivers/net/hamradio/mkiss.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/hamradio/mkiss.c +5 -5
@@ -70,7 +70,7 @@ struct mkiss {#define CRC_MODE_FLEX_TEST 3#define CRC_MODE_SMACK_TEST 4 -atomic_t refcnt; +refcount_t refcnt;struct completion dead; };
@@ -668,7 +668,7 @@ static struct mkiss *mkiss_get(struct tty_struct *tty)read_lock (&disc_data_lock); ax = tty->disc_data;if (ax) -atomic_inc (&ax->refcnt); +refcount_inc (&ax->refcnt);read_unlock (&disc_data_lock);return ax;
@@ -676,7 +676,7 @@ static struct mkiss *mkiss_get(struct tty_struct *tty)static void mkiss_put (struct mkiss *ax) { -if (atomic_dec_and_test (&ax->refcnt)) +if (refcount_dec_and_test (&ax->refcnt))complete (&ax->dead); }
@@ -704,7 +704,7 @@ static int mkiss_open(struct tty_struct *tty) ax->dev = dev;spin_lock_init (&ax->buflock); -atomic_set (&ax->refcnt,1 ); +refcount_set (&ax->refcnt,1 );init_completion (&ax->dead); ax->tty = tty;
@@ -784,7 +784,7 @@ static void mkiss_close(struct tty_struct *tty)* We have now ensured that nobody can start using ap from now on, but * we have to wait for all existing users to finish. */ -if (!atomic_dec_and_test (&ax->refcnt)) +if (!refcount_dec_and_test (&ax->refcnt))wait_for_completion (&ax->dead);/* * Halt the transmit queue so that a new transmit cannot scribble
Signature · 1 line
2.20.1