powerpc/pseries/hotplug-memory.c: Change rc variable to bool
PATCH v2 1/1 powerpc/pseries/hotplug-memory.c: Change rc variable to bool
Changes the return variable to bool (as the return value) and avoids doing a ternary operation before returning.
---
Changes in v2:
- Restore previous and-ing logic on rc.
arch/powerpc/platforms/pseries/hotplug-memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/powerpc/platforms/pseries/hotplug-memory.c +3 -3
@@ -338,7 +338,7 @@ static int pseries_remove_mem_node(struct device_node *np)static bool lmb_is_removable (struct drmem_lmb *lmb) {int i, scns_per_block; -int rc =1 ; +bool rc = true;unsigned long pfn, block_sz;u64 phys_addr;
@@ -363,11 +363,11 @@ static bool lmb_is_removable(struct drmem_lmb *lmb)if (!pfn_present (pfn))continue ; - rc &=is_mem_section_removable (pfn,PAGES_PER_SECTION ); + rc = rc &&is_mem_section_removable (pfn,PAGES_PER_SECTION ); phys_addr +=MIN_MEMORY_BLOCK_SIZE ; } -return rc ? true : false; +return rc; }static int dlpar_add_lmb (struct drmem_lmb *);
Signature · 1 line
2.20.1
Quoted 29 lines · Leonardo Bras
Changes the return variable to bool (as the return value) and avoids doing a ternary operation before returning.
Signed-off-by Leonardo Bras <[email protected]>---
Changes in v2:
- Restore previous and-ing logic on rc.arch/powerpc/platforms/pseries/hotplug-memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/powerpc/platforms/pseries/hotplug-memory.c +1
-1@@ -338,7 +338,7 @@ static int pseries_remove_mem_node(struct device_node *np)static bool lmb_is_removable (struct drmem_lmb *lmb) {int i, scns_per_block; -int rc =1 ; +bool rc = true;unsigned long pfn, block_sz;u64 phys_addr;@@ -363,11 +363,11 @@ static bool lmb_is_removable(struct drmem_lmb *lmb)if (!pfn_present (pfn))continue ;
arch/powerpc/platforms/pseries/hotplug-memory.c static bool lmb_is_removable(struct drmem_lmb *lmb) · line 373
Quoted 10 lines
arch/powerpc/platforms/pseries/hotplug-memory.c +2
-2- rc &=is_mem_section_removable (pfn,PAGES_PER_SECTION ); + rc = rc &&is_mem_section_removable (pfn,PAGES_PER_SECTION ); phys_addr +=MIN_MEMORY_BLOCK_SIZE ; } -return rc ? true : false; +return rc; }static int dlpar_add_lmb (struct drmem_lmb *);
Yeah, why not
Signature · 3 lines
Thanks, David / dhildenb
Hello Michael,
Any feedback on this patch?
Best regards,
Quoted 45 lines · David Hildenbrand
Quoted 29 lines · Leonardo Bras
Changes the return variable to bool (as the return value) and avoids doing a ternary operation before returning.
Signed-off-by Leonardo Bras <[email protected]>---
Changes in v2:
- Restore previous and-ing logic on rc.arch/powerpc/platforms/pseries/hotplug-memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/powerpc/platforms/pseries/hotplug-memory.c +1
-1@@ -338,7 +338,7 @@ static int pseries_remove_mem_node(struct device_node *np)static bool lmb_is_removable (struct drmem_lmb *lmb) {int i, scns_per_block; -int rc =1 ; +bool rc = true;unsigned long pfn, block_sz;u64 phys_addr;@@ -363,11 +363,11 @@ static bool lmb_is_removable(struct drmem_lmb *lmb)if (!pfn_present (pfn))continue ;arch/powerpc/platforms/pseries/hotplug-memory.c static bool lmb_is_removable(struct drmem_lmb *lmb) · line 373
Quoted 10 lines
arch/powerpc/platforms/pseries/hotplug-memory.c +2
-2- rc &=is_mem_section_removable (pfn,PAGES_PER_SECTION ); + rc = rc &&is_mem_section_removable (pfn,PAGES_PER_SECTION ); phys_addr +=MIN_MEMORY_BLOCK_SIZE ; } -return rc ? true : false; +return rc; }static int dlpar_add_lmb (struct drmem_lmb *);Yeah, why not
Reviewed-by David Hildenbrand <[email protected]>
Quoted 4 lines · Leonardo Bras
Changes the return variable to bool (as the return value) and avoids doing a ternary operation before returning.
Signed-off-by Leonardo Bras <[email protected]>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b948aaaf3e39cc475e45fea727638f191a5cb1b4
cheers
Quoted 11 lines · Michael Ellerman
Quoted 4 lines · Leonardo Bras
Changes the return variable to bool (as the return value) and avoids doing a ternary operation before returning.
Signed-off-by Leonardo Bras <[email protected]>Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/b948aaaf3e39cc475e45fea727638f191a5cb1b4
cheers
Thanks!