Skip to contentSkip to conversation

python-matplotlib: needs a toolchain with C++ support

PATCH New Peter Korsgaard 2 participants 4 messages Aug 2, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python-matplotlib: needs a toolchain with C++ support

Matplotlib contains .cpp source code:

ls src/*.cpp
src/_backend_agg.cpp
src/_backend_agg_wrapper.cpp
src/_contour.cpp
src/_contour_wrapper.cpp
src/ft2font.cpp
src/ft2font_wrapper.cpp
src/_image.cpp
src/_image_wrapper.cpp
src/mplutils.cpp
src/_path_wrapper.cpp
src/_png.cpp
src/py_converters.cpp
src/_tkagg.cpp
src/_ttconv.cpp
src/_windowing.cpp

So add a dependency on C++ support in the toolchain to fix build errors like (no autobuilder reference yet):

../output/host/bin/powerpc-buildroot-linux-uclibc-gcc -Wno-unused-result \
-Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -D_LARGEFILE_SOURCE \
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -fPIC \
-DFREETYPE_BUILD_TYPE=system \
-DPY_ARRAY_UNIQUE_SYMBOL=MPL_matplotlib_ft2font_ARRAY_API \
-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -D__STDC_FORMAT_MACROS=1 \
-I../output/host/lib/python3.7/site-packages/numpy/core/include \
-Iextern/agg24-svn/include \
-I../output/host/bin/../powerpc-buildroot-linux-uclibc/sysroot/usr/include \
-I../output/host/bin/../powerpc-buildroot-linux-uclibc/sysroot/usr/include/freetype2 \
-I. \
-I../output/host/powerpc-buildroot-linux-uclibc/sysroot/usr/include/python3.7m \
-c src/ft2font.cpp -o build/temp.linux-x86_64-3.7/src/ft2font.o
powerpc-buildroot-linux-uclibc-gcc.br_real: error: src/ft2font.cpp: C++
compiler not installed on this system

---
 package/python-matplotlib/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/python-matplotlib/Config.in +4 -0
index c5cb94dac7..14f43568f3 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_MATPLOTLIB
 	bool "python-matplotlib"
+	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_PYTHON3
 	depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
 	select BR2_PACKAGE_FREETYPE # runtime
@@ -19,3 +20,6 @@ config BR2_PACKAGE_PYTHON_MATPLOTLIB
 	  formats.
 
 	  https://matplotlib.org/
+
+comment "python-matplotlib needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 python-matplotlib: needs a toolchain with C++ support

Hello,

The commit title should start with package/python-matplotlib :-)

Quoted 19 lines · On Fri, 2 Aug 2019 18:22:26 +0200 Peter Korsgaard <[email protected]> wrote:

Matplotlib contains .cpp source code:

ls src/*.cpp
src/_backend_agg.cpp
src/_backend_agg_wrapper.cpp
src/_contour.cpp
src/_contour_wrapper.cpp
src/ft2font.cpp
src/ft2font_wrapper.cpp
src/_image.cpp
src/_image_wrapper.cpp
src/mplutils.cpp
src/_path_wrapper.cpp
src/_png.cpp
src/py_converters.cpp
src/_tkagg.cpp
src/_ttconv.cpp
src/_windowing.cpp

Quoted 2 lines

So add a dependency on C++ support in the toolchain to fix build errors like (no autobuilder reference yet):

Since when does it need C++ ? Was this package bumped recently ? If not, why don't we have autobuilder failures for this ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 python-matplotlib: needs a toolchain with C++ support

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,
The commit title should start with package/python-matplotlib :-)

Ahh, indeed - Will fix.

Quoted 22 lines
Quoted 19 lines · On Fri, 2 Aug 2019 18:22:26 +0200 Peter Korsgaard <[email protected]> wrote:

Matplotlib contains .cpp source code:

ls src/*.cpp
src/_backend_agg.cpp
src/_backend_agg_wrapper.cpp
src/_contour.cpp
src/_contour_wrapper.cpp
src/ft2font.cpp
src/ft2font_wrapper.cpp
src/_image.cpp
src/_image_wrapper.cpp
src/mplutils.cpp
src/_path_wrapper.cpp
src/_png.cpp
src/py_converters.cpp
src/_tkagg.cpp
src/_ttconv.cpp
src/_windowing.cpp

Quoted 5 lines
Quoted 2 lines

So add a dependency on C++ support in the toolchain to fix build errors like (no autobuilder reference yet):

Since when does it need C++ ? Was this package bumped recently ? If not, why don't we have autobuilder failures for this ?

Since always (the package only got added to next end of May). I'm not sure why there isn't any autobuilder failures, possibly because we don't test such combination of toolchain options? (wchar, threads, !static !c++)

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 python-matplotlib: needs a toolchain with C++ support

In reply to Peter Korsgaard
Quoted 39 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Matplotlib contains .cpp source code:
ls src/*.cpp
src/_backend_agg.cpp
src/_backend_agg_wrapper.cpp
src/_contour.cpp
src/_contour_wrapper.cpp
src/ft2font.cpp
src/ft2font_wrapper.cpp
src/_image.cpp
src/_image_wrapper.cpp
src/mplutils.cpp
src/_path_wrapper.cpp
src/_png.cpp
src/py_converters.cpp
src/_tkagg.cpp
src/_ttconv.cpp
src/_windowing.cpp

So add a dependency on C++ support in the toolchain to fix build errors like (no autobuilder reference yet):

../output/host/bin/powerpc-buildroot-linux-uclibc-gcc -Wno-unused-result \
-Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -D_LARGEFILE_SOURCE \
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -fPIC \
-DFREETYPE_BUILD_TYPE=system \
-DPY_ARRAY_UNIQUE_SYMBOL=MPL_matplotlib_ft2font_ARRAY_API \
-DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -D__STDC_FORMAT_MACROS=1 \
-I../output/host/lib/python3.7/site-packages/numpy/core/include \
-Iextern/agg24-svn/include \
-I../output/host/bin/../powerpc-buildroot-linux-uclibc/sysroot/usr/include \
-I../output/host/bin/../powerpc-buildroot-linux-uclibc/sysroot/usr/include/freetype2 \
-I. \
-I../output/host/powerpc-buildroot-linux-uclibc/sysroot/usr/include/python3.7m \
-c src/ft2font.cpp -o build/temp.linux-x86_64-3.7/src/ft2font.o
powerpc-buildroot-linux-uclibc-gcc.br_real: error: src/ft2font.cpp: C++
compiler not installed on this system

Quoted 1 line

Committed after fixing the subject, thanks.

Signature · 1 line
Bye, Peter Korsgaard