Skip to contentSkip to conversation

dpaa_eth: Use refcount_t for refcount

PATCH Applied Chuhong Yuan 2 participants 2 messages Aug 2, 2019 – Aug 9, 2019

Subsystems (3)
Networking Network drivers Freescale QorIQ DPAA Ethernet driver

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore

Chuhong Yuan

author
#0 lore raw

PATCH v2 1/1 dpaa_eth: Use refcount_t for refcount

refcount_t is better for reference counters since its implementation can prevent overflows.
So convert atomic_t ref counters to refcount_t.

Signed-off-by Chuhong Yuan <[email protected]>

---
Changes in v2:
- Add #include in dpaa_eth.h.

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 6 +++---
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +3 -3
index f38c3fa7d705..2df6e745cb3f 100644
@@ -485,7 +485,7 @@ static struct dpaa_bp *dpaa_bpid2pool(int bpid)
 static bool dpaa_bpid2pool_use(int bpid)
 {
 	if (dpaa_bpid2pool(bpid)) {
-		atomic_inc(&dpaa_bp_array[bpid]->refs);
+		refcount_inc(&dpaa_bp_array[bpid]->refs);
 		return true;
 	}
 

@@ -496,7 +496,7 @@ static bool dpaa_bpid2pool_use(int bpid)
 static void dpaa_bpid2pool_map(int bpid, struct dpaa_bp *dpaa_bp)
 {
 	dpaa_bp_array[bpid] = dpaa_bp;
-	atomic_set(&dpaa_bp->refs, 1);
+	refcount_set(&dpaa_bp->refs, 1);
 }
 
 static int dpaa_bp_alloc_pool(struct dpaa_bp *dpaa_bp)

@@ -584,7 +584,7 @@ static void dpaa_bp_free(struct dpaa_bp *dpaa_bp)
 	if (!bp)
 		return;
 
-	if (!atomic_dec_and_test(&bp->refs))
+	if (!refcount_dec_and_test(&bp->refs))
 		return;
 
 	if (bp->free_buf_cb)
drivers/net/ethernet/freescale/dpaa/dpaa_eth.h +2 -1
index af320f83c742..f7e59e8db075 100644
@@ -32,6 +32,7 @@
 #define __DPAA_H
 
 #include <linux/netdevice.h>
+#include <linux/refcount.h>
 #include <soc/fsl/qman.h>
 #include <soc/fsl/bman.h>
 

@@ -99,7 +100,7 @@ struct dpaa_bp {
 	int (*seed_cb)(struct dpaa_bp *);
 	/* bpool can be emptied before freeing by this cb */
 	void (*free_buf_cb)(const struct dpaa_bp *, struct bm_buffer *);
-	atomic_t refs;
+	refcount_t refs;
 };
 
 struct dpaa_rx_errors {
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw

From: Chuhong Yuan <[email protected]>
Date: Sat, 3 Aug 2019 00:47:59 +0800

Quoted 8 lines

refcount_t is better for reference counters since its implementation can prevent overflows.
So convert atomic_t ref counters to refcount_t.

Signed-off-by Chuhong Yuan <[email protected]>

---
Changes in v2:
- Add #include in dpaa_eth.h.

Applied to net-next.