video: fbdev: omapfb_main: Mark expected switch fall-throughs
Subsystems (2)
PATCH 1/1 video: fbdev: omapfb_main: Mark expected switch fall-throughs
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: omap1_defconfig arm):
drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=] drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
--- drivers/video/fbdev/omap/omapfb_main.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/video/fbdev/omap/omapfb_main.c +8 -0
@@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane,return 0 ;case 12 : var->bits_per_pixel =16 ; +/* fall through */ case 16 :if (plane->fbdev->panel->bpp ==12 ) plane->color_mode =OMAPFB_COLOR_RGB444 ;
@@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)case OMAPFB_ACTIVE :for (i =0 ; i < fbdev->mem_desc.region_cnt; i++)unregister_framebuffer (fbdev->fb_info[i]); +/* fall through */ case 7 :omapfb_unregister_sysfs (fbdev); +/* fall through */ case 6 :if (fbdev->panel->disable) fbdev->panel->disable (fbdev->panel); +/* fall through */ case 5 :omapfb_set_update_mode (fbdev,OMAPFB_UPDATE_DISABLED ); +/* fall through */ case 4 :planes_cleanup (fbdev); +/* fall through */ case 3 :ctrl_cleanup (fbdev); +/* fall through */ case 2 :if (fbdev->panel->cleanup) fbdev->panel->cleanup (fbdev->panel); +/* fall through */ case 1 :dev_set_drvdata (fbdev->dev,NULL );kfree (fbdev);
Signature · 1 line
2.22.0
Quoted 13 lines · Gustavo A. R. Silva
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building:
omap1_defconfigarm):
drivers/video/fbdev/omap/omapfb_main.c:449:23: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1549:6: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1547:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1545:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1543:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1540:6: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1538:3: warning: this statement may fall through [-Wimplicit-fallthrough=]drivers/video/fbdev/omap/omapfb_main.c:1535:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
Quoted 1 line
Signed-off-by Gustavo A. R. Silva <[email protected]>
-Kees
Quoted 47 lines
--- drivers/video/fbdev/omap/omapfb_main.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/video/fbdev/omap/omapfb_main.c +8
-0@@ -447,6 +447,7 @@ static int set_color_mode(struct omapfb_plane_struct *plane,return 0 ;case 12 : var->bits_per_pixel =16 ; +/* fall through */ case 16 :if (plane->fbdev->panel->bpp =12 ) plane->color_mode =OMAPFB_COLOR_RGB444 ;@@ -1534,20 +1535,27 @@ static void omapfb_free_resources(struct omapfb_device *fbdev, int state)case OMAPFB_ACTIVE :for (i =0 ; i < fbdev->mem_desc.region_cnt; i++)unregister_framebuffer (fbdev->fb_info[i]); +/* fall through */ case 7 :omapfb_unregister_sysfs (fbdev); +/* fall through */ case 6 :if (fbdev->panel->disable) fbdev->panel->disable (fbdev->panel); +/* fall through */ case 5 :omapfb_set_update_mode (fbdev,OMAPFB_UPDATE_DISABLED ); +/* fall through */ case 4 :planes_cleanup (fbdev); +/* fall through */ case 3 :ctrl_cleanup (fbdev); +/* fall through */ case 2 :if (fbdev->panel->cleanup) fbdev->panel->cleanup (fbdev->panel); +/* fall through */ case 1 :dev_set_drvdata (fbdev->dev,NULL );kfree (fbdev);Signature · 1 line
2.22.0
Signature · 1 line
Kees Cook