Skip to contentSkip to conversation

isdn: hysdn: fix code style error from checkpatch

PATCH In review Ricardo Bruno Lopes da Silva 3 participants 3 messages Aug 2, 2019 – Aug 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 isdn: hysdn: fix code style error from checkpatch

Fix error bellow from checkpatch.

WARNING: Block comments use * on subsequent lines +/*********************************************************** +

---
Hi! This is my first patch, I am learning how to contribute to Linux
kernel. Let me know if you have any suggestions.

Thanks,
Ricardo Bruno

 drivers/staging/isdn/hysdn/hycapi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/isdn/hysdn/hycapi.c +1 -4
index a2c15cd7b..b7ba28d40 100644
@@ -107,11 +107,8 @@ hycapi_remove_ctr(struct capi_ctr *ctrl)
 	card->hyctrlinfo = NULL;
 }
 
-/***********************************************************
-
-Queue a CAPI-message to the controller.
+/* Queue a CAPI-message to the controller. */
 
-***********************************************************/
 
 static void
 hycapi_sendmsg_internal(struct capi_ctr *ctrl, struct sk_buff *skb)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 7 lines · On Fri, 2 Aug 2019 19:50:17 +0000 Ricardo Bruno Lopes da Silva…

Fix error bellow from checkpatch.

WARNING: Block comments use * on subsequent lines

(quoted diff) +2 -0
+/***********************************************************
+

Read the TODO, these drivers are scheduled for removal, so changes are not helpful at this time.

#2 lore raw

Hi,

Quoted 6 lines · Stephen Hemminger
Quoted 2 lines · On Fri, 2 Aug 2019 19:50:17 +0000 Ricardo Bruno Lopes da Silva…

Fix error bellow from checkpatch.

Quoted 8 lines
Quoted 5 lines

WARNING: Block comments use * on subsequent lines

(quoted diff) +2 -0
+/***********************************************************
+

Read the TODO, these drivers are scheduled for removal, so changes are not helpful at this time.

I'm sorry, it was me who suggested Ricardo to make this change as his first contribution, I didn't see the TODO file.

Ricardo, it would be great if you could send a patch to another staging driver to get starting and to learn how the kernel development cycle works. Feel free to ping me or the lkcamp group if you want some pointers/guidance.

Thanks both for your contribution.
Helen

Quoted 5 lines

_______________________________________________
Lkcamp mailing list
[email protected]
https://lists.libreplanetbr.org/mailman/listinfo/lkcamp