Skip to contentSkip to conversation

staging: isdn: remove unnecessary parentheses

PATCH In review Thiago Bonotto 3 participants 3 messages Aug 2, 2019 – Aug 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: isdn: remove unnecessary parentheses

Fix the following checkpatch error:

ERROR: return is not a function, parentheses are not required
FILE: drivers/staging/isdn/hysdn/hysdn_net.c:289:
+ return (0); /* and return success */

---
Hello, this is my first contribution :)
Thanks for reviewing

 drivers/staging/isdn/hysdn/hysdn_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/isdn/hysdn/hysdn_net.c +1 -1
index bea37ae30..dcb9ef7a2 100644
@@ -286,7 +286,7 @@ hysdn_net_create(hysdn_card *card)
 
 	if (card->debug_flags & LOG_NET_INIT)
 		hysdn_addlog(card, "network device created");
-	return (0);		/* and return success */
+	return 0;		/* and return success */
 }				/* hysdn_net_create */
 
 /***************************************************************************/
Signature · 1 line
2.20.1
#1 lore raw

This driver is obselete so we're just keeping it around for a couple kernel releases and then deleting it. We're not taking cleanups for it.

regards,
dan carpenter

#2 lore raw

Hi,

Quoted 3 lines · Dan Carpenter

This driver is obselete so we're just keeping it around for a couple kernel releases and then deleting it. We're not taking cleanups for it.

I'm sorry, it was me who suggested Thiago to make this change as his first contribution, I didn't see the TODO file.

Thiago, it would be great if you could send a patch to another staging driver to get starting and to learn how the kernel development cycle works. Feel free to ping me or the lkcamp group if you want some pointers/guidance.

Thanks both for your contribution.
Helen

Quoted 9 lines

regards,
dan carpenter

_______________________________________________
Lkcamp mailing list
[email protected]
https://lists.libreplanetbr.org/mailman/listinfo/lkcamp