Refactor to expand subslice mask (rev 2)
Subsystems (2)
cover Refactor to expand subslice mask (rev 2)
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated:
slice * subslice stride + subslice index / 8
Note this is the second iteration of an original patch to implement the same. There are a couple of minor code changes based on changes since the first series was posted. Additionally, the original patch has been split into several smaller patches with more isolated changes based on review feedback in that first series.
Link to the original series:
https://patchwork.freedesktop.org/series/59742/
v2: Fix 32-bit build
v3: Fix typo in haswell sseu info routine and fix SSEU workaround
print
Stuart Summers (10):
drm/i915: Use variable for debugfs device status drm/i915: Add function to set SSEU info per platform drm/i915: Use local variable for subslice_mask on HSW drm/i915: Add subslice stride runtime parameter drm/i915: Add EU stride runtime parameter
drm/i915: Add function to set subslices
drm/i915: Add function to determine if a slice has a subslice drm/i915: Refactor instdone loops on new subslice functions drm/i915: Add new function to copy subslices for a slice drm/i915: Expand subslice mask
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 31 +++-- drivers/gpu/drm/i915/gt/intel_hangcheck.c | 3 +- drivers/gpu/drm/i915/gt/intel_sseu.c | 48 +++++++- drivers/gpu/drm/i915/gt/intel_sseu.h | 24 +++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +- drivers/gpu/drm/i915/i915_debugfs.c | 47 +++++--- drivers/gpu/drm/i915/i915_gpu_error.c | 5 +- drivers/gpu/drm/i915/i915_query.c | 10 +- drivers/gpu/drm/i915/intel_device_info.c | 118 +++++++++---------- 10 files changed, 186 insertions(+), 108 deletions(-)
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/10 drm/i915: Use variable for debugfs device status
Use a local variable to find SSEU runtime information in various debugfs functions.
--- drivers/gpu/drm/i915/i915_debugfs.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +10 -10
@@ -3934,8 +3934,7 @@ static void gen9_sseu_device_status(struct drm_i915_private *dev_priv, sseu->slice_mask |=BIT (s);if (IS_GEN9_BC (dev_priv)) - sseu->subslice_mask[s] = -RUNTIME_INFO (dev_priv)->sseu.subslice_mask[s]; + sseu->subslice_mask[s] = info->sseu.subslice_mask[s];for (ss =0 ; ss < info->sseu.max_subslices; ss++) {unsigned int eu_cnt;
@@ -3962,6 +3961,7 @@ static void gen9_sseu_device_status(struct drm_i915_private *dev_priv,static void broadwell_sseu_device_status (struct drm_i915_private *dev_priv,struct sseu_dev_info *sseu) { +const struct intel_runtime_info *info =RUNTIME_INFO (dev_priv);u32 slice_info =I915_READ (GEN8_GT_SLICE_INFO );int s;
@@ -3969,10 +3969,10 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv,if (sseu->slice_mask) { sseu->eu_per_subslice = -RUNTIME_INFO (dev_priv)->sseu.eu_per_subslice; + info->sseu.eu_per_subslice;for (s =0 ; s <fls (sseu->slice_mask); s++) { sseu->subslice_mask[s] = -RUNTIME_INFO (dev_priv)->sseu.subslice_mask[s]; + info->sseu.subslice_mask[s]; } sseu->eu_total = sseu->eu_per_subslice *intel_sseu_subslice_total (sseu);
@@ -3980,7 +3980,7 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv,/* subtract fused off EU(s) from enabled slice(s) */ for (s =0 ; s <fls (sseu->slice_mask); s++) {u8 subslice_7eu = -RUNTIME_INFO (dev_priv)->sseu.subslice_7eu[s]; + info->sseu.subslice_7eu[s]; sseu->eu_total -=hweight8 (subslice_7eu); }
@@ -4027,6 +4027,7 @@ static void i915_print_sseu_info(struct seq_file *m, bool is_available_info,static int i915_sseu_status (struct seq_file *m,void *unused) {struct drm_i915_private *dev_priv =node_to_i915 (m->private); +const struct intel_runtime_info *info =RUNTIME_INFO (dev_priv);struct sseu_dev_info sseu;intel_wakeref_t wakeref;
@@ -4034,14 +4035,13 @@ static int i915_sseu_status(struct seq_file *m, void *unused)return -ENODEV ;seq_puts (m,"SSEU Device Info\n" ); -i915_print_sseu_info (m, true, &RUNTIME_INFO (dev_priv)->sseu); +i915_print_sseu_info (m, true, &info->sseu);seq_puts (m,"SSEU Device Status\n" );memset (&sseu,0 ,sizeof (sseu)); - sseu.max_slices =RUNTIME_INFO (dev_priv)->sseu.max_slices; - sseu.max_subslices =RUNTIME_INFO (dev_priv)->sseu.max_subslices; - sseu.max_eus_per_subslice = -RUNTIME_INFO (dev_priv)->sseu.max_eus_per_subslice; + sseu.max_slices = info->sseu.max_slices; + sseu.max_subslices = info->sseu.max_subslices; + sseu.max_eus_per_subslice = info->sseu.max_eus_per_subslice; with_intel_runtime_pm(&dev_priv->runtime_pm, wakeref) {if (IS_CHERRYVIEW (dev_priv))
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 01/10] drm/i915: Use variable for debugfs device status
Quoting Stuart Summers (2019-08-02 21:51:25)
Quoted 19 lines
Use a local variable to find SSEU runtime information in various debugfs functions.
Signed-off-by Stuart Summers <[email protected]>---
drivers/gpu/drm/i915/i915_debugfs.c +2
-2@@ -3969,10 +3969,10 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv,if (sseu->slice_mask) { sseu->eu_per_subslice = -RUNTIME_INFO (dev_priv)->sseu.eu_per_subslice; + info->sseu.eu_per_subslice;for (s =0 ; s <fls (sseu->slice_mask); s++) { sseu->subslice_mask[s] = -RUNTIME_INFO (dev_priv)->sseu.subslice_mask[s]; + info->sseu.subslice_mask[s]; } sseu->eu_total = sseu->eu_per_subslice *intel_sseu_subslice_total (sseu);
drivers/gpu/drm/i915/i915_debugfs.c static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv, · line 3983
Quoted 5 lines
drivers/gpu/drm/i915/i915_debugfs.c +1
-1@@ -3980,7 +3980,7 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv,/* subtract fused off EU(s) from enabled slice(s) */ for (s =0 ; s <fls (sseu->slice_mask); s++) {u8 subslice_7eu = -RUNTIME_INFO (dev_priv)->sseu.subslice_7eu[s]; + info->sseu.subslice_7eu[s];
These 3 condense back to single lines.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 01/10] drm/i915: Use variable for debugfs device status
Quoted 29 lines · Chris Wilson
Quoting Stuart Summers (2019-08-02 21:51:25)
Quoted 28 lines
Use a local variable to find SSEU runtime information in various debugfs functions.
Signed-off-by Stuart Summers <[email protected]>---
(quoted diff) +0
-0@@ -3969,10 +3969,10 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv,
if (sseu->slice_mask) {
sseu->eu_per_subslice =
- RUNTIME_INFO(dev_priv)-Quoted 1 line
sseu.eu_per_subslice;
+ info->sseu.eu_per_subslice; for (s = 0; s <
fls(sseu->slice_mask); s++) { sseu->subslice_mask[s] =
- RUNTIME_INFO(dev_priv)-Quoted 1 line
sseu.subslice_mask[s];
+ info->sseu.subslice_mask[s]; }
sseu->eu_total =sseu->eu_per_subslice*intel_sseu_subslice_total(sseu);(quoted diff) +0
-0@@ -3980,7 +3980,7 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv, /* subtract fused off EU(s) from enabled slice(s) */ for (s = 0; s < fls(sseu->slice_mask); s++) {u8
subslice_7eu=
- RUNTIME_INFO(dev_priv)-
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
sseu.subslice_7eu[s];
+ info->sseu.subslice_7eu[s];
These 3 condense back to single lines.
Thanks for the review! I'll reduce these to single lines in the next revision.
Thanks,
Stuart
Quoted 3 lines
Reviewed-by Chris Wilson <[email protected]>-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/10 drm/i915: Add function to set SSEU info per platform
In reply to Stuart SummersAdd a new function to allow each platform to set maximum slice, subslice, and EU information to reduce code duplication.
--- drivers/gpu/drm/i915/gt/intel_sseu.c | 8 +++++ drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++ drivers/gpu/drm/i915/i915_debugfs.c | 6 ++-- drivers/gpu/drm/i915/intel_device_info.c | 39 +++++++++--------------- 4 files changed, 28 insertions(+), 28 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +8 -0
@@ -8,6 +8,14 @@#include "intel_lrc_reg.h" #include "intel_sseu.h" +void intel_sseu_set_info (struct sseu_dev_info *sseu,u8 max_slices, +u8 max_subslices,u8 max_eus_per_subslice) +{ + sseu->max_slices = max_slices; + sseu->max_subslices = max_subslices; + sseu->max_eus_per_subslice = max_eus_per_subslice; +} +unsigned int intel_sseu_subslice_total (const struct sseu_dev_info *sseu) {
drivers/gpu/drm/i915/gt/intel_sseu.h +3 -0
@@ -63,6 +63,9 @@ intel_sseu_from_device_info(const struct sseu_dev_info *sseu)return value; } +void intel_sseu_set_info (struct sseu_dev_info *sseu,u8 max_slices, +u8 max_subslices,u8 max_eus_per_subslice); +unsigned int intel_sseu_subslice_total (const struct sseu_dev_info *sseu);
drivers/gpu/drm/i915/i915_debugfs.c +3 -3
@@ -4039,9 +4039,9 @@ static int i915_sseu_status(struct seq_file *m, void *unused)seq_puts (m,"SSEU Device Status\n" );memset (&sseu,0 ,sizeof (sseu)); - sseu.max_slices = info->sseu.max_slices; - sseu.max_subslices = info->sseu.max_subslices; - sseu.max_eus_per_subslice = info->sseu.max_eus_per_subslice; +intel_sseu_set_info (&sseu, info->sseu.max_slices, + info->sseu.max_subslices, + info->sseu.max_eus_per_subslice); with_intel_runtime_pm(&dev_priv->runtime_pm, wakeref) {if (IS_CHERRYVIEW (dev_priv))
drivers/gpu/drm/i915/intel_device_info.c +14 -25
@@ -191,15 +191,10 @@ static void gen11_sseu_info_init(struct drm_i915_private *dev_priv)u8 eu_en;int s; -if (IS_ELKHARTLAKE (dev_priv)) { - sseu->max_slices =1 ; - sseu->max_subslices =4 ; - sseu->max_eus_per_subslice =8 ; - }else { - sseu->max_slices =1 ; - sseu->max_subslices =8 ; - sseu->max_eus_per_subslice =8 ; - } +if (IS_ELKHARTLAKE (dev_priv)) +intel_sseu_set_info (sseu,1 ,4 ,8 ); +else +intel_sseu_set_info (sseu,1 ,8 ,8 ); s_en =I915_READ (GEN11_GT_SLICE_ENABLE ) &GEN11_GT_S_ENA_MASK ; ss_en = ~I915_READ (GEN11_GT_SUBSLICE_DISABLE );
@@ -236,11 +231,10 @@ static void gen10_sseu_info_init(struct drm_i915_private *dev_priv)const int eu_mask =0xff ;u32 subslice_mask, eu_en; +intel_sseu_set_info (sseu,6 ,4 ,8 ); + sseu->slice_mask = (fuse2 &GEN10_F2_S_ENA_MASK ) >>GEN10_F2_S_ENA_SHIFT ; - sseu->max_slices =6 ; - sseu->max_subslices =4 ; - sseu->max_eus_per_subslice =8 ; subslice_mask = (1 <<4 ) -1 ; subslice_mask &= ~((fuse2 & GEN10_F2_SS_DIS_MASK) >>
@@ -314,9 +308,7 @@ static void cherryview_sseu_info_init(struct drm_i915_private *dev_priv) fuse =I915_READ (CHV_FUSE_GT ); sseu->slice_mask =BIT (0 ); - sseu->max_slices =1 ; - sseu->max_subslices =2 ; - sseu->max_eus_per_subslice =8 ; +intel_sseu_set_info (sseu,1 ,2 ,8 );if (!(fuse &CHV_FGT_DISABLE_SS0 )) { u8 disabled_mask =
@@ -372,9 +364,8 @@ static void gen9_sseu_info_init(struct drm_i915_private *dev_priv) sseu->slice_mask = (fuse2 &GEN8_F2_S_ENA_MASK ) >>GEN8_F2_S_ENA_SHIFT ;/* BXT has a single slice and at most 3 subslices. */ - sseu->max_slices =IS_GEN9_LP (dev_priv) ?1 :3 ; - sseu->max_subslices =IS_GEN9_LP (dev_priv) ?3 :4 ; - sseu->max_eus_per_subslice =8 ; +intel_sseu_set_info (sseu,IS_GEN9_LP (dev_priv) ?1 :3 , +IS_GEN9_LP (dev_priv) ?3 :4 ,8 );/* * The subslice disable field is global, i.e. it applies
@@ -473,9 +464,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv) fuse2 =I915_READ (GEN8_FUSE2 ); sseu->slice_mask = (fuse2 &GEN8_F2_S_ENA_MASK ) >>GEN8_F2_S_ENA_SHIFT ; - sseu->max_slices =3 ; - sseu->max_subslices =3 ; - sseu->max_eus_per_subslice =8 ; +intel_sseu_set_info (sseu,3 ,3 ,8 );/* * The subslice disable field is global, i.e. it applies
@@ -577,9 +566,6 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv)break ; } - sseu->max_slices =hweight8 (sseu->slice_mask); - sseu->max_subslices =hweight8 (sseu->subslice_mask[0 ]); - fuse1 =I915_READ (HSW_PAVP_FUSE1 );switch ((fuse1 &HSW_F1_EU_DIS_MASK ) >>HSW_F1_EU_DIS_SHIFT ) {default :
@@ -596,7 +582,10 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) sseu->eu_per_subslice =6 ;break ; } - sseu->max_eus_per_subslice = sseu->eu_per_subslice; + +intel_sseu_set_info (sseu,hweight8 (sseu->slice_mask), +hweight8 (sseu->subslice_mask[0 ]), + sseu->eu_per_subslice);for (s =0 ; s < sseu->max_slices; s++) {for (ss =0 ; ss < sseu->max_subslices; ss++) {
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/10 drm/i915: Use local variable for subslice_mask on HSW
In reply to Stuart SummersInstead of assuming a single slice on HSW when defining subslices for the platform, use a local variable to set the maximum subslices per slice.
--- drivers/gpu/drm/i915/intel_device_info.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/intel_device_info.c +6 -5
@@ -541,6 +541,7 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) {struct sseu_dev_info *sseu = &RUNTIME_INFO (dev_priv)->sseu;u32 fuse1; +u8 subslice_mask;int s, ss;/*
@@ -553,16 +554,16 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv)/* fall through */ case 1 : sseu->slice_mask =BIT (0 ); - sseu->subslice_mask[0 ] =BIT (0 ); + subslice_mask =BIT (0 );break ;case 2 : sseu->slice_mask =BIT (0 ); - sseu->subslice_mask[0 ] =BIT (0 ) |BIT (1 ); + subslice_mask =BIT (0 ) |BIT (1 );break ;case 3 : sseu->slice_mask =BIT (0 ) |BIT (1 ); - sseu->subslice_mask[0 ] =BIT (0 ) |BIT (1 ); - sseu->subslice_mask[1 ] =BIT (0 ) |BIT (1 ); + subslice_mask =BIT (0 ) |BIT (1 ); + subslice_mask =BIT (0 ) |BIT (1 );break ; }
@@ -584,7 +585,7 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) }intel_sseu_set_info (sseu,hweight8 (sseu->slice_mask), -hweight8 (sseu->subslice_mask[0 ]), +hweight8 (subslice_mask), sseu->eu_per_subslice);for (s =0 ; s < sseu->max_slices; s++) {
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW
Quoting Stuart Summers (2019-08-02 21:51:27)
Quoted 29 lines
Instead of assuming a single slice on HSW when defining subslices for the platform, use a local variable to set the maximum subslices per slice.
Signed-off-by Stuart Summers <[email protected]>--- drivers/gpu/drm/i915/intel_device_info.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_device_info.c +2
-1@@ -541,6 +541,7 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) {struct sseu_dev_info *sseu = &RUNTIME_INFO (dev_priv)->sseu;u32 fuse1; +u8 subslice_mask;int s, ss;/* @@ -553,16 +554,16 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv)/* fall through */ case 1 : sseu->slice_mask =BIT (0 ); - sseu->subslice_mask[0 ] =BIT (0 ); + subslice_mask =BIT (0 );break ;case 2 :
drivers/gpu/drm/i915/intel_device_info.c static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) · line 566
Quoted 10 lines
drivers/gpu/drm/i915/intel_device_info.c +3
-3sseu->slice_mask =BIT (0 ); - sseu->subslice_mask[0 ] =BIT (0 ) |BIT (1 ); + subslice_mask =BIT (0 ) |BIT (1 );break ;case 3 : sseu->slice_mask =BIT (0 ) |BIT (1 ); - sseu->subslice_mask[0 ] =BIT (0 ) |BIT (1 ); - sseu->subslice_mask[1 ] =BIT (0 ) |BIT (1 ); + subslice_mask =BIT (0 ) |BIT (1 ); + subslice_mask =BIT (0 ) |BIT (1 );
This is definitely not a single slice.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW
Quoted 37 lines · Chris Wilson
Quoting Stuart Summers (2019-08-02 21:51:27)
Quoted 36 lines
Instead of assuming a single slice on HSW when defining subslices for the platform, use a local variable to set the maximum subslices per slice.
Signed-off-by Stuart Summers <[email protected]>---
drivers/gpu/drm/i915/intel_device_info.c | 11 ++++++-----1 file changed, 6 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_device_info.c +1
-0@@ -541,6 +541,7 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) { struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu; u32 fuse1; + u8 subslice_mask; int s, ss;
/*drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -553,16 +554,16 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) /* fall through */case 1:
sseu->slice_mask = BIT(0);
- sseu->subslice_mask[0] = BIT(0); + subslice_mask = BIT(0);
break;
case 2:
sseu->slice_mask = BIT(0);
- sseu->subslice_mask[0] = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1); break;
Quoted 8 lines
Quoted 6 lines
case 3:
sseu->slice_mask = BIT(0) | BIT(1); - sseu->subslice_mask[0] = BIT(0) | BIT(1); - sseu->subslice_mask[1] = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1);This is definitely not a single slice.
Thanks for the note Chris. Very true and my commit message is misleading. Do you have any issue with the code changes I'm making here? Or simply the commit message? I'll adjust the commit message in the next revision.
Thanks,
Stuart
Quoted 1 line
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW
Quoting Stuart Summers (2019-08-02 23:47:00)
Quoted 47 lines · Chris Wilson
Quoted 37 lines
Quoting Stuart Summers (2019-08-02 21:51:27)
Quoted 36 lines
Instead of assuming a single slice on HSW when defining subslices for the platform, use a local variable to set the maximum subslices per slice.
Signed-off-by Stuart Summers <[email protected]>---
drivers/gpu/drm/i915/intel_device_info.c | 11 ++++++-----1 file changed, 6 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_device_info.c +1
-0@@ -541,6 +541,7 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) { struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu; u32 fuse1; + u8 subslice_mask; int s, ss;
/*drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -553,16 +554,16 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) /* fall through */case 1:
sseu->slice_mask = BIT(0);
- sseu->subslice_mask[0] = BIT(0); + subslice_mask = BIT(0);
break;
case 2:
sseu->slice_mask = BIT(0);
- sseu->subslice_mask[0] = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1); break;Quoted 8 lines
Quoted 6 lines
case 3:
sseu->slice_mask = BIT(0) | BIT(1); - sseu->subslice_mask[0] = BIT(0) | BIT(1); - sseu->subslice_mask[1] = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1);This is definitely not a single slice.
Quoted 4 lines
Thanks for the note Chris. Very true and my commit message is misleading. Do you have any issue with the code changes I'm making here? Or simply the commit message? I'll adjust the commit message in the next revision.
The duplication looks very wrong, just remove one of them and the reader isn't left wondering why??? At the moment, it makes me question whether there is loss of information with an incomplete subslice_mask[]. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 03/10] drm/i915: Use local variable for subslice_mask on HSW
Quoted 55 lines · Chris Wilson
Quoting Stuart Summers (2019-08-02 23:47:00)
Quoted 48 lines · Chris Wilson
Quoted 38 lines
Quoting Stuart Summers (2019-08-02 21:51:27)
Quoted 37 lines
Instead of assuming a single slice on HSW when defining subslices for the platform, use a local variable to set the maximum subslices per slice.
Signed-off-by Stuart Summers <[email protected]>---
drivers/gpu/drm/i915/intel_device_info.c | 11 ++++++-----1 file changed, 6 insertions(+), 5 deletions(-)drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -541,6 +541,7 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) {struct
sseu_dev_info*sseu = &RUNTIME_INFO(dev_priv)-Quoted 1 line
sseu;
u32 fuse1;
+ u8subslice_mask;
int s, ss;
/*drivers/gpu/drm/i915/intel_device_info.c +0
-0@@ -553,16 +554,16 @@ static void haswell_sseu_info_init(struct drm_i915_private *dev_priv) /* fall through */case 1:
sseu->slice_mask = BIT(0);
- sseu->subslice_mask[0] = BIT(0); + subslice_mask = BIT(0);
break;
case 2:
sseu->slice_mask = BIT(0);
- sseu->subslice_mask[0] = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1); break;Quoted 8 lines
Quoted 6 lines
case 3:
sseu->slice_mask = BIT(0) | BIT(1); - sseu->subslice_mask[0] = BIT(0) | BIT(1); - sseu->subslice_mask[1] = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1); + subslice_mask = BIT(0) | BIT(1);This is definitely not a single slice.
Quoted 5 lines
Thanks for the note Chris. Very true and my commit message is misleading. Do you have any issue with the code changes I'm making here? Or simply the commit message? I'll adjust the commit message in
the next revision.
Quoted 5 lines
The duplication looks very wrong, just remove one of them and the reader
isn't left wondering why??? At the moment, it makes me question whether
there is loss of information with an incomplete subslice_mask[].
Bah, obvious mistake on my part here. Thanks for pointing this out. I'll clean this up in the next revision.
Thanks,
Stuart
Quoted 1 line
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/10 drm/i915: Add subslice stride runtime parameter
In reply to Stuart SummersAdd a new parameter, ss_stride, to the runtime info structure. This is used to mirror the userspace concept of subslice stride, which is a range of subslices per slice.
This patch simply adds the definition and updates usage in the QUERY_TOPOLOGY_INFO handler.
--- drivers/gpu/drm/i915/gt/intel_sseu.c | 2 ++ drivers/gpu/drm/i915/gt/intel_sseu.h | 2 ++ drivers/gpu/drm/i915/i915_query.c | 5 ++--- 3 files changed, 6 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +2 -0
@@ -14,6 +14,8 @@ void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices, sseu->max_slices = max_slices; sseu->max_subslices = max_subslices; sseu->max_eus_per_subslice = max_eus_per_subslice; + + sseu->ss_stride =GEN_SSEU_STRIDE (sseu->max_subslices); }unsigned int
drivers/gpu/drm/i915/gt/intel_sseu.h +2 -0
@@ -33,6 +33,8 @@ struct sseu_dev_info {u8 max_subslices;u8 max_eus_per_subslice; +u8 ss_stride; +/* We don't have more than 8 eus per subslice at the moment and as we * store eus enabled using bits, no need to multiply by eus per * subslice.
drivers/gpu/drm/i915/i915_query.c +2 -3
@@ -37,7 +37,6 @@ static int query_topology_info(struct drm_i915_private *dev_priv,const struct sseu_dev_info *sseu = &RUNTIME_INFO (dev_priv)->sseu;struct drm_i915_query_topology_info topo;u32 slice_length, subslice_length, eu_length, total_length; -u8 subslice_stride =GEN_SSEU_STRIDE (sseu->max_subslices);u8 eu_stride =GEN_SSEU_STRIDE (sseu->max_eus_per_subslice);int ret;
@@ -50,7 +49,7 @@ static int query_topology_info(struct drm_i915_private *dev_priv,BUILD_BUG_ON (sizeof (u8) !=sizeof (sseu->slice_mask)); slice_length =sizeof (sseu->slice_mask); - subslice_length = sseu->max_slices * subslice_stride; + subslice_length = sseu->max_slices * sseu->ss_stride; eu_length = sseu->max_slices * sseu->max_subslices * eu_stride; total_length =sizeof (topo) + slice_length + subslice_length + eu_length;
@@ -69,7 +68,7 @@ static int query_topology_info(struct drm_i915_private *dev_priv, topo.max_eus_per_subslice = sseu->max_eus_per_subslice; topo.subslice_offset = slice_length; - topo.subslice_stride = subslice_stride; + topo.subslice_stride = sseu->ss_stride; topo.eu_offset = slice_length + subslice_length; topo.eu_stride = eu_stride;
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/10 drm/i915: Add EU stride runtime parameter
In reply to Stuart SummersAdd a new SSEU runtime parameter, eu_stride, which is used to mirror the userspace concept of a range of EUs per subslice.
This patch simply adds the parameter and updates usage in the QUERY_TOPOLOGY_INFO handler.
--- drivers/gpu/drm/i915/gt/intel_sseu.c | 1 + drivers/gpu/drm/i915/gt/intel_sseu.h | 1 + drivers/gpu/drm/i915/i915_query.c | 5 ++--- drivers/gpu/drm/i915/intel_device_info.c | 9 ++++----- 4 files changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +1 -0
@@ -16,6 +16,7 @@ void intel_sseu_set_info(struct sseu_dev_info *sseu, u8 max_slices, sseu->max_eus_per_subslice = max_eus_per_subslice; sseu->ss_stride =GEN_SSEU_STRIDE (sseu->max_subslices); + sseu->eu_stride =GEN_SSEU_STRIDE (sseu->max_eus_per_subslice); }unsigned int
drivers/gpu/drm/i915/gt/intel_sseu.h +1 -0
@@ -34,6 +34,7 @@ struct sseu_dev_info {u8 max_eus_per_subslice;u8 ss_stride; +u8 eu_stride;/* We don't have more than 8 eus per subslice at the moment and as we * store eus enabled using bits, no need to multiply by eus per
drivers/gpu/drm/i915/i915_query.c +2 -3
@@ -37,7 +37,6 @@ static int query_topology_info(struct drm_i915_private *dev_priv,const struct sseu_dev_info *sseu = &RUNTIME_INFO (dev_priv)->sseu;struct drm_i915_query_topology_info topo;u32 slice_length, subslice_length, eu_length, total_length; -u8 eu_stride =GEN_SSEU_STRIDE (sseu->max_eus_per_subslice);int ret;if (query_item->flags !=0 )
@@ -50,7 +49,7 @@ static int query_topology_info(struct drm_i915_private *dev_priv, slice_length =sizeof (sseu->slice_mask); subslice_length = sseu->max_slices * sseu->ss_stride; - eu_length = sseu->max_slices * sseu->max_subslices * eu_stride; + eu_length = sseu->max_slices * sseu->max_subslices * sseu->eu_stride; total_length =sizeof (topo) + slice_length + subslice_length + eu_length;
@@ -70,7 +69,7 @@ static int query_topology_info(struct drm_i915_private *dev_priv, topo.subslice_offset = slice_length; topo.subslice_stride = sseu->ss_stride; topo.eu_offset = slice_length + subslice_length; - topo.eu_stride = eu_stride; + topo.eu_stride = sseu->eu_stride;if (__copy_to_user (u64_to_user_ptr (query_item->data_ptr), &topo,sizeof (topo)))
drivers/gpu/drm/i915/intel_device_info.c +4 -5
@@ -118,10 +118,9 @@ void intel_device_info_dump_runtime(const struct intel_runtime_info *info,static int sseu_eu_idx (const struct sseu_dev_info *sseu,int slice,int subslice) { -int subslice_stride =GEN_SSEU_STRIDE (sseu->max_eus_per_subslice); -int slice_stride = sseu->max_subslices * subslice_stride; +int slice_stride = sseu->max_subslices * sseu->eu_stride; -return slice * slice_stride + subslice * subslice_stride; +return slice * slice_stride + subslice * sseu->eu_stride; } static u16 sseu_get_eus(const struct sseu_dev_info *sseu, int slice,
@@ -130,7 +129,7 @@ static u16 sseu_get_eus(const struct sseu_dev_info *sseu, int slice,int i, offset =sseu_eu_idx (sseu, slice, subslice);u16 eu_mask =0 ; -for (i =0 ; i <GEN_SSEU_STRIDE (sseu->max_eus_per_subslice); i++) { +for (i =0 ; i < sseu->eu_stride; i++) { eu_mask |= ((u16 )sseu->eu_mask[offset + i]) << (i *BITS_PER_BYTE ); }
@@ -143,7 +142,7 @@ static void sseu_set_eus(struct sseu_dev_info *sseu, int slice, int subslice, {int i, offset =sseu_eu_idx (sseu, slice, subslice); -for (i =0 ; i <GEN_SSEU_STRIDE (sseu->max_eus_per_subslice); i++) { +for (i =0 ; i < sseu->eu_stride; i++) { sseu->eu_mask[offset + i] = (eu_mask >> (BITS_PER_BYTE * i)) &0xff ; }
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/10 drm/i915: Add function to set subslices
In reply to Stuart SummersAdd a new function to set a range of subslices for a specified slice based on a given mask.
--- drivers/gpu/drm/i915/gt/intel_sseu.c | 10 ++++++ drivers/gpu/drm/i915/gt/intel_sseu.h | 3 ++ drivers/gpu/drm/i915/intel_device_info.c | 46 ++++++++++++++---------- 3 files changed, 41 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +10 -0
@@ -30,6 +30,16 @@ intel_sseu_subslice_total(const struct sseu_dev_info *sseu)return total; } +void intel_sseu_set_subslices (struct sseu_dev_info *sseu,int slice, +u32 ss_mask) +{ +int i, offset = slice * sseu->ss_stride; + +for (i =0 ; i < sseu->ss_stride; i++) + sseu->subslice_mask[offset + i] = + (ss_mask >> (BITS_PER_BYTE * i)) &0xff ; +} +unsigned int intel_sseu_subslices_per_slice (const struct sseu_dev_info *sseu,u8 slice) {
drivers/gpu/drm/i915/gt/intel_sseu.h +3 -0
@@ -75,6 +75,9 @@ intel_sseu_subslice_total(const struct sseu_dev_info *sseu);unsigned int intel_sseu_subslices_per_slice (const struct sseu_dev_info *sseu,u8 slice); +void intel_sseu_set_subslices (struct sseu_dev_info *sseu,int slice, +u32 ss_mask); +u32 intel_sseu_make_rpcs (struct drm_i915_private *i915,const struct intel_sseu *req_sseu);
drivers/gpu/drm/i915/intel_device_info.c +28 -18
113 lines not on this page · raw message
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/10 drm/i915: Add function to determine if a slice has a subslice
In reply to Stuart SummersAdd a new function to determine whether a particular slice has a given subslice.
--- drivers/gpu/drm/i915/gt/intel_sseu.h | 10 ++++++++++ drivers/gpu/drm/i915/intel_device_info.c | 9 ++++----- 2 files changed, 14 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.h +10 -0
@@ -66,6 +66,16 @@ intel_sseu_from_device_info(const struct sseu_dev_info *sseu)return value; } +static inline bool +intel_sseu_has_subslice (const struct sseu_dev_info *sseu,int slice, +int subslice) +{ +u8 mask = sseu->subslice_mask[slice * sseu->ss_stride + + subslice /BITS_PER_BYTE ]; + +return mask &BIT (subslice %BITS_PER_BYTE ); +} +void intel_sseu_set_info (struct sseu_dev_info *sseu,u8 max_slices,u8 max_subslices,u8 max_eus_per_subslice);
drivers/gpu/drm/i915/intel_device_info.c +4 -5
@@ -210,10 +210,9 @@ static void gen11_sseu_info_init(struct drm_i915_private *dev_priv)intel_sseu_set_subslices (sseu, s, (ss_en >> ss_idx) & ss_en_mask); -for (ss =0 ; ss < sseu->max_subslices; ss++) { -if (sseu->subslice_mask[s] &BIT (ss)) +for (ss =0 ; ss < sseu->max_subslices; ss++) +if (intel_sseu_has_subslice (sseu, s, ss))sseu_set_eus (sseu, s, ss, eu_en); - } } } sseu->eu_per_subslice =hweight8 (eu_en);
@@ -399,7 +398,7 @@ static void gen9_sseu_info_init(struct drm_i915_private *dev_priv)int eu_per_ss;u8 eu_disabled_mask; -if (!(sseu->subslice_mask[s] &BIT (ss))) +if (!intel_sseu_has_subslice (sseu, s, ss))/* skip disabled subslice */ continue ;
@@ -505,7 +504,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)u8 eu_disabled_mask;u32 n_disabled; -if (!(sseu->subslice_mask[s] &BIT (ss))) +if (!intel_sseu_has_subslice (sseu, s, ss))/* skip disabled subslice */ continue ;
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/10 drm/i915: Refactor instdone loops on new subslice functions
In reply to Stuart SummersRefactor instdone loops to use the new intel_sseu_has_subslice function.
--- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 3 +- drivers/gpu/drm/i915/gt/intel_engine_types.h | 31 ++++++++++---------- drivers/gpu/drm/i915/gt/intel_hangcheck.c | 3 +- drivers/gpu/drm/i915/i915_debugfs.c | 5 ++-- drivers/gpu/drm/i915/i915_gpu_error.c | 5 ++-- 5 files changed, 25 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/gt/intel_engine_cs.c +2 -1
@@ -1009,6 +1009,7 @@ void intel_engine_get_instdone(struct intel_engine_cs *engine, struct intel_instdone *instdone) {struct drm_i915_private *i915 = engine->i915; +const struct sseu_dev_info *sseu = &RUNTIME_INFO (i915)->sseu;struct intel_uncore *uncore = engine->uncore;u32 mmio_base = engine->mmio_base;int slice;
@@ -1026,7 +1027,7 @@ void intel_engine_get_instdone(struct intel_engine_cs *engine, instdone->slice_common =intel_uncore_read (uncore,GEN7_SC_INSTDONE ); -for_each_instdone_slice_subslice (i915, slice, subslice) { +for_each_instdone_slice_subslice (i915, sseu, slice, subslice) { instdone->sampler[slice][subslice] =read_subslice_reg (engine, slice, subslice,GEN7_SAMPLER_INSTDONE );
drivers/gpu/drm/i915/gt/intel_engine_types.h +15 -16
@@ -539,20 +539,19 @@ intel_engine_is_virtual(const struct intel_engine_cs *engine) return engine->flags & I915_ENGINE_IS_VIRTUAL; } -#define instdone_slice_mask (dev_priv__) \ - (IS_GEN(dev_priv__, 7) ? \ - 1 : RUNTIME_INFO(dev_priv__)->sseu.slice_mask) - -#define instdone_subslice_mask (dev_priv__) \ - (IS_GEN(dev_priv__, 7) ? \ - 1 : RUNTIME_INFO(dev_priv__)->sseu.subslice_mask[0]) - -#define for_each_instdone_slice_subslice (dev_priv__, slice__, subslice__) \ - for ((slice__) = 0, (subslice__) = 0; \ - (slice__) < I915_MAX_SLICES; \ - (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ - (slice__) += ((subslice__) == 0)) \ - for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ - (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) - +#define instdone_has_slice (dev_priv___, sseu___, slice___) \ + ((IS_GEN(dev_priv___, 7) ? 1 : ((sseu___)->slice_mask)) & \ + BIT(slice___)) + +#define instdone_has_subslice (dev_priv__, sseu__, slice__, subslice__) \ + (IS_GEN(dev_priv__, 7) ? (1 & BIT(subslice__)) : \ + intel_sseu_has_subslice(sseu__, 0, subslice__)) + +#define for_each_instdone_slice_subslice (dev_priv_, sseu_, slice_, subslice_) \ + for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \ + (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \ + (slice_) += ((subslice_) == 0)) \ + for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \ + (instdone_has_subslice(dev_priv_, sseu_, slice_, \ + subslice_)))#endif /* __INTEL_ENGINE_TYPES_H__ */
drivers/gpu/drm/i915/gt/intel_hangcheck.c +2 -1
@@ -53,6 +53,7 @@ static bool instdone_unchanged(u32 current_instdone, u32 *old_instdone)static bool subunits_stuck (struct intel_engine_cs *engine) {struct drm_i915_private *dev_priv = engine->i915; +const struct sseu_dev_info *sseu = &RUNTIME_INFO (dev_priv)->sseu;struct intel_instdone instdone;struct intel_instdone *accu_instdone = &engine->hangcheck.instdone;bool stuck;
@@ -71,7 +72,7 @@ static bool subunits_stuck(struct intel_engine_cs *engine) stuck &=instdone_unchanged (instdone.slice_common, &accu_instdone->slice_common); -for_each_instdone_slice_subslice (dev_priv, slice, subslice) { +for_each_instdone_slice_subslice (dev_priv, sseu, slice, subslice) { stuck &=instdone_unchanged (instdone.sampler[slice][subslice], &accu_instdone->sampler[slice][subslice]); stuck &= instdone_unchanged(instdone.row[slice][subslice],
drivers/gpu/drm/i915/i915_debugfs.c +3 -2
@@ -1048,6 +1048,7 @@ static void i915_instdone_info(struct drm_i915_private *dev_priv,struct seq_file *m, struct intel_instdone *instdone) { + const struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu;int slice;int subslice;
@@ -1063,11 +1064,11 @@ static void i915_instdone_info(struct drm_i915_private *dev_priv,if (INTEL_GEN (dev_priv) <=6 )return ; -for_each_instdone_slice_subslice (dev_priv, slice, subslice) +for_each_instdone_slice_subslice (dev_priv, sseu, slice, subslice)seq_printf (m,"\t\tSAMPLER_INSTDONE[%d][%d]: 0x%08x\n" , slice, subslice, instdone->sampler[slice][subslice]); -for_each_instdone_slice_subslice (dev_priv, slice, subslice) +for_each_instdone_slice_subslice (dev_priv, sseu, slice, subslice)seq_printf (m,"\t\tROW_INSTDONE[%d][%d]: 0x%08x\n" , slice, subslice, instdone->row[slice][subslice]); }
drivers/gpu/drm/i915/i915_gpu_error.c +3 -2
@@ -441,6 +441,7 @@ static void err_compression_marker(struct drm_i915_error_state_buf *m)static void error_print_instdone (struct drm_i915_error_state_buf *m,const struct drm_i915_error_engine *ee) { +const struct sseu_dev_info *sseu = &RUNTIME_INFO (m->i915)->sseu;int slice;int subslice;
@@ -456,12 +457,12 @@ static void error_print_instdone(struct drm_i915_error_state_buf *m,if (INTEL_GEN (m->i915) <=6 )return ; -for_each_instdone_slice_subslice (m->i915, slice, subslice) +for_each_instdone_slice_subslice (m->i915, sseu, slice, subslice)err_printf (m," SAMPLER_INSTDONE[%d][%d]: 0x%08x\n" , slice, subslice, ee->instdone.sampler[slice][subslice]); -for_each_instdone_slice_subslice (m->i915, slice, subslice) +for_each_instdone_slice_subslice (m->i915, sseu, slice, subslice)err_printf (m," ROW_INSTDONE[%d][%d]: 0x%08x\n" , slice, subslice, ee->instdone.row[slice][subslice]);
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/10 drm/i915: Add new function to copy subslices for a slice
In reply to Stuart SummersAdd a new function to copy subslices for a specified slice between intel_sseu structures for the purpose of determining power-gate status.
--- drivers/gpu/drm/i915/i915_debugfs.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +15 -6
@@ -3811,6 +3811,15 @@ i915_cache_sharing_set(void *data, u64 val)return 0 ; } +static void +intel_sseu_copy_subslices (const struct sseu_dev_info *sseu,int slice, +u8 *to_mask) +{ +int offset = slice * sseu->ss_stride; + +memcpy (&to_mask[offset], &sseu->subslice_mask[offset], sseu->ss_stride); +} +DEFINE_SIMPLE_ATTRIBUTE (i915_cache_sharing_fops, i915_cache_sharing_get, i915_cache_sharing_set,"%llu\n" );
@@ -3884,7 +3893,7 @@ static void gen10_sseu_device_status(struct drm_i915_private *dev_priv,continue ; sseu->slice_mask |=BIT (s); - sseu->subslice_mask[s] = info->sseu.subslice_mask[s]; +intel_sseu_copy_subslices (&info->sseu, s, sseu->subslice_mask);for (ss =0 ; ss < info->sseu.max_subslices; ss++) {unsigned int eu_cnt;
@@ -3935,7 +3944,8 @@ static void gen9_sseu_device_status(struct drm_i915_private *dev_priv, sseu->slice_mask |=BIT (s);if (IS_GEN9_BC (dev_priv)) - sseu->subslice_mask[s] = info->sseu.subslice_mask[s]; +intel_sseu_copy_subslices (&info->sseu, s, + sseu->subslice_mask);for (ss =0 ; ss < info->sseu.max_subslices; ss++) {unsigned int eu_cnt;
@@ -3971,10 +3981,9 @@ static void broadwell_sseu_device_status(struct drm_i915_private *dev_priv,if (sseu->slice_mask) { sseu->eu_per_subslice = info->sseu.eu_per_subslice; -for (s =0 ; s <fls (sseu->slice_mask); s++) { - sseu->subslice_mask[s] = - info->sseu.subslice_mask[s]; - } +for (s =0 ; s <fls (sseu->slice_mask); s++) +intel_sseu_copy_subslices (&info->sseu, s, + sseu->subslice_mask); sseu->eu_total = sseu->eu_per_subslice *intel_sseu_subslice_total (sseu);
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 10/10 drm/i915: Expand subslice mask
In reply to Stuart SummersCurrently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated:
slice * subslice stride + subslice index / 8
v2: Fix 32-bit build
v3: Fix typo on haswell and update SSEU workaround to correctly
print subslice mask on error.
--- drivers/gpu/drm/i915/gt/intel_sseu.c | 27 ++++++++++++++++++++- drivers/gpu/drm/i915/gt/intel_sseu.h | 5 +++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++-- drivers/gpu/drm/i915/i915_debugfs.c | 5 +++- drivers/gpu/drm/i915/intel_device_info.c | 8 +++--- 5 files changed, 40 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/intel_sseu.c +26 -1
@@ -30,6 +30,31 @@ intel_sseu_subslice_total(const struct sseu_dev_info *sseu)return total; } +u32 intel_sseu_get_subslices (const struct sseu_dev_info *sseu,u8 slice) +{ +int i, offset = slice * sseu->ss_stride; +u32 mask =0 ; + +if (slice >= sseu->max_slices) { +DRM_ERROR ("%s: invalid slice %d, max: %d\n" , + __func__, slice, sseu->max_slices); +return 0 ; + } + +if (sseu->ss_stride >sizeof (mask)) { +DRM_ERROR ("%s: invalid subslice stride %d, max: %u\n" , + __func__, sseu->ss_stride, + (unsigned int )sizeof (mask)); +return 0 ; + } + +for (i =0 ; i < sseu->ss_stride; i++) + mask |= (u32 )sseu->subslice_mask[offset + i] << + i *BITS_PER_BYTE ; + +return mask; +} +void intel_sseu_set_subslices (struct sseu_dev_info *sseu,int slice,u32 ss_mask) {
@@ -43,7 +68,7 @@ void intel_sseu_set_subslices(struct sseu_dev_info *sseu, int slice,unsigned int intel_sseu_subslices_per_slice (const struct sseu_dev_info *sseu,u8 slice) { -return hweight8 (sseu->subslice_mask[slice]); +return hweight32 (intel_sseu_get_subslices (sseu, slice)); } u32 intel_sseu_make_rpcs(struct drm_i915_private *i915,
drivers/gpu/drm/i915/gt/intel_sseu.h +4 -1
@@ -15,10 +15,11 @@ struct drm_i915_private;#define GEN_MAX_SLICES (6)/* CNL upper bound */ #define GEN_MAX_SUBSLICES (8)/* ICL upper bound */ #define GEN_SSEU_STRIDE (max_entries) DIV_ROUND_UP(max_entries, BITS_PER_BYTE) +#define GEN_MAX_SUBSLICE_STRIDE GEN_SSEU_STRIDE(GEN_MAX_SUBSLICES)struct sseu_dev_info {u8 slice_mask; -u8 subslice_mask[GEN_MAX_SLICES ]; +u8 subslice_mask[GEN_MAX_SLICES *GEN_MAX_SUBSLICE_STRIDE ];u16 eu_total;u8 eu_per_subslice;u8 min_eu_in_pool;
@@ -85,6 +86,8 @@ intel_sseu_subslice_total(const struct sseu_dev_info *sseu);unsigned int intel_sseu_subslices_per_slice (const struct sseu_dev_info *sseu,u8 slice); +u32 intel_sseu_get_subslices (const struct sseu_dev_info *sseu,u8 slice); +void intel_sseu_set_subslices (struct sseu_dev_info *sseu,int slice,u32 ss_mask);
drivers/gpu/drm/i915/gt/intel_workarounds.c +2 -3
@@ -794,11 +794,10 @@ wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal) } slice =fls (sseu->slice_mask) -1 ; -GEM_BUG_ON (slice >=ARRAY_SIZE (sseu->subslice_mask)); - subslice =fls (l3_en & sseu->subslice_mask[slice]); + subslice =fls (l3_en &intel_sseu_get_subslices (sseu, slice));if (!subslice) {DRM_WARN ("No common index found between subslice mask %x and L3 bank mask %x!\n" , - sseu->subslice_mask[slice], l3_en); +intel_sseu_get_subslices (sseu, slice), l3_en); subslice =fls (l3_en);WARN_ON (!subslice); }
drivers/gpu/drm/i915/i915_debugfs.c +4 -1
@@ -3949,13 +3949,16 @@ static void gen9_sseu_device_status(struct drm_i915_private *dev_priv,for (ss =0 ; ss < info->sseu.max_subslices; ss++) {unsigned int eu_cnt; +u8 ss_idx = s * info->sseu.ss_stride + + ss /BITS_PER_BYTE ;if (IS_GEN9_LP (dev_priv)) {if (!(s_reg[s] & (GEN9_PGCTL_SS_ACK (ss))))/* skip disabled subslice */ continue ; - sseu->subslice_mask[s] |=BIT (ss); + sseu->subslice_mask[ss_idx] |= +BIT (ss %BITS_PER_BYTE ); } eu_cnt = 2 * hweight32(eu_reg[2*s + ss/2] &
drivers/gpu/drm/i915/intel_device_info.c +4 -4
@@ -93,9 +93,9 @@ static void sseu_dump(const struct sseu_dev_info *sseu, struct drm_printer *p) hweight8(sseu->slice_mask), sseu->slice_mask);drm_printf (p,"subslice total: %u\n" ,intel_sseu_subslice_total (sseu));for (s =0 ; s < sseu->max_slices; s++) { -drm_printf (p,"slice%d: %u subslices, mask=%04x\n" , +drm_printf (p,"slice%d: %u subslices, mask=%08x\n" , s,intel_sseu_subslices_per_slice (sseu, s), - sseu->subslice_mask[s]); +intel_sseu_get_subslices (sseu, s)); }drm_printf (p,"EU total: %u\n" , sseu->eu_total);drm_printf (p,"EU per subslice: %u\n" , sseu->eu_per_subslice);
@@ -159,9 +159,9 @@ void intel_device_info_dump_topology(const struct sseu_dev_info *sseu, }for (s =0 ; s < sseu->max_slices; s++) { -drm_printf (p,"slice%d: %u subslice(s) (0x%hhx):\n" , +drm_printf (p,"slice%d: %u subslice(s) (0x%08x):\n" , s,intel_sseu_subslices_per_slice (sseu, s), - sseu->subslice_mask[s]); +intel_sseu_get_subslices (sseu, s));for (ss =0 ; ss < sseu->max_subslices; ss++) {u16 enabled_eus =sseu_get_eus (sseu, s, ss);
Signature · 6 lines
2.21.0.5.gaeb582a983 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev 2)
In reply to Stuart Summers== Series Details ==
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64636/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip b6ccbffe3ad2 drm/i915: Use variable for debugfs device status 2caf5e999b9f drm/i915: Add function to set SSEU info per platform 9675f9c76871 drm/i915: Use local variable for subslice_mask on HSW 03d13effb1dd drm/i915: Add subslice stride runtime parameter be080a3d1ae0 drm/i915: Add EU stride runtime parameter 47ce1594e6d6 drm/i915: Add function to set subslices 9a53ca3b4088 drm/i915: Add function to determine if a slice has a subslice 6f80201ea630 drm/i915: Refactor instdone loops on new subslice functions -:60: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible side-effects? #60: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:546: +#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \ + (IS_GEN(dev_priv__, 7) ? (1 & BIT(subslice__)) : \ + intel_sseu_has_subslice(sseu__, 0, subslice__))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv_' - possible side-effects? #64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:550:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sseu_' - possible side-effects? #64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:550:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice_' - possible side-effects? #64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:550:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice_' - possible side-effects? #64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:550:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
total: 0 errors, 0 warnings, 5 checks, 106 lines checked d64c93871947 drm/i915: Add new function to copy subslices for a slice 39b89e427a09 drm/i915: Expand subslice mask
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Refactor to expand subslice mask (rev 2)
In reply to Stuart Summers== Series Details ==
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64636/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6618 -> Patchwork_13858
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/
Known issues
------------
Here are the changes found in Patchwork_13858 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@create-close:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-icl-u3/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-blb-e6850/igt@[email protected]
* igt@i915_selftest@live_execlists:
- fi-skl-gvtdvm: [PASS][5] -> [DMESG-FAIL][6] ([fdo#111108])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: [PASS][7] -> [WARN][8] ([fdo#109380])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-kbl-7567u/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-kbl-7567u/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7567u: [PASS][9] -> [FAIL][10] ([fdo#109485])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-kbl-7567u/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-kbl-7567u/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-kbl-7567u: [PASS][11] -> [SKIP][12] ([fdo#109271]) +23 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-kbl-7567u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-kbl-7567u/igt@[email protected]
#### Possible fixes ####
* igt@i915_getparams_basic@basic-subslice-total:
- fi-icl-dsi: [INCOMPLETE][13] ([fdo#107713]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-icl-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-icl-dsi/igt@[email protected]
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: [SKIP][15] ([fdo#109271] / [fdo#109278]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/fi-kbl-7567u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/fi-kbl-7567u/igt@[email protected]
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108
Participating hosts (55 -> 47)
------------------------------
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6618 -> Patchwork_13858
CI-20190529: 20190529
CI_DRM_6618: 7bef836acab541f26d5806697c13181df22f71a1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5120: b3138fbea79d5d7935e53530b90efe3e816236f4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13858: 39b89e427a09312070728bbec82701dc3df3bb77 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
39b89e427a09 drm/i915: Expand subslice maskd64c93871947 drm/i915: Add new function to copy subslices for a slice 6f80201ea630 drm/i915: Refactor instdone loops on new subslice functions 9a53ca3b4088 drm/i915: Add function to determine if a slice has a subslice 47ce1594e6d6 drm/i915: Add function to set subslices be080a3d1ae0 drm/i915: Add EU stride runtime parameter 03d13effb1dd drm/i915: Add subslice stride runtime parameter 9675f9c76871 drm/i915: Use local variable for subslice_mask on HSW 2caf5e999b9f drm/i915: Add function to set SSEU info per platform b6ccbffe3ad2 drm/i915: Use variable for debugfs device status
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Refactor to expand subslice mask (rev 2)
In reply to Stuart Summers== Series Details ==
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64636/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6618_full -> Patchwork_13858_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13858_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
- shard-hsw: [PASS][1] -> [INCOMPLETE][2] ([fdo#103540])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-hsw2/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][3] -> [FAIL][4] ([fdo#105767])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-hsw2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-hsw4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][5] -> [FAIL][6] ([fdo#102670])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#105363])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][9] -> [FAIL][10] ([fdo#103167]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-plflip-blt:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#103167])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103166])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb6/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-apl8/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#108566]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-apl4/igt@[email protected]
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#104108])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl7/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#110728])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl2/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-skl: [FAIL][27] ([fdo#109661]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl9/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl7/igt@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-apl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
- shard-skl: [FAIL][31] ([fdo#103232]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl2/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge:
- shard-iclb: [INCOMPLETE][33] ([fdo#107713]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb6/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate:
- shard-skl: [FAIL][35] ([fdo#100368]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl9/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][37] ([fdo#103167]) -> [PASS][38] +4 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb8/igt@[email protected]
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-iclb: [INCOMPLETE][39] ([fdo#107713] / [fdo#110036 ]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][41] ([fdo#108145] / [fdo#110403]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-skl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-skl3/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][43] ([fdo#108341]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb1/igt@kms_psr@no_drrs.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [SKIP][45] ([fdo#109441]) -> [PASS][46] +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6618/shard-iclb7/igt@kms_psr@psr2_primary_mmap_gtt.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110036 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110036
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6618 -> Patchwork_13858
CI-20190529: 20190529
CI_DRM_6618: 7bef836acab541f26d5806697c13181df22f71a1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5120: b3138fbea79d5d7935e53530b90efe3e816236f4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13858: 39b89e427a09312070728bbec82701dc3df3bb77 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13858/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx