mm/migrate.c: initialize pud_entry in migrate_vma()
Subsystems (3)
[email protected]
maintainerPATCH 11/17 mm/migrate.c: initialize pud_entry in migrate_vma()
From: Ralph Campbell <[email protected]>
Subject: mm/migrate.c: initialize pud_entry in migrate_vma()
When CONFIG_MIGRATE_VMA_HELPER is enabled, migrate_vma() calls migrate_vma_collect() which initializes a struct mm_walk but didn't initialize mm_walk.pud_entry. (Found by code inspection) Use a C structure initialization to make sure it is set to NULL.
Fixes 8763cb45ab967 ("mm/migrate: new memory migration helper for use with
device memory")
Signed-off-by Ralph Campbell <[email protected]>
Reviewed-by John Hubbard <[email protected]>
Reviewed-by Andrew Morton <[email protected]>
Cc "Jérôme Glisse" <[email protected]>
Cc Mel Gorman <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
mm/migrate.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
mm/migrate.c renamed from mm/migrate.c~mm-migrate-initialize-pud_entry-in-migrate_vma +7 -10
@@ -2340,16 +2340,13 @@ next:static void migrate_vma_collect (struct migrate_vma *migrate) {struct mmu_notifier_range range; -struct mm_walk mm_walk; - - mm_walk.pmd_entry = migrate_vma_collect_pmd; - mm_walk.pte_entry =NULL ; - mm_walk.pte_hole = migrate_vma_collect_hole; - mm_walk.hugetlb_entry =NULL ; - mm_walk.test_walk =NULL ; - mm_walk.vma = migrate->vma; - mm_walk.mm = migrate->vma->vm_mm; - mm_walk.private = migrate; +struct mm_walk mm_walk = { + .pmd_entry = migrate_vma_collect_pmd, + .pte_hole = migrate_vma_collect_hole, + .vma = migrate->vma, + .mm = migrate->vma->vm_mm, + .private = migrate, + }; mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, NULL, mm_walk.mm, migrate->start,
_