Lua modules removal
cover Lua modules removal
This serie removes 2 Lua modules which are Lua 5.1 only and not actively maintained by upstream.
Francois Perrad (2):
package/lua-msgpack-native: remove it
package/orbit: remove it
Config.in.legacy | 14 ++++++++++++ DEVELOPERS | 1 - package/Config.in | 2 -- package/lua-msgpack-native/Config.in | 12 ---------- .../lua-msgpack-native.hash | 2 -- .../lua-msgpack-native/lua-msgpack-native.mk | 22 ------------------- package/orbit/Config.in | 15 ------------- package/orbit/orbit.hash | 4 ---- package/orbit/orbit.mk | 14 ------------ 9 files changed, 14 insertions(+), 72 deletions(-) delete mode 100644 package/lua-msgpack-native/Config.in delete mode 100644 package/lua-msgpack-native/lua-msgpack-native.hash delete mode 100644 package/lua-msgpack-native/lua-msgpack-native.mk delete mode 100644 package/orbit/Config.in delete mode 100644 package/orbit/orbit.hash delete mode 100644 package/orbit/orbit.mk
Signature · 1 line
2.20.1
PATCH 1/2 package/lua-msgpack-native: remove it
--- Config.in.legacy | 8 +++++++ package/Config.in | 1 - package/lua-msgpack-native/Config.in | 12 ---------- .../lua-msgpack-native.hash | 2 -- .../lua-msgpack-native/lua-msgpack-native.mk | 22 ------------------- 5 files changed, 8 insertions(+), 37 deletions(-) delete mode 100644 package/lua-msgpack-native/Config.in delete mode 100644 package/lua-msgpack-native/lua-msgpack-native.hash delete mode 100644 package/lua-msgpack-native/lua-msgpack-native.mk
Config.in.legacy +8 -0
@@ -144,6 +144,14 @@ endif ############################################################################### +comment "Legacy options removed in 2019.08" + +config BR2_PACKAGE_LUA_MSGPACK_NATIVE + bool "lua-msgpack-native package removed" + select BR2_LEGACY + help + The lua-msgpack-native package was removed. + comment "Legacy options removed in 2019.05" config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_COMPOSITOR
package/Config.in +0 -1
@@ -627,7 +627,6 @@ menu "Lua libraries/modules" source "package/lua-lunitx/Config.in" source "package/lua-markdown/Config.in" source "package/lua-messagepack/Config.in" - source "package/lua-msgpack-native/Config.in" source "package/lua-periphery/Config.in" source "package/lua-sdl2/Config.in" source "package/lua-std-debug/Config.in"
package/lua-msgpack-native/Config.in deleted +0 -12
@@ -1,12 +0,0 @@ -config BR2_PACKAGE_LUA_MSGPACK_NATIVE - bool "lua-msgpack-native" - depends on BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT - help - This is a native, C language implementation of msgpack - (http://msgpack.org) library/protocol for Lua language - - https://github.com/kengonakajima/lua-msgpack-native - -comment "lua-msgpack-native needs Lua 5.1 or LuaJIT" - depends on !BR2_PACKAGE_LUA_5_1 - depends on !BR2_PACKAGE_LUAJIT
package/lua-msgpack-native/lua-msgpack-native.hash deleted +0 -2
@@ -1,2 +0,0 @@ -# locally computed -sha256 025cf91d509fa3985869d18ef9b8eaeb875ff3c9fcf6467beeed6eab3bb35c93 lua-msgpack-native-41a91b994c70389dc9daa1a15678741d8ec41749.tar.gz
package/lua-msgpack-native/lua-msgpack-native.mk deleted +0 -22
@@ -1,22 +0,0 @@ -################################################################################ -# -# lua-msgpack-native -# -################################################################################ - -LUA_MSGPACK_NATIVE_VERSION = 41a91b994c70389dc9daa1a15678741d8ec41749 -LUA_MSGPACK_NATIVE_SITE = $(call github,kengonakajima,lua-msgpack-native,$(LUA_MSGPACK_NATIVE_VERSION)) -LUA_MSGPACK_NATIVE_DEPENDENCIES = luainterpreter -LUA_MSGPACK_NATIVE_LICENSE = Apache-2.0 -LUA_MSGPACK_NATIVE_LICENSE_FILES = LICENSE.txt - -define LUA_MSGPACK_NATIVE_BUILD_CMDS - $(TARGET_CC) $(TARGET_CFLAGS) -fPIC -shared -o $(@D)/msgpack.so $(@D)/mp.c -endef - -define LUA_MSGPACK_NATIVE_INSTALL_TARGET_CMDS - $(INSTALL) -m 755 -D $(@D)/msgpack.so \ - $(TARGET_DIR)/usr/lib/lua/$(LUAINTERPRETER_ABIVER)/msgpack.so -endef - -$(eval $(generic-package))
Signature · 1 line
2.20.1
PATCH 2/2 package/orbit: remove it
In reply to Francois Perrad--- Config.in.legacy | 6 ++++++ DEVELOPERS | 1 - package/Config.in | 1 - package/orbit/Config.in | 15 --------------- package/orbit/orbit.hash | 4 ---- package/orbit/orbit.mk | 14 -------------- 6 files changed, 6 insertions(+), 35 deletions(-) delete mode 100644 package/orbit/Config.in delete mode 100644 package/orbit/orbit.hash delete mode 100644 package/orbit/orbit.mk
Config.in.legacy +6 -0
@@ -152,6 +152,12 @@ config BR2_PACKAGE_LUA_MSGPACK_NATIVE help The lua-msgpack-native package was removed. +config BR2_PACKAGE_ORBIT + bool "orbit package removed" + select BR2_LEGACY + help + The orbit package was removed. + comment "Legacy options removed in 2019.05" config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_COMPOSITOR
DEVELOPERS +0 -1
@@ -236,7 +236,6 @@ F: package/luaexpatutils/ F: package/luaposix/ F: package/luasec/ F: package/lua-ev/ -F: package/orbit/ N: Bartosz Bilas <[email protected]> F: package/qt5/qt5scxml/
package/Config.in +0 -1
@@ -654,7 +654,6 @@ menu "Lua libraries/modules" source "package/luv/Config.in" source "package/luvi/Config.in" source "package/lzlib/Config.in" - source "package/orbit/Config.in" source "package/rings/Config.in" source "package/turbolua/Config.in" source "package/wsapi/Config.in"
package/orbit/Config.in deleted +0 -15
@@ -1,15 +0,0 @@ -config BR2_PACKAGE_ORBIT - bool "orbit" - depends on BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT - select BR2_PACKAGE_LPEG # runtime - select BR2_PACKAGE_LUAFILESYSTEM # runtime - select BR2_PACKAGE_WSAPI_XAVANTE # runtime - help - An MVC web framework for Lua. The design is inspired by - lightweight Ruby frameworks such as Camping - - http://keplerproject.github.com/orbit - -comment "orbit needs a Lua 5.1 interpreter" - depends on !BR2_PACKAGE_LUA_5_1 - depends on !BR2_PACKAGE_LUAJIT
package/orbit/orbit.hash deleted +0 -4
@@ -1,4 +0,0 @@ -# computed by luarocks/buildroot -sha256 91e3c514d5b86918db83666c8889635bb2d50c71d1ab3aeb69c6469c9424089b orbit-2.2.4-1.src.rock -sha256 dd7d37caed0f4ee994e9e64ea4ab292dce549bb609412c84fc47ed079275ae98 orbit/doc/us/license.html -sha256 140134369c1f041abf7d8cd39a5b0c42f8b5e827695ce7c1ef5ca8f0911a0246 orbit/doc/us/license.md
package/orbit/orbit.mk deleted +0 -14
@@ -1,14 +0,0 @@ -################################################################################ -# -# orbit -# -################################################################################ - -ORBIT_VERSION = 2.2.4-1 -ORBIT_SUBDIR = orbit -ORBIT_LICENSE = MIT -ORBIT_LICENSE_FILES = \ - $(ORBIT_SUBDIR)/doc/us/license.html \ - $(ORBIT_SUBDIR)/doc/us/license.md - -$(eval $(luarocks-package))
Signature · 1 line
2.20.1
cover Lua modules removal
In reply to Francois PerradQuoted 2 lines · Francois Perrad
This serie removes 2 Lua modules which are Lua 5.1 only and not actively maintained by upstream.
This needs a bit more context though... Is the intention to remove Lua 5.1? And
what about luajit?
We tend to not remove unmaintained packages unless there is a good reason for it.
Regards,
Arnout
cover Lua modules removal
Le dim. 9 juin 2019 ? 22:37, Arnout Vandecappelle <[email protected]> a ?crit :
Quoted 11 lines · Francois Perrad
Quoted 2 lines
This serie removes 2 Lua modules which are Lua 5.1 only and not actively maintained by upstream.
This needs a bit more context though... Is the intention to remove Lua
5.1? And
what about luajit?
This is a step in order to remove Lua 5.1, but not LuaJIT which stay as is. In otherways, Lua evolves :
- Lua 5.3.5 will be the last one of its serie
- Lua 5.4 is up coming (lua-5.4.0-alpha is already available)
- Lua 5.2.4 was released on 2015
- Lua 5.1.5 was released on 2012.
Lua has two sides :
- an interpreter which could be used with various modules
- a library used as optional dependency
This serie handles only the interpreter side.
Fran?ois
We tend to not remove unmaintained packages unless there is a good reason
Quoted 9 lines
for it.
Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190610/89399ced/attachment.html>
cover Lua modules removal
Quoted 11 lines · Fran?ois Perrad
Le?dim. 9 juin 2019 ??22:37, Arnout Vandecappelle <[email protected] <mailto:[email protected]>> a ?crit?:
On 08/06/2019 23:18, Francois Perrad wrote:
> This serie removes 2 Lua modules which are Lua 5.1 only > and not actively maintained by upstream.
Quoted 5 lines
?This needs a bit more context though... Is the intention to remove Lua 5.1? And what about luajit?
This is a step in order to remove Lua 5.1, but not LuaJIT which stay as is.
So, aren't these two packages relevant for LuaJIT then?
Regards,
Arnout
Quoted 23 lines
In otherways, Lua evolves :
- Lua 5.3.5 will be the last one of its serie
- Lua 5.4 is up coming (lua-5.4.0-alpha is already available)
- Lua 5.2.4 was released on 2015
- Lua 5.1.5 was released on 2012.Lua has two sides :
- an interpreter which could be used with various modules
- a library used as optional dependency
This serie handles only the interpreter side.Fran?ois
?We tend to not remove unmaintained packages unless there is a good reason for it.
?Regards,
?Arnout
_______________________________________________
buildroot mailing list
buildroot at busybox.net <mailto:[email protected]>
http://lists.busybox.net/mailman/listinfo/buildroot
cover Lua modules removal
Le lun. 10 juin 2019 ? 15:17, Arnout Vandecappelle <[email protected]> a ?crit :
Quoted 15 lines · Fran?ois Perrad
Quoted 7 lines
Le dim. 9 juin 2019 ? 22:37, Arnout Vandecappelle <[email protected] <mailto:[email protected]>> a ?crit :
Quoted 5 lines
On 08/06/2019 23:18, Francois Perrad wrote:
> This serie removes 2 Lua modules which are Lua 5.1 only > and not actively maintained by upstream.This needs a bit more context though... Is the intention to remove
Quoted 10 lines
Lua 5.1? And
Quoted 4 lines
what about luajit?
This is a step in order to remove Lua 5.1, but not LuaJIT which stay as
is.
So, aren't these two packages relevant for LuaJIT then?
These two modules could be loaded/used by LuaJIT, but in practice, I don't think they are.
Fran?ois
Quoted 14 lines
Regards,
ArnoutQuoted 11 lines
In otherways, Lua evolves :
- Lua 5.3.5 will be the last one of its serie
- Lua 5.4 is up coming (lua-5.4.0-alpha is already available)
- Lua 5.2.4 was released on 2015
- Lua 5.1.5 was released on 2012.Lua has two sides :
- an interpreter which could be used with various modules
- a library used as optional dependency
This serie handles only the interpreter side.
Quoted 14 lines
Quoted 3 lines
Fran?ois
We tend to not remove unmaintained packages unless there is a good
reason
Quoted 9 lines
for it.
Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot at busybox.net <mailto:[email protected]>
http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190610/65dd322d/attachment.html>
cover Lua modules removal
Hello Fran?ois,
Quoted 4 lines · On Mon, 10 Jun 2019 19:02:58 +0200 Fran?ois Perrad <[email protected]>…
Quoted 2 lines
So, aren't these two packages relevant for LuaJIT then?
These two modules could be loaded/used by LuaJIT, but in practice, I don't think they are.
This is not a very convincing argument. If you really want those packages to be removed, could you send a new iteration of the series that clearly explains in the commit log why the package is removed. Or perhaps they should be kept, and just the "depends on BR2_PACKAGE_LUA_5_1" be removed when you remove Lua 5.1 ?
In the mean time, I'll mark the series as Changes Requested in patchwork.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com