Skip to contentSkip to conversation

package/glslsandbox-player: new package

PATCH Superseded Julien Olivain 3 participants 5 messages Apr 23, 2019 – Feb 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/glslsandbox-player: new package

GLSL Sandbox standalone player allow one to run and render (most of) nice shaders available online on the
http://glslsandbox.com/ website, but without the need of an Internet connection, a web browser or any of its dependencies. Instead, the only requirement of glslsandbox-player is a working EGL and GLESv2 libraries.

This package is useful for stressing and testing GLES shader compiler in GPU drivers.

https://github.com/jolivain/glslsandbox-player

---
 DEVELOPERS                                    |   1 +
 package/Config.in                             |   1 +
 package/glslsandbox-player/Config.in          | 111 ++++++++++++++++++
 .../glslsandbox-player/glslsandbox-player.mk  |  84 +++++++++++++
 4 files changed, 197 insertions(+)
 create mode 100644 package/glslsandbox-player/Config.in
 create mode 100644 package/glslsandbox-player/glslsandbox-player.mk
DEVELOPERS +1 -0
index e5b69c3ade..dbe0270724 100644
@@ -1259,6 +1259,7 @@ F:	package/paho-mqtt-c
 N:	Julien Olivain <[email protected]>
 F:	board/technexion/imx8mpico/
 F:	configs/imx8mpico_defconfig
+F:	package/glslsandbox-player/
 
 N:	Julien Viard de Galbert <[email protected]>
 F:	package/dieharder/
package/Config.in +1 -0
index 091b16d02d..43bad27693 100644
@@ -271,6 +271,7 @@ comment "Graphic applications"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
+	source "package/glslsandbox-player/Config.in"
 	source "package/gnuplot/Config.in"
 	source "package/jhead/Config.in"
 	source "package/kmscube/Config.in"
package/glslsandbox-player/Config.in new file +111 -0

111 lines not on this page · raw message

package/glslsandbox-player/glslsandbox-player.mk new file +84 -0

84 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 package/glslsandbox-player: new package

GLSL Sandbox standalone player allow one to run and render (most of) nice shaders available online on the
http://glslsandbox.com/ website, but without the need of an Internet connection, a web browser or any of its dependencies. Instead, the only requirement of glslsandbox-player is a working EGL and GLESv2 libraries.

This package is useful for stressing and testing GLES shader compiler in GPU drivers.

https://github.com/jolivain/glslsandbox-player

---
Changes v1 -> v2:
- add missing VIVFB windowing system
- use a tag instead of commit id for version

---
 DEVELOPERS                                    |   1 +
 package/Config.in                             |   1 +
 package/glslsandbox-player/Config.in          | 111 ++++++++++++++++++
 .../glslsandbox-player/glslsandbox-player.mk  |  89 ++++++++++++++
 4 files changed, 202 insertions(+)
 create mode 100644 package/glslsandbox-player/Config.in
 create mode 100644 package/glslsandbox-player/glslsandbox-player.mk
DEVELOPERS +1 -0
index e9c521f400..8b23bfbe79 100644
@@ -1271,6 +1271,7 @@ F:	board/technexion/imx8mmpico/
 F:	board/technexion/imx8mpico/
 F:	configs/imx8mmpico_defconfig
 F:	configs/imx8mpico_defconfig
+F:	package/glslsandbox-player/
 
 N:	Julien Viard de Galbert <[email protected]>
 F:	package/dieharder/
package/Config.in +1 -0
index d501b5a65b..9be9b3f172 100644
@@ -272,6 +272,7 @@ comment "Graphic applications"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
+	source "package/glslsandbox-player/Config.in"
 	source "package/gnuplot/Config.in"
 	source "package/jhead/Config.in"
 	source "package/kmscube/Config.in"
package/glslsandbox-player/Config.in new file +111 -0

111 lines not on this page · raw message

package/glslsandbox-player/glslsandbox-player.mk new file +89 -0

89 lines not on this page · raw message

Signature · 1 line
2.21.0
#2 lore raw

PATCH v2 1/1 package/glslsandbox-player: new package

Hello Julien,

Thanks for this contribution! It looks like a useful package for Buildroot, and pretty good overall, but there are a few issues to address, see below.

package/glslsandbox-player/Config.in line 24

Quoted 7 lines · On Thu, 4 Jul 2019 23:25:23 +0200 Julien Olivain <[email protected]> wrote:
package/glslsandbox-player/Config.in new file +7 -0
+if BR2_PACKAGE_GLSLSANDBOX_PLAYER
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_DL_SHADERS
+	bool "Download shaders from http://glslsandbox.com/"
+	help
+	  Download some shaders from http://glslsandbox.com/ to be
+	  embedded in the binary

You can't let a package download stuff on its own, because it defeats the Buildroot download infrastructure: "make source" will not know that these additional files should be downloaded, those files will not be cached on our sources.buildroot.net mirror, etc.

I'm not sure what gets downloaded exactly, but you can either get it downloaded by Buildroot using <pkg>_EXTRA_DOWNLOADS in this package, or create a separate package.

package/glslsandbox-player/Config.in line 44

Quoted 8 lines
package/glslsandbox-player/Config.in new file +8 -0
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_SCRIPTS
+	bool "Install scripts"
+	depends on BR2_USE_MMU # bash, python
+	depends on BR2_USE_WCHAR # python
+	depends on BR2_TOOLCHAIN_HAS_THREADS # python
+	depends on !BR2_STATIC_LIBS # python
+	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
+	select BR2_PACKAGE_PYTHON

BR2_PACKAGE_PYTHON depends on !BR2_PACKAGE_PYTHON3, so you would have to propagate this dependency. But does it work only with Python 2? It does not support Python 3 ?

package/glslsandbox-player/Config.in line 54

Quoted 10 lines
package/glslsandbox-player/Config.in new file +10 -0
+	select BR2_PACKAGE_BASH
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_CURL
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_LIBOPENSSL_BIN if BR2_PACKAGE_LIBOPENSSL
+	select BR2_PACKAGE_LIBRESSL_BIN if BR2_PACKAGE_LIBRESSL
+	select BR2_PACKAGE_MAKE
+	select BR2_PACKAGE_COREUTILS
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_IMAGEMAGICK

So all these dependencies are needed for the helper scripts ?

package/glslsandbox-player/Config.in line 65

Quoted 8 lines
package/glslsandbox-player/Config.in new file +8 -0
+choice
+	prompt "Native windowing system"
+	default BR2_PACKAGE_GLSLSANDBOX_PLAYER_RPI   if BR2_PACKAGE_RPI_USERLAND
+	default BR2_PACKAGE_GLSLSANDBOX_PLAYER_TISGX if BR2_PACKAGE_TI_SGX_UM
+	default BR2_PACKAGE_GLSLSANDBOX_PLAYER_MALI  if BR2_PACKAGE_SUNXI_MALI_MAINLINE
+	default BR2_PACKAGE_GLSLSANDBOX_PLAYER_WL    if BR2_PACKAGE_WAYLAND
+	default BR2_PACKAGE_GLSLSANDBOX_PLAYER_X11   if BR2_PACKAGE_XORG7
+	default BR2_PACKAGE_GLSLSANDBOX_PLAYER_SDL2  if BR2_PACKAGE_SDL2_OPENGLES

Alphabetic ordering would be nice, and also for the below option definitions.

package/glslsandbox-player/Config.in line 71

Quoted 6 lines
package/glslsandbox-player/Config.in new file +6 -0
+	help
+	  Select the native windowing system you wish to use.
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_KMS
+	bool "KMS/DRM/GBM"
+	select BR2_PACKAGE_LIBDRM

You forgot to replicate the libdrm dependencies here.

Quoted 14 lines
package/glslsandbox-player/Config.in new file +14 -0
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_VIVFB
+	bool "Vivante Frame Buffer"
+	depends on BR2_PACKAGE_IMX_GPU_VIV
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_RPI
+	bool "RaspberryPI Frame Buffer"
+	depends on BR2_PACKAGE_RPI_USERLAND
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_TISGX
+	bool "TI/SGX Frame Buffer"
+	depends on BR2_PACKAGE_TI_SGX_UM
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_MALI

package/glslsandbox-player/Config.in line 95

Quoted 10 lines
package/glslsandbox-player/Config.in new file +10 -0
+	bool "Allwinner ARM/Mali Frame Buffer"
+	depends on BR2_PACKAGE_SUNXI_MALI_MAINLINE
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_WL
+	bool "Wayland"
+	depends on BR2_PACKAGE_WAYLAND
+
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_X11
+	bool "X11"
+	depends on BR2_PACKAGE_XORG7

This is probably not sufficient: just having BR2_PACKAGE_XORG7 does not mean any X11 package will be enabled. So you might need a few selects here. Build a minimal configuration with just XORG7=y, and you'll see.

Quoted 6 lines
package/glslsandbox-player/glslsandbox-player.mk new file +0 -0
new file mode 100644
index 0000000000..b3048345ce

package/glslsandbox-player/glslsandbox-player.mk line 9

Quoted 9 lines
package/glslsandbox-player/glslsandbox-player.mk new file +9 -0
@@ -0,0 +1,89 @@
+################################################################################
+#
+# glslsandbox-player
+#
+################################################################################
+
+GLSLSANDBOX_PLAYER_VERSION = v2019.06.16
+GLSLSANDBOX_PLAYER_SITE = https://github.com/jolivain/glslsandbox-player
+GLSLSANDBOX_PLAYER_SITE_METHOD = git

Use the $(call github, ...) macro, see other packages.

package/glslsandbox-player/glslsandbox-player.mk line 36

Quoted 2 lines
package/glslsandbox-player/glslsandbox-player.mk new file +2 -0
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_SCRIPTS),y)
+GLSLSANDBOX_PLAYER_CONF_OPTS += --enable-install-scripts

You have tons of dependencies in the Config.in for those scripts. They are only runtime dependencies ? If so, you should add a "# runtime" comment in Config.in.

Quoted 34 lines
package/glslsandbox-player/glslsandbox-player.mk new file +34 -0
+else
+GLSLSANDBOX_PLAYER_CONF_OPTS += --disable-install-scripts
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_KMS),y)
+# gbm dependency is not needed, as it is normally packaged with
+# libegl/libgles drivers.
+GLSLSANDBOX_PLAYER_DEPENDENCIES += libdrm
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=kms
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_VIVFB),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += imx-gpu-viv
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=vivfb
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_RPI),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += rpi-userland
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=rpi
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_TISGX),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += ti-sgx-um
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=tisgx
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_MALI),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += sunxi-mali-mainline
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=mali
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_WL),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += wayland
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=wl

package/glslsandbox-player/glslsandbox-player.mk line 80

Quoted 10 lines
package/glslsandbox-player/glslsandbox-player.mk new file +10 -0
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_WL_IVI),y)
+GLSLSANDBOX_PLAYER_CONF_OPTS += --enable-ivi
+else
+GLSLSANDBOX_PLAYER_CONF_OPTS += --disable-ivi
+endif
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_X11),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += xlib_libX11

Ah, so you need xlib_libX11, but it's not selected by the Config.in.

package/glslsandbox-player/glslsandbox-player.mk line 87

Quoted 7 lines
package/glslsandbox-player/glslsandbox-player.mk new file +7 -0
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=x11
+endif
+
+ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_SDL2),y)
+GLSLSANDBOX_PLAYER_DEPENDENCIES += sdl2
+GLSLSANDBOX_PLAYER_CONF_OPTS += --with-native-gfx=sdl2
+endif

Since only one of these gfx backends can be selected at once, I'd prefer if the makefile looked like this:

ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_foo),y)
...
else ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_bar),y) ..
else ifeq ($(BR2_PACKAGE_GLSLSANDBOX_PLAYER_baz),y) ..
endif

Could you fix the above issues and send an updated version of the patch ?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v3 1/1 package/glslsandbox-player: new package

In reply to Julien Olivain

GLSL Sandbox standalone player allow one to run and render (most of) nice shaders available online on the
http://glslsandbox.com/ website, but without the need of an Internet connection, a web browser or any of its dependencies. Instead, the only requirement of glslsandbox-player is a working EGL and GLESv2 libraries.

This package is useful for stressing and testing GLES shader compiler in GPU drivers.

https://github.com/jolivain/glslsandbox-player

---
Changes v2 -> v3:
Included all Thomas' comments:
- Config.in:
- Remove shader download option, to not defeat buildroot download infra
- Update scripts to Pytnon 3, and update dependencies
- Mark all runtime dependencies with "# runtime"
- Sort dependencies and options alphabetically
- Replicate libdrm dependencies
- Add missing dependency on xlib_libX11
- .mk:
- Update package to v2019.08.23
- Use $(call github, ...) for _SITE
- Sort blocks alphabetically
- Use ifeq() ... else ifeq() for exclusive choices of backend
- Add .hash file

Changes v1 -> v2:
- add missing VIVFB windowing system
- use a tag instead of commit id for version

---
 DEVELOPERS                                    |   1 +
 package/Config.in                             |   1 +
 package/glslsandbox-player/Config.in          | 108 ++++++++++++++++++
 .../glslsandbox-player.hash                   |   3 +
 .../glslsandbox-player/glslsandbox-player.mk  |  72 ++++++++++++
 5 files changed, 185 insertions(+)
 create mode 100644 package/glslsandbox-player/Config.in
 create mode 100644 package/glslsandbox-player/glslsandbox-player.hash
 create mode 100644 package/glslsandbox-player/glslsandbox-player.mk
DEVELOPERS +1 -0
index e50ac78ae7..2bf0b612f9 100644
@@ -1296,6 +1296,7 @@ F:	board/technexion/imx8mmpico/
 F:	board/technexion/imx8mpico/
 F:	configs/imx8mmpico_defconfig
 F:	configs/imx8mpico_defconfig
+F:	package/glslsandbox-player/
 
 N:	Julien Viard de Galbert <[email protected]>
 F:	package/dieharder/
package/Config.in +1 -0
index 710ed12be0..fe4f575922 100644
@@ -275,6 +275,7 @@ comment "Graphic applications"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
+	source "package/glslsandbox-player/Config.in"
 	source "package/gnuplot/Config.in"
 	source "package/jhead/Config.in"
 	source "package/kmscube/Config.in"
package/glslsandbox-player/Config.in new file +108 -0

108 lines not on this page · raw message

package/glslsandbox-player/glslsandbox-player.hash new file +3 -0
new file mode 100644
index 0000000000..2d25b4bb40
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  3458294a50c3d2fd54f806e46dd7bfba5f1e6aedadd6c396c76d70793419432b  glslsandbox-player-v2019.08.23.tar.gz
+sha256  06a79395e8f3a4cc7ad068c6b59dfbe12c0efa4d27791e532345ceb1f41aea8a  LICENSE
package/glslsandbox-player/glslsandbox-player.mk new file +72 -0

72 lines not on this page · raw message

Signature · 1 line
2.21.0
#4 lore raw

PATCH v3 1/1 package/glslsandbox-player: new package

Hi Julien,

We finally applied, with a few changes.

On 23/08/2019 22:57, Julien Olivain wrote:
[snip]

package/glslsandbox-player/Config.in line 4

Quoted 10 lines
package/glslsandbox-player/Config.in new file +4 -0
new file mode 100644
index 0000000000..973b8f6c98
@@ -0,0 +1,108 @@
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER
+	bool "glslsandbox-player"
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	depends on BR2_PACKAGE_HAS_LIBGLES

I added this:

# Doesn't really depend on threads, but this makes sure we have at least # one native windowing system available, and is good enough in practice. depends on BR2_TOOLCHAIN_HAS_THREADS

Makes sense?

[snip]

package/glslsandbox-player/Config.in line 39

Quoted 9 lines
package/glslsandbox-player/Config.in new file +9 -0
+config BR2_PACKAGE_GLSLSANDBOX_PLAYER_SCRIPTS
+	bool "Install scripts"
+	depends on !BR2_PACKAGE_PYTHON # python3
+	depends on !BR2_STATIC_LIBS # python3
+	depends on BR2_TOOLCHAIN_HAS_THREADS # python3
+	depends on BR2_USE_MMU # bash, python3
+	depends on BR2_USE_WCHAR # python3
+	select BR2_PACKAGE_BASH # runtime
+	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash

This creates a problem if busybox is not selected so it should be

select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS if BR2_PACKAGE_BUSYBOX # bash

package/glslsandbox-player/Config.in line 40

Quoted 1 line
package/glslsandbox-player/Config.in new file +1 -0
+	select BR2_PACKAGE_COREUTILS # runtime (timeout)

If it is just for timeout, do you really need coreutils? Busybox has a timeout
utility as well. Anyway, I didn't change this.

Thanks!
Regards,
Arnout

[snip]