Skip to contentSkip to conversation

libsub-exporter-progressive-perl: Replace DEPENDS_PN with DEPENDS

PATCH In review Khem Raj 3 participants 5 messages Aug 3, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 libsub-exporter-progressive-perl: Replace DEPENDS_PN with DEPENDS

Fixes
libsub-exporter-progressive-perl_0.001013.bb: QA Issue: recipe uses DEPENDS_${PN}, should use DEPENDS [pkgvarcheck]

---
 .../libsub/libsub-exporter-progressive-perl_0.001013.bb         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb +1 -1
index 64d19c0f1f..e484f4a7a0 100644
@@ -13,7 +13,7 @@ HOMEPAGE = "https://metacpan.org/pod/Sub-Exporter-Progressive/"
 LICENSE = "Artistic-1.0 | GPL-1.0+"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=003fa970662359a43ac2c2961108b0f1"
 
-DEPENDS_${PN} = " perl-module-test-more"
+DEPENDS += " perl-module-test-more"
 
 SRC_URI = "${CPAN_MIRROR}/authors/id/F/FR/FREW/Sub-Exporter-Progressive-${PV}.tar.gz"
 SRC_URI[md5sum] = "72cf6acdd2a0a8b105821a4db98e4ebe"
Signature · 1 line
2.22.0
author
#1 lore raw

PATCH 2/2 klcc-cross: Recognise --unwindlib clang option

---
 .../klibc/files/klcc-cross-accept-clang-options.patch | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
meta-initramfs/recipes-devtools/klibc/files/klcc-cross-accept-clang-options.patch +6 -5
index 07703aa536..3b7031e981 100644
@@ -3,16 +3,17 @@ meta-clang passes this option to compiler defaults
 Upstream-Status: Pending
 Signed-off-by: Khem Raj <[email protected]>
 
-Index: git/klcc/klcc.in
-===================================================================
---- git.orig/klcc/klcc.in
-+++ git/klcc/klcc.in
-@@ -207,6 +207,9 @@ while ( defined($a = shift(@ARGV)) ) {
+--- a/klcc/klcc.in
++++ b/klcc/klcc.in
+@@ -207,6 +207,12 @@ while ( defined($a = shift(@ARGV)) ) {
      } elsif ( $a =~ /^--([sysroot=])(.*)$/ ) {
  	# Override gcc encoded sysroot
  	push(@ccopt, $a);
 +    } elsif ( $a eq '-no-integrated-as' ) {
 +	# Allow clang options
++	push(@ccopt, $a);
++    } elsif ( $a =~ '--unwindlib=.*' ) {
++	# Allow clang options
 +	push(@ccopt, $a);
      } else {
  	die "$0: unknown option: $a\n";
Signature · 1 line
2.22.0
#2 lore raw
In reply to Khem Raj

Shouldn't this one be rather RDEPENDS_${PN}?

It was building without this build time dependency before and it's not -native, so I guess it was rather typo in runtime dependency?

Quoted 38 lines · Khem Raj

Fixes
libsub-exporter-progressive-perl_0.001013.bb: QA Issue: recipe uses DEPENDS_${PN}, should use DEPENDS [pkgvarcheck]

---
 .../libsub/libsub-exporter-progressive-perl_0.001013.bb         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

libsub-exporter-progressive-perl_0.001013.bb
b/meta-perl/recipes-perl/libsub/
libsub-exporter-progressive-perl_0.001013.bb
index 64d19c0f1f..e484f4a7a0 100644
--- a/meta-perl/recipes-perl/libsub/
libsub-exporter-progressive-perl_0.001013.bb
+++ b/meta-perl/recipes-perl/libsub/
libsub-exporter-progressive-perl_0.001013.bb

(quoted diff) +0 -0
@@ -13,7 +13,7 @@ HOMEPAGE = "

https://metacpan.org/pod/Sub-Exporter-Progressive/"
LICENSE = "Artistic-1.0 | GPL-1.0+"
LIC_FILES_CHKSUM = "file://LICENSE;md5=003fa970662359a43ac2c2961108b0f1"

meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb +1 -1
-DEPENDS_${PN} = " perl-module-test-more"
+DEPENDS += " perl-module-test-more"
 
 SRC_URI =

"${CPAN_MIRROR}/authors/id/F/FR/FREW/Sub-Exporter-Progressive-${PV}.tar.gz"
SRC_URI[md5sum] = "72cf6acdd2a0a8b105821a4db98e4ebe"
--
2.22.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#3 lore raw

Yes, you are right. I already fixed it locally will send v2 soon

Quoted 46 lines · Martin Jansa

Shouldn't this one be rather RDEPENDS_${PN}?

It was building without this build time dependency before and it's not -native, so I guess it was rather typo in runtime dependency?

Quoted 38 lines · Khem Raj

Fixes
libsub-exporter-progressive-perl_0.001013.bb: QA Issue: recipe uses DEPENDS_${PN}, should use DEPENDS [pkgvarcheck]

---
 .../libsub/libsub-exporter-progressive-perl_0.001013.bb         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

libsub-exporter-progressive-perl_0.001013.bb
b/meta-perl/recipes-perl/libsub/
libsub-exporter-progressive-perl_0.001013.bb
index 64d19c0f1f..e484f4a7a0 100644
--- a/meta-perl/recipes-perl/libsub/
libsub-exporter-progressive-perl_0.001013.bb
+++ b/meta-perl/recipes-perl/libsub/
libsub-exporter-progressive-perl_0.001013.bb

(quoted diff) +0 -0
@@ -13,7 +13,7 @@ HOMEPAGE = "

https://metacpan.org/pod/Sub-Exporter-Progressive/"
LICENSE = "Artistic-1.0 | GPL-1.0+"
LIC_FILES_CHKSUM = "file://LICENSE;md5=003fa970662359a43ac2c2961108b0f1"

meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb +1 -1
-DEPENDS_${PN} = " perl-module-test-more"
+DEPENDS += " perl-module-test-more"
 
 SRC_URI =

"${CPAN_MIRROR}/authors/id/F/FR/FREW/Sub-Exporter-Progressive-${PV}.tar.gz"
SRC_URI[md5sum] = "72cf6acdd2a0a8b105821a4db98e4ebe"
--
2.22.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw
In reply to Martin Jansa
Quoted 4 lines · Martin Jansa

Shouldn't this one be rather RDEPENDS_${PN}?

It was building without this build time dependency before and it's not -native, so I guess it was rather typo in runtime dependency?

This also sounds wrong to me.

As expected it uses Test::More only when running tests, so forcing a runtime dependency is unnecessary.

RDEPENDS_${PN}-ptest would be correct if there was a ptest package.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed