package/rcw: add option to generate the RCW
PATCH v3 1/1 package/rcw: add option to generate the RCW
From: Jared Bents <[email protected]>
When the rcw tools is built, it is probably to generate the RCW (Reset Configuration Word) of the target. So it makes sense to do this directly in the Buildroot infra and install it in the images directory, just like we do for e.g. device tree blobs.
Add an option BR2_PACKAGE_HOST_RCW_CUSTOM_PATH that allows to specify the source for the RCW. And while we're at it, make it possible to specify multiple .rcw and .rcwi files, just like for device trees.
[Arnout:
* Reword help text and commit message
* Remove definition of RCW_DELIVERY_FILE
* Define and use RCW_FILES
* Enclose everything in ifneq($(RCW_FILES),)
* Enclose error in ifeq($(BR_BUILDING),y)
* Add actual error message
* Don't limit to only %.rcwi files
* Don't delete *.bin
]
---
Note to Jared: if you follow my suggestion of not copying things, then most of my changes become irrelevant, so you can remove the piece between square brackets above.
[v2 -> v3](Arnout):
* Reword help text and commit message
* Remove definition of RCW_DELIVERY_FILE
* Define and use RCW_FILES
* Enclose everything in ifneq($(RCW_FILES),)
* Enclose error in ifeq($(BR_BUILDING),y)
* Add actual error message
* Don't limit to only %.rcwi files
* Don't delete *.bin
[v1 -> v2](Jared):
* Removed host-python dependency
* Updated help for BR2_PACKAGE_HOST_RCW_CUSTOM_PATH
* Added error for number of .rcw not equal to 1
* Removed symlinks
* Split large install command into different commands
* Resolved utils/check-package warnings
--- package/rcw/Config.in.host | 16 ++++++++++++++++ package/rcw/rcw.mk | 30 ++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+)
package/rcw/Config.in.host +16 -0
@@ -10,3 +10,19 @@ config BR2_PACKAGE_HOST_RCW then use this toolset and examples. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw/ + +if BR2_PACKAGE_HOST_RCW + +config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH + string "RCW Source file paths" + help + Space-separated list of .rcw and .rcwi files, that will be + used to generate a RCW binary. The entire list of .rcwi files + used by the .rcw file must be specified. There must be a + single .rcw file in the list. + + This is optional. If left empty, the rcw package will be + included for use in the SDK or with post scripts but no + RCW binary will not be generated. + +endif
package/rcw/rcw.mk +30 -0
@@ -10,11 +10,41 @@ RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE +RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) + +ifneq ($(RCW_FILES),) +# Get the name of the custom rcw file from the custom list +RCW_PROJECT = $(notdir $(filter %.rcw,$(RCW_FILES))) + +# Error if there are no or more than one .rcw file +ifeq ($(BR_BUILDING),y) +ifneq ($(words $(RCW_PROJECT)),1) +$(error BR2_PACKAGE_HOST_RCW_CUSTOM_PATH must have exactly one .rcw file) +endif +endif + +define HOST_RCW_ADD_CUSTOM_RCW_FILES + mkdir -p $(@D)/custom_board/rcw + cp -f $(filter-out %.rcw,$(RCW_FILES)) $(@D)/custom_board + cp -f $(filter %.rcw,$(RCW_FILES)) $(@D)/custom_board/rcw +endef +HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES + +define HOST_RCW_BUILD_CMDS + python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin +endef + +define HOST_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin +endef +endif + # Copy source files and script into $(HOST_DIR)/share/rcw/ so a developer # could use a post image or SDK to build/install PBL files. define HOST_RCW_INSTALL_CMDS mkdir -p $(HOST_DIR)/share/rcw cp -a $(@D)/* $(HOST_DIR)/share/rcw + $(HOST_RCW_INSTALL_DELIVERY_FILE) endef $(eval $(host-generic-package))
Signature · 1 line
2.21.0
PATCH v3 1/1 package/rcw: add option to generate the RCW
Hi Arnout,
Quoted 23 lines · Arnout Vandecappelle (Essensium/Mind)
From: Jared Bents <[email protected]>
When the rcw tools is built, it is probably to generate the RCW (Reset Configuration Word) of the target. So it makes sense to do this directly in the Buildroot infra and install it in the images directory, just like we do for e.g. device tree blobs.
Add an option
BR2_PACKAGE_HOST_RCW_CUSTOM_PATHthat allows to specify the source for the RCW. And while we're at it, make it possible to specify multiple .rcw and .rcwi files, just like for device trees.Signed-off-by Jared Bents <[email protected]>[Arnout:
* Reword help text and commit message
* Remove definition ofRCW_DELIVERY_FILE
* Define and useRCW_FILES
* Enclose everything in ifneq($(RCW_FILES),)
* Enclose error in ifeq($(BR_BUILDING),y)
* Add actual error message
* Don't limit to only %.rcwi files
* Don't delete *.bin
]
Quoted 1 line
These changes make sense. I have tested with your v3 patch and it is working.
- Jared
Quoted 100 lines
---
Note to Jared: if you follow my suggestion of not copying things, then most of my changes become irrelevant, so you can remove the piece between square brackets above.[v2 -> v3](Arnout):
* Reword help text and commit message
* Remove definition ofRCW_DELIVERY_FILE
* Define and useRCW_FILES
* Enclose everything in ifneq($(RCW_FILES),)
* Enclose error in ifeq($(BR_BUILDING),y)
* Add actual error message
* Don't limit to only %.rcwi files
* Don't delete *.bin[v1 -> v2](Jared):
* Removed host-python dependency
* Updated help forBR2_PACKAGE_HOST_RCW_CUSTOM_PATH
* Added error for number of .rcw not equal to 1
* Removed symlinks
* Split large install command into different commands
* Resolved utils/check-package warnings--- package/rcw/Config.in.host | 16 ++++++++++++++++ package/rcw/rcw.mk | 30 ++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+)package/rcw/Config.in.host +16
-0@@ -10,3 +10,19 @@ config BR2_PACKAGE_HOST_RCW then use this toolset and examples. https://source.codeaurora.org/external/qoriq/qoriq-components/rcw/ + +if BR2_PACKAGE_HOST_RCW + +config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH + string "RCW Source file paths" + help + Space-separated list of .rcw and .rcwi files, that will be + used to generate a RCW binary. The entire list of .rcwi files + used by the .rcw file must be specified. There must be a + single .rcw file in the list. + + This is optional. If left empty, the rcw package will be + included for use in the SDK or with post scripts but no + RCW binary will not be generated. + +endifpackage/rcw/rcw.mk +30
-1@@ -10,11 +10,41 @@ RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause RCW_LICENSE_FILES = LICENSE +RCW_FILES = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_CUSTOM_PATH)) + +ifneq ($(RCW_FILES),) +# Get the name of the custom rcw file from the custom list +RCW_PROJECT = $(notdir $(filter %.rcw,$(RCW_FILES))) + +# Error if there are no or more than one .rcw file +ifeq ($(BR_BUILDING),y) +ifneq ($(words $(RCW_PROJECT)),1) +$(error BR2_PACKAGE_HOST_RCW_CUSTOM_PATH must have exactly one .rcw file) +endif +endif + +define HOST_RCW_ADD_CUSTOM_RCW_FILES + mkdir -p $(@D)/custom_board/rcw + cp -f $(filter-out %.rcw,$(RCW_FILES)) $(@D)/custom_board + cp -f $(filter %.rcw,$(RCW_FILES)) $(@D)/custom_board/rcw +endef +HOST_RCW_POST_PATCH_HOOKS += HOST_RCW_ADD_CUSTOM_RCW_FILES + +define HOST_RCW_BUILD_CMDS + python $(@D)/rcw.py -i $(@D)/custom_board/rcw/$(RCW_PROJECT) -I $(@D)/custom_board -o $(@D)/PBL.bin +endef + +define HOST_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin +endef +endif + # Copy source files and script into $(HOST_DIR)/share/rcw/ so a developer # could use a post image or SDK to build/install PBL files. define HOST_RCW_INSTALL_CMDS mkdir -p $(HOST_DIR)/share/rcw cp -a $(@D)/* $(HOST_DIR)/share/rcw + $(HOST_RCW_INSTALL_DELIVERY_FILE) endef $(eval $(host-generic-package)) --2.21.0
Thomas Petazzoni
AppliedPATCH v3 1/1 package/rcw: add option to generate the RCW
In reply to Arnout Vandecappelle (Essensium/Mind)Quoted 22 lines · On Sat, 3 Aug 2019 23:00:52 +0200 "Arnout Vandecappelle (Essensium/Mind)"…
From: Jared Bents <[email protected]>
When the rcw tools is built, it is probably to generate the RCW (Reset Configuration Word) of the target. So it makes sense to do this directly in the Buildroot infra and install it in the images directory, just like we do for e.g. device tree blobs.
Add an option
BR2_PACKAGE_HOST_RCW_CUSTOM_PATHthat allows to specify the source for the RCW. And while we're at it, make it possible to specify multiple .rcw and .rcwi files, just like for device trees.Signed-off-by Jared Bents <[email protected]>[Arnout:
* Reword help text and commit message
* Remove definition ofRCW_DELIVERY_FILE
* Define and useRCW_FILES
* Enclose everything in ifneq($(RCW_FILES),)
* Enclose error in ifeq($(BR_BUILDING),y)
* Add actual error message
* Don't limit to only %.rcwi files
* Don't delete *.bin
]
Quoted 5 lines
---
Note to Jared: if you follow my suggestion of not copying things, then most of my changes become irrelevant, so you can remove the piece between square brackets above.
Applied to next, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com