nvme: add support for Get LBA Status tracing
Subsystems (2)
cover nvme: add support for Get LBA Status tracing
Hi All,
This series introduces command tracing in both host and target side for the Get LBA Statas admin command which has been added from NVMe 1.4.
Please review.
Thanks,
Minwoo Im (4):
nvme: add Get LBA Status command opcode
nvme: trace: support for Get LBA Status opcode parsed
nvme: trace: parse Get LBA Status command in detail
nvmet: trace: parse Get LBA Status command in detail
drivers/nvme/host/trace.c | 18 ++++++++++++++++++ drivers/nvme/target/trace.c | 18 ++++++++++++++++++ include/linux/nvme.h | 4 +++- 3 files changed, 39 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
PATCH 1/4 nvme: add Get LBA Status command opcode
NVMe 1.4 added Get LBA Status command with opcode 0x86.
--- include/linux/nvme.h | 1 + 1 file changed, 1 insertion(+)
include/linux/nvme.h +1 -0
@@ -814,6 +814,7 @@ enum nvme_admin_opcode { nvme_admin_security_send =0x81 , nvme_admin_security_recv =0x82 , nvme_admin_sanitize_nvm =0x84 , + nvme_admin_get_lba_status = 0x86, };#define nvme_admin_opcode_name (opcode) { opcode, #opcode }
Signature · 1 line
2.17.1
PATCH 2/4 nvme: trace: support for Get LBA Status opcode parsed
In reply to Minwoo ImThis patch adds Get LBA Status command's opcode to the macro that is used by the trace feature. Now we can see "get_lba_status" instead of the opcode value itself.
--- include/linux/nvme.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/nvme.h +2 -1
@@ -841,7 +841,8 @@ enum nvme_admin_opcode { nvme_admin_opcode_name(nvme_admin_format_nvm), \ nvme_admin_opcode_name(nvme_admin_security_send), \ nvme_admin_opcode_name(nvme_admin_security_recv), \ - nvme_admin_opcode_name(nvme_admin_sanitize_nvm)) + nvme_admin_opcode_name(nvme_admin_sanitize_nvm), \ + nvme_admin_opcode_name(nvme_admin_get_lba_status)) enum { NVME_QUEUE_PHYS_CONTIG = (1 << 0),
Signature · 1 line
2.17.1
PATCH 3/4 nvme: trace: parse Get LBA Status command in detail
In reply to Minwoo ImFour different fields are in CDWs of Get LBA Status command which means it would be great if we can see in detail when tracing.
--- drivers/nvme/host/trace.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/nvme/host/trace.c +18 -0
@@ -86,6 +86,22 @@ static const char *nvme_trace_admin_get_features(struct trace_seq *p,return ret; } +static const char *nvme_trace_get_lba_status (struct trace_seq *p, +u8 *cdw10) +{ +const char *ret =trace_seq_buffer_ptr (p); +u64 slba =get_unaligned_le64 (cdw10); +u32 mndw =get_unaligned_le32 (cdw10 +8 ); +u16 rl =get_unaligned_le16 (cdw10 +12 ); +u8 atype = cdw10[15 ]; + +trace_seq_printf (p,"slba=0x%llx, mndw=0x%x, rl=0x%x, atype=%u" , + slba, mndw, rl, atype); +trace_seq_putc (p,0 ); + +return ret; +} +static const char *nvme_trace_read_write (struct trace_seq *p,u8 *cdw10) {const char *ret =trace_seq_buffer_ptr (p);
@@ -141,6 +157,8 @@ const char *nvme_trace_parse_admin_cmd(struct trace_seq *p,return nvme_trace_admin_identify (p, cdw10);case nvme_admin_get_features:return nvme_trace_admin_get_features (p, cdw10); +case nvme_admin_get_lba_status: +return nvme_trace_get_lba_status (p, cdw10);default :return nvme_trace_common (p, cdw10); }
Signature · 1 line
2.17.1
PATCH 4/4 nvmet: trace: parse Get LBA Status command in detail
In reply to Minwoo ImFour different fields are in CDWs of Get LBA Status command which means it would be great if we can see in detail when tracing in target side also.
--- drivers/nvme/target/trace.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/nvme/target/trace.c +18 -0
@@ -33,6 +33,22 @@ static const char *nvmet_trace_admin_get_features(struct trace_seq *p,return ret; } +static const char *nvmet_trace_get_lba_status (struct trace_seq *p, +u8 *cdw10) +{ +const char *ret =trace_seq_buffer_ptr (p); +u64 slba =get_unaligned_le64 (cdw10); +u32 mndw =get_unaligned_le32 (cdw10 +8 ); +u16 rl =get_unaligned_le16 (cdw10 +12 ); +u8 atype = cdw10[15 ]; + +trace_seq_printf (p,"slba=0x%llx, mndw=0x%x, rl=0x%x, atype=%u" , + slba, mndw, rl, atype); +trace_seq_putc (p,0 ); + +return ret; +} +static const char *nvmet_trace_read_write (struct trace_seq *p,u8 *cdw10) {const char *ret =trace_seq_buffer_ptr (p);
@@ -80,6 +96,8 @@ const char *nvmet_trace_parse_admin_cmd(struct trace_seq *p,return nvmet_trace_admin_identify (p, cdw10);case nvme_admin_get_features:return nvmet_trace_admin_get_features (p, cdw10); +case nvme_admin_get_lba_status: +return nvmet_trace_get_lba_status (p, cdw10);default :return nvmet_trace_common (p, cdw10); }
Signature · 1 line
2.17.1
Sagi Grimberg
maintainercover nvme: add support for Get LBA Status tracing
In reply to Minwoo ImQuoted 7 lines
Hi All,
This series introduces command tracing in both host and target side for the Get LBA Statas admin command which has been added from NVMe 1.4.
Please review.
Series looks fine to me,
Pulling to nvme-5.4