pinctrl: falcon: Add of_node_put() before return
Subsystems (2)
PATCH 1/1 pinctrl: falcon: Add of_node_put() before return
Each iteration of for_each_compatible_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/pinctrl/pinctrl-falcon.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pinctrl/pinctrl-falcon.c +4 -1
@@ -455,12 +455,15 @@ static int pinctrl_falcon_probe(struct platform_device *pdev) falcon_info.clk[*bank] =clk_get (&ppdev->dev,NULL );if (IS_ERR (falcon_info.clk[*bank])) {dev_err (&ppdev->dev,"failed to get clock\n" ); +of_node_put (np) return PTR_ERR(falcon_info.clk[*bank]); } falcon_info.membase[*bank] =devm_ioremap_resource (&pdev->dev, &res); -if (IS_ERR (falcon_info.membase[*bank])) +if (IS_ERR (falcon_info.membase[*bank])) { +of_node_put (np);return PTR_ERR (falcon_info.membase[*bank]); + } avail =pad_r32 (falcon_info.membase[*bank],LTQ_PADC_AVAIL );
Signature · 1 line
2.19.1
Quoted 7 lines · Nishka Dasgupta
Each iteration of
for_each_compatible_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in two places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch applied!
Yours,
Linus Walleij