pinctrl: nomadik: nomadik: Add of_node_put() before return
Subsystems (3)
PATCH 1/1 pinctrl: nomadik: nomadik: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/nomadik/pinctrl-nomadik.c +1 -0
@@ -1508,6 +1508,7 @@ static int nmk_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps);if (ret <0 ) {pinctrl_utils_free_map (pctldev, *map, *num_maps); +of_node_put (np);return ret; } }
Signature · 1 line
2.19.1
Quoted 6 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return. Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch applied.
Yours,
Linus Walleij