pinctrl: freescale: mxs: Add of_node_put() before return
Subsystems (4)
PATCH 1/1 pinctrl: freescale: mxs: Add of_node_put() before return
Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in three places.
Issue found with Coccinelle.
Signed-off-by Nishka Dasgupta <[email protected]>
--- drivers/pinctrl/freescale/pinctrl-mxs.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/pinctrl/freescale/pinctrl-mxs.c +9 -3
@@ -488,8 +488,10 @@ static int mxs_pinctrl_probe_dt(struct platform_device *pdev,if (of_property_read_u32 (child,"reg" , &val)) { ret =mxs_pinctrl_parse_group (pdev, child, idxg++,NULL ); -if (ret) +if (ret) { +of_node_put (child);return ret; + }continue ; }
@@ -499,15 +501,19 @@ static int mxs_pinctrl_probe_dt(struct platform_device *pdev, f->ngroups,sizeof (*f->groups), GFP_KERNEL); -if (!f->groups) +if (!f->groups) { +of_node_put (child);return -ENOMEM ; + } fn = child->name; i =0 ; } ret =mxs_pinctrl_parse_group (pdev, child, idxg++, &f->groups[i++]); -if (ret) +if (ret) { +of_node_put (child);return ret; + } }return 0 ;
Signature · 1 line
2.19.1
Quoted 7 lines · Nishka Dasgupta
Each iteration of
for_each_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in three places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>
Patch applied.
Yours,
Linus Walleij