slimbus: qcom-ngd-ctrl: Add of_node_put() before return
PATCH 1/1 slimbus: qcom-ngd-ctrl: Add of_node_put() before return
Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return in two places.
Issue found with Coccinelle.
--- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/slimbus/qcom-ngd-ctrl.c +4 -1
@@ -1338,12 +1338,15 @@ static int of_qcom_slim_ngd_register(struct device *parent,continue ; ngd =kzalloc (sizeof (*ngd),GFP_KERNEL ); -if (!ngd) +if (!ngd) { +of_node_put (node);return -ENOMEM ; + } ngd->pdev =platform_device_alloc (QCOM_SLIM_NGD_DRV_NAME , id);if (!ngd->pdev) {kfree (ngd); +of_node_put (node);return -ENOMEM ; } ngd->id = id;
Signature · 1 line
2.19.1
Quoted 6 lines · Nishka Dasgupta
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in two places.
Issue found with Coccinelle.
Quoted 29 lines
Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/slimbus/qcom-ngd-ctrl.c +4
-1@@ -1338,12 +1338,15 @@ static int of_qcom_slim_ngd_register(struct device *parent,continue ; ngd =kzalloc (sizeof (*ngd),GFP_KERNEL ); -if (!ngd) +if (!ngd) { +of_node_put (node);return -ENOMEM ; + } ngd->pdev =platform_device_alloc (QCOM_SLIM_NGD_DRV_NAME , id);if (!ngd->pdev) {kfree (ngd); +of_node_put (node);return -ENOMEM ; } ngd->id = id;Signature · 1 line
2.19.1
Quoted 10 lines · Nishka Dasgupta
Each iteration of
for_each_available_child_of_nodeputs the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add anof_node_putbefore the return in two places.
Issue found with Coccinelle.Signed-off-by Nishka Dasgupta <[email protected]>--- drivers/slimbus/qcom-ngd-ctrl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Applied Thanks,
--srini